opendev/gerrit
Code Issues Proposed changes

ConfigNotesMigration: Remove rambling comment about sequences

Browse Source 
The series of migration steps is more or less fixed, so we're not
revisiting this decision.

Change-Id: I665e23b890dffb36279a62bc962c1d4b4bc52a1a
This commit is contained in:
Dave Borowitz 2017-07-12 07:45:28 -04:00
parent c124130e9a
commit 541bfcc70e
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-server/src/main/java/com/google/gerrit/server/notedb/ConfigNotesMigration.java
View File

@ -85,13 +85,7 @@ public class ConfigNotesMigration extends NotesMigration {
static Snapshot create(Config cfg) {
boolean writeChanges = cfg.getBoolean(SECTION_NOTE_DB, CHANGES.key(), WRITE, false);
boolean readChanges = cfg.getBoolean(SECTION_NOTE_DB, CHANGES.key(), READ, false);
// Reading change sequence numbers from NoteDb is not the default even if
// reading changes themselves is. Once this is enabled, it's not easy to
// undo: ReviewDb might hand out numbers that have already been assigned by
// NoteDb. This decision for the default may be reevaluated later.
boolean readChangeSequence = cfg.getBoolean(SECTION_NOTE_DB, CHANGES.key(), SEQUENCE, false);
PrimaryStorage changePrimaryStorage =
cfg.getEnum(SECTION_NOTE_DB, CHANGES.key(), PRIMARY_STORAGE, PrimaryStorage.REVIEW_DB);
boolean disableChangeReviewDb =