opendev/gerrit
Code Issues Proposed changes

Use emptyList() in CommitValidationException constructors

Browse Source 
In the constructors that don't take a list of messages, use the
emptyList helper to create the empty list instead of creating
instances of ArrayList.

Change-Id: Ic6494241c179d8220a4cffe4305eb672ec913d5e
This commit is contained in:
David Pursehouse
2013-01-12 16:14:12 +09:00
parent c7abbfbbc1
commit 5443c40b69
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidationException.java
View File

@@ -14,7 +14,7 @@
package com.google.gerrit.server.git.validators; package com.google.gerrit.server.git.validators;
import java.util.ArrayList; import java.util.Collections;
import java.util.List; import java.util.List;
public class CommitValidationException extends Exception { public class CommitValidationException extends Exception {
@@ -28,12 +28,12 @@ public class CommitValidationException extends Exception {
public CommitValidationException(String reason) { public CommitValidationException(String reason) {
super(reason); super(reason);
this.messages = new ArrayList<CommitValidationMessage>(); this.messages = Collections.emptyList();
} }
public CommitValidationException(String reason, Throwable why) { public CommitValidationException(String reason, Throwable why) {
super(reason, why); super(reason, why);
this.messages = new ArrayList<CommitValidationMessage>(); this.messages = Collections.emptyList();
} }
public List<CommitValidationMessage> getMessages() { public List<CommitValidationMessage> getMessages() {