From 54880b5b5bf43dea00ea999c1c810ecc5a81523b Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Fri, 5 Nov 2010 15:50:20 -0700 Subject: [PATCH] Fix key bindings in patch views Martin broke key bindings in patch views in commit 34646869 when he enabled them too soon. The keys were inserted into the global map (thus binding them to the new widgets) before the widgets were actually put into the DOM and made the active display. Change-Id: Ia8a41003e6a6618ad03bb0395e3dc5e743400adc Signed-off-by: Shawn O. Pearce CC: Martin Fick --- .../main/java/com/google/gerrit/client/patches/PatchScreen.java | 1 - 1 file changed, 1 deletion(-) diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScreen.java index c947af81a5..812a74ee72 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/PatchScreen.java @@ -455,7 +455,6 @@ public abstract class PatchScreen extends Screen implements topNav.display(patchIndex, getPatchScreenType(), fileList); bottomNav.display(patchIndex, getPatchScreenType(), fileList); } - registerKeys(); // Mark this file reviewed as soon we display the diff screen if (Gerrit.isSignedIn() && isFirst) {