From 5495d9cc5b591866cbc9818b86b9b5b0cfced48d Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Thu, 2 Apr 2020 22:35:07 +0900 Subject: [PATCH] ElasticV{6,7}QueryChangesTest: Add comment about issue 10120 Add a comment to clarify that the index close operation is done to prevent issue 10120. Change-Id: Id8d5b4e922674404351ac9a5a7a281283485fdb1 --- .../google/gerrit/elasticsearch/ElasticV6QueryChangesTest.java | 2 ++ .../google/gerrit/elasticsearch/ElasticV7QueryChangesTest.java | 2 ++ 2 files changed, 4 insertions(+) diff --git a/javatests/com/google/gerrit/elasticsearch/ElasticV6QueryChangesTest.java b/javatests/com/google/gerrit/elasticsearch/ElasticV6QueryChangesTest.java index f1dcbaf63c..3f59d30573 100644 --- a/javatests/com/google/gerrit/elasticsearch/ElasticV6QueryChangesTest.java +++ b/javatests/com/google/gerrit/elasticsearch/ElasticV6QueryChangesTest.java @@ -57,6 +57,8 @@ public class ElasticV6QueryChangesTest extends AbstractQueryChangesTest { @After public void closeIndex() { + // Close the index after each test to prevent exceeding Elasticsearch's + // shard limit (see Issue 10120). client.execute( new HttpPost( String.format( diff --git a/javatests/com/google/gerrit/elasticsearch/ElasticV7QueryChangesTest.java b/javatests/com/google/gerrit/elasticsearch/ElasticV7QueryChangesTest.java index 704f2f1284..979a7f65dd 100644 --- a/javatests/com/google/gerrit/elasticsearch/ElasticV7QueryChangesTest.java +++ b/javatests/com/google/gerrit/elasticsearch/ElasticV7QueryChangesTest.java @@ -57,6 +57,8 @@ public class ElasticV7QueryChangesTest extends AbstractQueryChangesTest { @After public void closeIndex() { + // Close the index after each test to prevent exceeding Elasticsearch's + // shard limit (see Issue 10120). client.execute( new HttpPost( String.format(