opendev/gerrit
Code Issues Proposed changes

Log errors inside of ChangeEmail.getChangeDetail

Browse Source 
Change-Id: I0b92126feeedb54e2761d7e90734a51442b5d9bf
This commit is contained in:
Shawn O. Pearce
2012-04-26 14:45:35 -07:00
parent bbc9de5ac8
commit 54ccacdc69
1 changed files with 34 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java
View File

@@ -36,6 +36,9 @@ import com.google.gerrit.server.query.change.ChangeData;
import com.google.gerrit.server.query.change.ChangeQueryBuilder; import com.google.gerrit.server.query.change.ChangeQueryBuilder;
import com.google.gwtorm.server.OrmException; import com.google.gwtorm.server.OrmException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import java.text.MessageFormat; import java.text.MessageFormat;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Collections; import java.util.Collections;
@@ -47,6 +50,8 @@ import java.util.TreeSet;
/** Sends an email to one or more interested parties. */ /** Sends an email to one or more interested parties. */
public abstract class ChangeEmail extends OutgoingEmail { public abstract class ChangeEmail extends OutgoingEmail {
private static final Logger log = LoggerFactory.getLogger(ChangeEmail.class);
protected final Change change; protected final Change change;
protected PatchSet patchSet; protected PatchSet patchSet;
protected PatchSetInfo patchSetInfo; protected PatchSetInfo patchSetInfo;
@@ -224,6 +229,7 @@ public abstract class ChangeEmail extends OutgoingEmail {
/** Create the change message and the affected file list. */ /** Create the change message and the affected file list. */
public String getChangeDetail() { public String getChangeDetail() {
try {
StringBuilder detail = new StringBuilder(); StringBuilder detail = new StringBuilder();
if (patchSetInfo != null) { if (patchSetInfo != null) {
@@ -251,6 +257,10 @@ public abstract class ChangeEmail extends OutgoingEmail {
detail.append("\n"); detail.append("\n");
} }
return detail.toString(); return detail.toString();
} catch (Exception err) {
log.warn("Cannot format change detail", err);
return "";
}
} }