From 54db5be7b763f50b226d95fa54b725330d89e3a2 Mon Sep 17 00:00:00 2001 From: Dave Borowitz Date: Tue, 20 Jun 2017 11:13:52 -0400 Subject: [PATCH] NoteDbMigrator: Refuse to rebuild if NoteDb writes are disabled Change-Id: I867d3488a30687b4394b4dea9977b51e34d80e01 --- .../google/gerrit/server/notedb/rebuild/NoteDbMigrator.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/rebuild/NoteDbMigrator.java b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/rebuild/NoteDbMigrator.java index 15c72a30ab..8d43e0b5ad 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/notedb/rebuild/NoteDbMigrator.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/notedb/rebuild/NoteDbMigrator.java @@ -384,6 +384,9 @@ public class NoteDbMigrator implements AutoCloseable { } public void rebuild() throws MigrationException, OrmException { + checkState( + globalNotesMigration.commitChangeWrites(), + "cannot rebuild without noteDb.changes.write=true"); boolean ok; Stopwatch sw = Stopwatch.createStarted(); log.info("Rebuilding changes in NoteDb");