opendev/gerrit
Code Issues Proposed changes

Enable warnings for missing @Override annotations

Browse Source 
Somehow between turning this on and submitting I743917787 I managed to
turn this back off.

Suppress this warning in an instance where a new interface method was
added in Servlet API 3.0, as the code needs to continue to compile
against earlier versions. Unfortunately Eclipse does not give us a
more specific suppression token than "all", but in this case the
method body is small enough we're probably not missing anything.

Change-Id: I78ecf82f6cd4042417c9f3b1f6a4b473d29182d9
This commit is contained in:
Dave Borowitz
2014-10-30 11:43:01 -07:00
parent c51b5a7ba4
commit 54df81ff93
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.settings/org.eclipse.jdt.core.prefs
View File

@@ -33,7 +33,7 @@ org.eclipse.jdt.core.compiler.problem.missingDefaultCase=ignore
org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=ignore
org.eclipse.jdt.core.compiler.problem.missingEnumCaseDespiteDefault=disabled org.eclipse.jdt.core.compiler.problem.missingEnumCaseDespiteDefault=disabled
org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=ignore org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=ignore
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=warning
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled
org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning
org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore

2
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/AuditedHttpServletResponse.java
View File

@@ -28,7 +28,7 @@ class AuditedHttpServletResponse
super(response); super(response);
} }
@Override @SuppressWarnings("all") // @Override for servlet API 3.0+ only.
public int getStatus() { public int getStatus() {
return status; return status;
} }