Prevent 'no-score' approvals from being recorded
Unless the user has modified their score, don't include "No score" in the change message when its sent out. Bug: issue 396 Change-Id: I35c1ac351585858ec57988366fbfec060602c3ad
This commit is contained in:
committed by
Shawn O. Pearce
parent
6858e2d84f
commit
556b6d7999
@@ -189,6 +189,11 @@ public class PublishComments implements Callable<VoidResult> {
|
||||
for (final ApprovalType at : types.getApprovalTypes()) {
|
||||
if (dirty.contains(at.getCategory().getId())) {
|
||||
final PatchSetApproval a = mine.get(at.getCategory().getId());
|
||||
if (a.getValue() == 0 && ins.contains(a)) {
|
||||
// Don't say "no score" for an initial entry.
|
||||
continue;
|
||||
}
|
||||
|
||||
final ApprovalCategoryValue val = at.getValue(a);
|
||||
if (msgbuf.length() > 0) {
|
||||
msgbuf.append("; ");
|
||||
|
||||
Reference in New Issue
Block a user