opendev/gerrit
Code Issues Proposed changes

Refactor ChangeMessage to include PatchSet.Id

Browse Source 
Requires a PatchSet.Id to be included when instantiating ChangeMessage.
PatchSet.Id can be null if necessary, for instance in the
case of MergeOp messages.

Change-Id: I2d6d980d986f72a5aed2de6443632a47e6238215
This commit is contained in:
Jason Tsay
2011-07-26 00:12:39 -07:00
committed by Mohan Zhang
parent 6e9ad1edf0
commit 55709c6d76
5 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java
View File

@@ -226,7 +226,7 @@ public class ChangeUtil {
final ChangeMessage cmsg =
new ChangeMessage(new ChangeMessage.Key(changeId, ChangeUtil
.messageUUID(db)), user.getAccountId());
.messageUUID(db)), user.getAccountId(), patchSetId);
final StringBuilder msgBuf =
new StringBuilder("Patch Set " + patchSetId.get() + ": Abandoned");
if (message != null && message.length() > 0) {
@@ -337,7 +337,7 @@ public class ChangeUtil {
final ChangeMessage cmsg =
new ChangeMessage(new ChangeMessage.Key(changeId,
ChangeUtil.messageUUID(db)), user.getAccountId());
ChangeUtil.messageUUID(db)), user.getAccountId(), patchSetId);
final StringBuilder msgBuf =
new StringBuilder("Patch Set " + patchSetId.get() + ": Reverted");
msgBuf.append("\n\n");
@@ -373,7 +373,7 @@ public class ChangeUtil {
final ChangeMessage cmsg =
new ChangeMessage(new ChangeMessage.Key(changeId, ChangeUtil
.messageUUID(db)), user.getAccountId());
.messageUUID(db)), user.getAccountId(), patchSetId);
final StringBuilder msgBuf =
new StringBuilder("Patch Set " + patchSetId.get() + ": Restored");
if (message != null && message.length() > 0) {