opendev/gerrit
Code Issues Proposed changes

Merge "AccountGroup: Use Instant instead of long for default audit creation"

Browse Source
This commit is contained in:
David Pursehouse 2018-12-04 13:59:08 +00:00 committed by Gerrit Code Review
commit 557dbb0938
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
java/com/google/gerrit/reviewdb/client/AccountGroup.java
View File

@ -18,6 +18,7 @@ import com.google.gwtorm.client.Column;
import com.google.gwtorm.client.IntKey;
import com.google.gwtorm.client.StringKey;
import java.sql.Timestamp;
import java.time.Instant;
import java.util.Objects;
/** Named group of one or more accounts, typically used for access controls. */
@ -26,12 +27,10 @@ public final class AccountGroup {
* Time when the audit subsystem was implemented, used as the default value for {@link #createdOn}
* when one couldn't be determined from the audit log.
*/
// Can't use Instant here because GWT. This is verified against a readable time in the tests,
// which don't need to compile under GWT.
private static final long AUDIT_CREATION_INSTANT_MS = 1244489460000L;
private static final Instant AUDIT_CREATION_INSTANT_MS = Instant.ofEpochMilli(1244489460000L);
public static Timestamp auditCreationInstantTs() {
return new Timestamp(AUDIT_CREATION_INSTANT_MS);
return Timestamp.from(AUDIT_CREATION_INSTANT_MS);
}
/** Group name key */