opendev/gerrit
Code Issues Proposed changes

Remove ConfigUtil.groupsFor() methods.

Browse Source 
This method did not embrace guice and directly queried the database,
where GroupCache should have been used. Updated the calling code
accordingly.

Change-Id: I094c9ec8aa4fb2d23e61f9a717203c33ff785776
This commit is contained in:
Colby Ranger
2012-05-02 10:33:39 -07:00
parent f93b3eecec
commit 55a39e9b98
6 changed files with 46 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gerrit-server/src/main/java/com/google/gerrit/server/config/GitReceivePackGroupsProvider.java
View File

@@ -15,8 +15,7 @@
package com.google.gerrit.server.config;
import com.google.gerrit.reviewdb.client.AccountGroup;
import com.google.gerrit.reviewdb.server.ReviewDb;
import com.google.gwtorm.server.SchemaFactory;
import com.google.gerrit.server.account.GroupCache;
import com.google.inject.Inject;
import org.eclipse.jgit.lib.Config;
@@ -25,9 +24,9 @@ import java.util.Collections;
public class GitReceivePackGroupsProvider extends GroupSetProvider {
@Inject
public GitReceivePackGroupsProvider(@GerritServerConfig Config config,
SchemaFactory<ReviewDb> db) {
super(config, db, "receive", null, "allowGroup");
public GitReceivePackGroupsProvider(GroupCache gc,
@GerritServerConfig Config config) {
super(gc, config, "receive", null, "allowGroup");
// If no group was set, default to "registered users"
//