opendev/gerrit
Code Issues Proposed changes

Minor cleanup of routing middleware

Browse Source 
scrollToTop doesn't need to be specified on each route if it's already being
done on all routes.

Change-Id: I389c5adcf7eb065e4c45485b3a5b6247b6f4553f
This commit is contained in:
Andrew Bonventre 2015-11-24 17:28:34 -05:00
parent 573f8bad2d
commit 55abe6f115
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
polygerrit-ui/app/scripts/app.js
View File

@ -18,10 +18,10 @@
// See https://github.com/Polymer/polymer/issues/1381
window.addEventListener('WebComponentsReady', function() {
// Middleware
function scrollToTop(ctx, next) {
page(function(ctx, next) {
document.body.scrollTop = 0;
next();
}
});
// Routes.
page('/', function() {
@ -33,19 +33,19 @@
app.params = data.params;
}
page('/q/:query,:offset', scrollToTop, queryHandler);
page('/q/:query', scrollToTop, queryHandler);
page('/q/:query,:offset', queryHandler);
page('/q/:query', queryHandler);
page(/^\/(\d+)\/?/, scrollToTop, function(ctx) {
page(/^\/(\d+)\/?/, function(ctx) {
page.redirect('/c/' + ctx.params[0]);
});
page('/c/:changeNum', scrollToTop, function(data) {
page('/c/:changeNum', function(data) {
app.route = 'gr-change-view';
app.params = data.params;
});
page(/^\/c\/(\d+)\/((\d+)(\.\.(\d+))?)\/(.+)/, scrollToTop, function(ctx) {
page(/^\/c\/(\d+)\/((\d+)(\.\.(\d+))?)\/(.+)/, function(ctx) {
app.route = 'gr-diff-view';
var params = {
changeNum: ctx.params[0],