From 56f4a159a193cfabcd36e91fa082174ee400c866 Mon Sep 17 00:00:00 2001 From: Edwin Kempin Date: Fri, 5 Jan 2018 14:29:33 +0100 Subject: [PATCH] ExternalIdNotes: Make constructor and load() method private ExternalIdNotes should either be created by the factories or the static load methods. The constructor and the load() method were not private because ExternalIdsUpdate needed them, but now after ExternalIdsUpdate was removed we can make them private. Change-Id: I19c8b140e60d8685595d831724d14cac075a578d Signed-off-by: Edwin Kempin --- .../gerrit/server/account/externalids/ExternalIdNotes.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/java/com/google/gerrit/server/account/externalids/ExternalIdNotes.java b/java/com/google/gerrit/server/account/externalids/ExternalIdNotes.java index f663247e4c..8e69f2e7b2 100644 --- a/java/com/google/gerrit/server/account/externalids/ExternalIdNotes.java +++ b/java/com/google/gerrit/server/account/externalids/ExternalIdNotes.java @@ -171,7 +171,7 @@ public class ExternalIdNotes extends VersionedMetaData { private Runnable afterReadRevision; private boolean readOnly = false; - ExternalIdNotes( + private ExternalIdNotes( ExternalIdCache externalIdCache, @Nullable AccountCache accountCache, Repository allUsersRepo) { @@ -205,7 +205,7 @@ public class ExternalIdNotes extends VersionedMetaData { * * @return {@link ExternalIdNotes} instance for chaining */ - ExternalIdNotes load() throws IOException, ConfigInvalidException { + private ExternalIdNotes load() throws IOException, ConfigInvalidException { load(repo); return this; }