opendev/gerrit
Code Issues Proposed changes

Use __fake.?__ syntax for fake genrule outputs

Browse Source 
These genrules do not produce an output file, instead they are run
by the developer to obtain their side-effects like building other
targets they happen to depend on.

Make it more clear these are fake by naming them __fake.?__, a name
we should never see appear in buck-out/.

Change-Id: Id749b095a0b2990f8d9c7e3942215fc7463a5255
This commit is contained in:
Shawn Pearce 2013-05-10 10:56:10 -07:00
parent 4c7b444b6d
commit 57492bbaf6
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
BUCK
View File

@ -14,7 +14,7 @@ genrule(
':extension-api', ':extension-api',
':plugin-api', ':plugin-api',
], ],
out = '__api__', out = '__fake.api__',
) )
java_binary(name = 'extension-api', deps = [':extension-lib']) java_binary(name = 'extension-api', deps = [':extension-lib'])
@ -59,7 +59,7 @@ genrule(
':_eclipse_project', ':_eclipse_project',
':_eclipse_classpath', ':_eclipse_classpath',
], ],
out = 'eclipse', out = '__fake.eclipse__',
) )
genrule( genrule(
@ -70,7 +70,7 @@ genrule(
':_eclipse_project', ':_eclipse_project',
':_eclipse_classpath_nocompile', ':_eclipse_classpath_nocompile',
], ],
out = 'eclipse', out = '__fake.eclipse__',
) )
java_library( java_library(
@ -110,5 +110,5 @@ genrule(
cmd = '${//tools:eclipse_classpath}', cmd = '${//tools:eclipse_classpath}',
srcs = [], srcs = [],
deps = ['//tools:eclipse_classpath'], deps = ['//tools:eclipse_classpath'],
out = '_eclipse_classpath_nocompile', out = '__fake.eclipse__',
) )