opendev/gerrit
Code Issues Proposed changes

Cleanup post-test errors in gr-change-actions_test.html

Browse Source 
Running the tests for gr-change-actions would log hundreds of plugin
load timeout errors to the console. Because the errors would follow the
test completion and were asynchronously fired as part of initializing
the gr-change-actions element, they did not cause the tests to fail.
Stub the `awaitPluginsLoaded` method that was throwing the errors.

Change-Id: I980099ead6272e58269d62975122f8704bdc3e45
This commit is contained in:
Wyatt Allen 2018-05-29 16:46:41 -07:00
parent 60c5618a7a
commit 57907a152a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions_test.html
View File

@ -83,6 +83,9 @@ limitations under the License.
getProjectConfig() { return Promise.resolve({}); },
});
sandbox = sinon.sandbox.create();
sandbox.stub(Gerrit, 'awaitPluginsLoaded').returns(Promise.resolve());
element = fixture('basic');
element.change = {};
element.changeNum = '42';
@ -95,7 +98,6 @@ limitations under the License.
enabled: true,
},
};
sandbox = sinon.sandbox.create();
sandbox.stub(element.$.confirmCherrypick.$.restAPI,
'getRepoBranches').returns(Promise.resolve([]));
sandbox.stub(element.$.confirmMove.$.restAPI,