Remove _legacyUndefinedCheck from the shared modules

Change-Id: I456923a46b1d39707e02bf2bc6042f0bffad3aeb
2019-10-24 20:44:31 +00:00
parent 6c69c8dbce
commit 57bac94043
48 changed files with 2 additions and 48 deletions
--- a/polygerrit-ui/app/elements/shared/gr-account-chip/gr-account-chip.js
+++ b/polygerrit-ui/app/elements/shared/gr-account-chip/gr-account-chip.js
@@ -20,7 +20,6 @@

  Polymer({
    is: 'gr-account-chip',
-    _legacyUndefinedCheck: true,

    /**
     * Fired to indicate a key was pressed while this chip was focused.
--- a/polygerrit-ui/app/elements/shared/gr-account-entry/gr-account-entry.js
+++ b/polygerrit-ui/app/elements/shared/gr-account-entry/gr-account-entry.js
@@ -23,7 +23,6 @@
   */
  Polymer({
    is: 'gr-account-entry',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when an account is entered.
--- a/polygerrit-ui/app/elements/shared/gr-account-label/gr-account-label.js
+++ b/polygerrit-ui/app/elements/shared/gr-account-label/gr-account-label.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-account-label',
-    _legacyUndefinedCheck: true,

    properties: {
      /**
--- a/polygerrit-ui/app/elements/shared/gr-account-link/gr-account-link.js
+++ b/polygerrit-ui/app/elements/shared/gr-account-link/gr-account-link.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-account-link',
-    _legacyUndefinedCheck: true,

    properties: {
      additionalText: String,
--- a/polygerrit-ui/app/elements/shared/gr-account-list/gr-account-list.js
+++ b/polygerrit-ui/app/elements/shared/gr-account-list/gr-account-list.js
@@ -39,7 +39,6 @@

  Polymer({
    is: 'gr-account-list',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when user inputs an invalid email address.
--- a/polygerrit-ui/app/elements/shared/gr-alert/gr-alert.js
+++ b/polygerrit-ui/app/elements/shared/gr-alert/gr-alert.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-alert',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when the action button is pressed.
--- a/polygerrit-ui/app/elements/shared/gr-autocomplete-dropdown/gr-autocomplete-dropdown.js
+++ b/polygerrit-ui/app/elements/shared/gr-autocomplete-dropdown/gr-autocomplete-dropdown.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-autocomplete-dropdown',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when the dropdown is closed.
--- a/polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete.js
+++ b/polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete.js
@@ -22,7 +22,6 @@

  Polymer({
    is: 'gr-autocomplete',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when a value is chosen.
--- a/polygerrit-ui/app/elements/shared/gr-avatar/gr-avatar.js
+++ b/polygerrit-ui/app/elements/shared/gr-avatar/gr-avatar.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-avatar',
-    _legacyUndefinedCheck: true,

    properties: {
      account: {
--- a/polygerrit-ui/app/elements/shared/gr-button/gr-button.js
+++ b/polygerrit-ui/app/elements/shared/gr-button/gr-button.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-button',
-    _legacyUndefinedCheck: true,

    properties: {
      tooltip: String,
--- a/polygerrit-ui/app/elements/shared/gr-change-star/gr-change-star.js
+++ b/polygerrit-ui/app/elements/shared/gr-change-star/gr-change-star.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-change-star',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when star state is toggled.
--- a/polygerrit-ui/app/elements/shared/gr-change-status/gr-change-status.js
+++ b/polygerrit-ui/app/elements/shared/gr-change-status/gr-change-status.js
@@ -34,7 +34,6 @@

  Polymer({
    is: 'gr-change-status',
-    _legacyUndefinedCheck: true,

    properties: {
      flat: {
--- a/polygerrit-ui/app/elements/shared/gr-comment-thread/gr-comment-thread.js
+++ b/polygerrit-ui/app/elements/shared/gr-comment-thread/gr-comment-thread.js
@@ -22,7 +22,6 @@

  Polymer({
    is: 'gr-comment-thread',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when the thread should be discarded.
--- a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js
+++ b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js
@@ -33,7 +33,6 @@

  Polymer({
    is: 'gr-comment',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when the create fix comment action is triggered.
--- a/polygerrit-ui/app/elements/shared/gr-confirm-delete-comment-dialog/gr-confirm-delete-comment-dialog.js
+++ b/polygerrit-ui/app/elements/shared/gr-confirm-delete-comment-dialog/gr-confirm-delete-comment-dialog.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-confirm-delete-comment-dialog',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when the confirm button is pressed.
--- a/polygerrit-ui/app/elements/shared/gr-copy-clipboard/gr-copy-clipboard.js
+++ b/polygerrit-ui/app/elements/shared/gr-copy-clipboard/gr-copy-clipboard.js
@@ -21,7 +21,6 @@

  Polymer({
    is: 'gr-copy-clipboard',
-    _legacyUndefinedCheck: true,

    properties: {
      text: String,
--- a/polygerrit-ui/app/elements/shared/gr-cursor-manager/gr-cursor-manager.js
+++ b/polygerrit-ui/app/elements/shared/gr-cursor-manager/gr-cursor-manager.js
@@ -24,7 +24,6 @@

  Polymer({
    is: 'gr-cursor-manager',
-    _legacyUndefinedCheck: true,

    properties: {
      stops: {
--- a/polygerrit-ui/app/elements/shared/gr-date-formatter/gr-date-formatter.js
+++ b/polygerrit-ui/app/elements/shared/gr-date-formatter/gr-date-formatter.js
@@ -33,7 +33,6 @@

  Polymer({
    is: 'gr-date-formatter',
-    _legacyUndefinedCheck: true,

    properties: {
      dateStr: {
--- a/polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog.js
+++ b/polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-dialog',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when the confirm button is pressed.
--- a/polygerrit-ui/app/elements/shared/gr-diff-preferences/gr-diff-preferences.js
+++ b/polygerrit-ui/app/elements/shared/gr-diff-preferences/gr-diff-preferences.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-diff-preferences',
-    _legacyUndefinedCheck: true,

    properties: {
      hasUnsavedChanges: {
--- a/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands.js
+++ b/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands.js
@@ -19,7 +19,7 @@

  Polymer({
    is: 'gr-download-commands',
-    _legacyUndefinedCheck: true,
+
    properties: {
      commands: Array,
      _loggedIn: {
--- a/polygerrit-ui/app/elements/shared/gr-dropdown-list/gr-dropdown-list.js
+++ b/polygerrit-ui/app/elements/shared/gr-dropdown-list/gr-dropdown-list.js
@@ -47,7 +47,6 @@

  Polymer({
    is: 'gr-dropdown-list',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when the selected value changes
--- a/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js
+++ b/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js
@@ -22,7 +22,6 @@

  Polymer({
    is: 'gr-dropdown',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when a non-link dropdown item with the given ID is tapped.
--- a/polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.js
+++ b/polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.js
@@ -22,7 +22,6 @@

  Polymer({
    is: 'gr-editable-content',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when the save button is pressed.
--- a/polygerrit-ui/app/elements/shared/gr-editable-label/gr-editable-label.js
+++ b/polygerrit-ui/app/elements/shared/gr-editable-label/gr-editable-label.js
@@ -22,7 +22,6 @@

  Polymer({
    is: 'gr-editable-label',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when the value is changed.
--- a/polygerrit-ui/app/elements/shared/gr-fixed-panel/gr-fixed-panel.js
+++ b/polygerrit-ui/app/elements/shared/gr-fixed-panel/gr-fixed-panel.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-fixed-panel',
-    _legacyUndefinedCheck: true,

    properties: {
      floatingDisabled: Boolean,
--- a/polygerrit-ui/app/elements/shared/gr-formatted-text/gr-formatted-text.js
+++ b/polygerrit-ui/app/elements/shared/gr-formatted-text/gr-formatted-text.js
@@ -22,7 +22,6 @@

  Polymer({
    is: 'gr-formatted-text',
-    _legacyUndefinedCheck: true,

    properties: {
      content: {
--- a/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard.js
+++ b/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard.js
@@ -27,7 +27,6 @@

  Polymer({
    is: 'gr-hovercard',
-    _legacyUndefinedCheck: true,

    properties: {
      /**
--- a/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-js-api-interface.js
+++ b/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-js-api-interface.js
@@ -38,7 +38,6 @@

  Polymer({
    is: 'gr-js-api-interface',
-    _legacyUndefinedCheck: true,

    properties: {
      _elements: {
--- a/polygerrit-ui/app/elements/shared/gr-label-info/gr-label-info.js
+++ b/polygerrit-ui/app/elements/shared/gr-label-info/gr-label-info.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-label-info',
-    _legacyUndefinedCheck: true,

    properties: {
      labelInfo: Object,
--- a/polygerrit-ui/app/elements/shared/gr-label/gr-label.js
+++ b/polygerrit-ui/app/elements/shared/gr-label/gr-label.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-label',
-    _legacyUndefinedCheck: true,

    behaviors: [
      Gerrit.TooltipBehavior,
--- a/polygerrit-ui/app/elements/shared/gr-labeled-autocomplete/gr-labeled-autocomplete.js
+++ b/polygerrit-ui/app/elements/shared/gr-labeled-autocomplete/gr-labeled-autocomplete.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-labeled-autocomplete',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when a value is chosen.
--- a/polygerrit-ui/app/elements/shared/gr-lib-loader/gr-lib-loader.js
+++ b/polygerrit-ui/app/elements/shared/gr-lib-loader/gr-lib-loader.js
@@ -22,7 +22,6 @@

  Polymer({
    is: 'gr-lib-loader',
-    _legacyUndefinedCheck: true,

    properties: {
      _hljsState: {
--- a/polygerrit-ui/app/elements/shared/gr-limited-text/gr-limited-text.js
+++ b/polygerrit-ui/app/elements/shared/gr-limited-text/gr-limited-text.js
@@ -26,7 +26,6 @@

  Polymer({
    is: 'gr-limited-text',
-    _legacyUndefinedCheck: true,

    properties: {
      /** The un-truncated text to display. */
--- a/polygerrit-ui/app/elements/shared/gr-linked-chip/gr-linked-chip.js
+++ b/polygerrit-ui/app/elements/shared/gr-linked-chip/gr-linked-chip.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-linked-chip',
-    _legacyUndefinedCheck: true,

    properties: {
      href: String,
--- a/polygerrit-ui/app/elements/shared/gr-linked-text/gr-linked-text.js
+++ b/polygerrit-ui/app/elements/shared/gr-linked-text/gr-linked-text.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-linked-text',
-    _legacyUndefinedCheck: true,

    properties: {
      removeZeroWidthSpace: Boolean,
--- a/polygerrit-ui/app/elements/shared/gr-list-view/gr-list-view.js
+++ b/polygerrit-ui/app/elements/shared/gr-list-view/gr-list-view.js
@@ -21,7 +21,6 @@

  Polymer({
    is: 'gr-list-view',
-    _legacyUndefinedCheck: true,

    properties: {
      createNew: Boolean,
--- a/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js
+++ b/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js
@@ -23,7 +23,6 @@

  Polymer({
    is: 'gr-overlay',
-    _legacyUndefinedCheck: true,

    /**
     * Fired when a fullscreen overlay is closed
--- a/polygerrit-ui/app/elements/shared/gr-page-nav/gr-page-nav.js
+++ b/polygerrit-ui/app/elements/shared/gr-page-nav/gr-page-nav.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-page-nav',
-    _legacyUndefinedCheck: true,

    properties: {
      _headerHeight: Number,
--- a/polygerrit-ui/app/elements/shared/gr-repo-branch-picker/gr-repo-branch-picker.js
+++ b/polygerrit-ui/app/elements/shared/gr-repo-branch-picker/gr-repo-branch-picker.js
@@ -22,7 +22,6 @@

  Polymer({
    is: 'gr-repo-branch-picker',
-    _legacyUndefinedCheck: true,

    properties: {
      repo: {
--- a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js
+++ b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js
@@ -109,7 +109,6 @@

  Polymer({
    is: 'gr-rest-api-interface',
-    _legacyUndefinedCheck: true,

    behaviors: [
      Gerrit.FireBehavior,
--- a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/mock-diff-response_test.html
+++ b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/mock-diff-response_test.html
@@ -153,7 +153,7 @@ limitations under the License.

      Polymer({
        is: 'mock-diff-response',
-        _legacyUndefinedCheck: true,
+
        properties: {
          diffResponse: {
            type: Object,
--- a/polygerrit-ui/app/elements/shared/gr-select/gr-select.js
+++ b/polygerrit-ui/app/elements/shared/gr-select/gr-select.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-select',
-    _legacyUndefinedCheck: true,

    properties: {
      bindValue: {
--- a/polygerrit-ui/app/elements/shared/gr-shell-command/gr-shell-command.js
+++ b/polygerrit-ui/app/elements/shared/gr-shell-command/gr-shell-command.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-shell-command',
-    _legacyUndefinedCheck: true,

    properties: {
      command: String,
--- a/polygerrit-ui/app/elements/shared/gr-storage/gr-storage.js
+++ b/polygerrit-ui/app/elements/shared/gr-storage/gr-storage.js
@@ -30,7 +30,6 @@

  Polymer({
    is: 'gr-storage',
-    _legacyUndefinedCheck: true,

    properties: {
      _lastCleanup: Number,
--- a/polygerrit-ui/app/elements/shared/gr-textarea/gr-textarea.js
+++ b/polygerrit-ui/app/elements/shared/gr-textarea/gr-textarea.js
@@ -54,7 +54,6 @@

  Polymer({
    is: 'gr-textarea',
-    _legacyUndefinedCheck: true,

    /**
     * @event bind-value-changed
--- a/polygerrit-ui/app/elements/shared/gr-tooltip-content/gr-tooltip-content.js
+++ b/polygerrit-ui/app/elements/shared/gr-tooltip-content/gr-tooltip-content.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-tooltip-content',
-    _legacyUndefinedCheck: true,

    properties: {
      title: {
--- a/polygerrit-ui/app/elements/shared/gr-tooltip/gr-tooltip.js
+++ b/polygerrit-ui/app/elements/shared/gr-tooltip/gr-tooltip.js
@@ -19,7 +19,6 @@

  Polymer({
    is: 'gr-tooltip',
-    _legacyUndefinedCheck: true,

    properties: {
      text: String,