diff --git a/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row.js b/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row.js index 0682ab2372..f472331025 100644 --- a/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row.js +++ b/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row.js @@ -69,7 +69,8 @@ }, _computeBlankItems(permittedLabels, label, side) { - if (!permittedLabels || !permittedLabels[label] || !this.labelValues || + if (!permittedLabels || !permittedLabels[label] || + !permittedLabels[label].length || !this.labelValues || !Object.keys(this.labelValues).length) { return []; } @@ -135,7 +136,8 @@ }, _computeAnyPermittedLabelValues(permittedLabels, label) { - return permittedLabels.hasOwnProperty(label); + return permittedLabels.hasOwnProperty(label) && + permittedLabels[label].length; }, _computeHiddenClass(permittedLabels, label) { diff --git a/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row_test.html b/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row_test.html index e5431f681a..1e4d471a5f 100644 --- a/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row_test.html +++ b/polygerrit-ui/app/elements/change/gr-label-score-row/gr-label-score-row_test.html @@ -258,6 +258,11 @@ limitations under the License. flushAsynchronousOperations(); assert.isOk(element.$$('iron-selector')); assert.isTrue(element.$$('iron-selector').hidden); + + element.permittedLabels = {Verified: []}; + flushAsynchronousOperations(); + assert.isOk(element.$$('iron-selector')); + assert.isTrue(element.$$('iron-selector').hidden); }); test('asymetrical labels', () => {