opendev/gerrit
Code Issues Proposed changes

Describe some GerritPermissions more accurately

Browse Source 
Using a lowercase version of the enum value works well in many cases,
but not quite all of them.

Change-Id: I64db2ac1260bcbb0e758ec94e63a8cff5fa3aed3
This commit is contained in:
Dave Borowitz
2018-04-11 21:58:11 +02:00
parent 7a5156acfd
commit 584c7b7c0e
8 changed files with 79 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/com/google/gerrit/server/permissions/GlobalPermission.java
View File

@@ -20,6 +20,7 @@ import com.google.gerrit.common.Nullable;
import com.google.gerrit.extensions.annotations.CapabilityScope;
import com.google.gerrit.extensions.annotations.RequiresAnyCapability;
import com.google.gerrit.extensions.annotations.RequiresCapability;
import com.google.gerrit.extensions.api.access.GerritPermission;
import com.google.gerrit.extensions.api.access.GlobalOrPluginPermission;
import com.google.gerrit.extensions.api.access.PluginPermission;
import java.lang.annotation.Annotation;
@@ -148,4 +149,9 @@ public enum GlobalPermission implements GlobalOrPluginPermission {
}
return null;
}
@Override
public String describeForException() {
return GerritPermission.describeEnumValue(this);
}
}