opendev
/
gerrit
Code Issues Proposed changes

Add ow2-asm dependencies for GWT plugins 

In GWT 2.7 asm isn't shipped any more in gwt-dev JAR. In Ib8f9ed0c7 asm
dependency was added as transitive dependency to gwt_binary() rule
invocation. Unfortunately the gerrit plugin code path was missed, thus
the plugins that make use of GWT module cannot be compiled any more.

This bug wasn't noticed, because no core plugins make use of GWT
modules.

Change-Id: Id388caf119887263863c4829c7ada4e1fa94eb85
This commit is contained in:
David Ostrovsky 2014-12-18 22:28:27 +09:00 committed by David Pursehouse
parent 50edc24972
commit 5862341e54
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-gwtui/BUCK
View File

@ -2,13 +2,9 @@ include_defs('//gerrit-gwtui/gwt.defs')
include_defs('//tools/gwt-constants.defs')
from multiprocessing import cpu_count
DEPS = [
DEPS = GWT_COMMON_DEPS + [
'//gerrit-gwtexpui:CSS',
'//lib:gwtjsonrpc',
'//lib/ow2:ow2-asm',
'//lib/ow2:ow2-asm-analysis',
'//lib/ow2:ow2-asm-util',
'//lib/ow2:ow2-asm-tree',
]
genrule(

9
tools/gwt-constants.defs
View File

@ -5,7 +5,14 @@ GWT_COMPILER_ARGS = [
'-XdisableCastChecking',
]
GWT_PLUGIN_DEPS = [
GWT_COMMON_DEPS = [
'//lib/ow2:ow2-asm',
'//lib/ow2:ow2-asm-analysis',
'//lib/ow2:ow2-asm-util',
'//lib/ow2:ow2-asm-tree',
]
GWT_PLUGIN_DEPS = GWT_COMMON_DEPS + [
'//gerrit-plugin-gwtui:gwtui-api-lib',
'//lib/gwt:user',
]