opendev/gerrit
Code Issues Proposed changes

Fix compiler warnings about missing switch cases for PatchLine.Type

Browse Source 
Add explicit case statements for all enumeration values to
prevent compiler warnings.

Change-Id: Ia7d31b9d2559f564eee6b6692fd224a683089831
This commit is contained in:
David Pursehouse
2012-12-05 15:45:27 +09:00
parent 77516310a6
commit 590d0423a5
3 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/AbstractPatchContentTable.java
View File

@@ -295,6 +295,8 @@ public abstract class AbstractPatchContentTable extends NavigationTable<Object>
case INSERT:
case REPLACE:
return true;
case CONTEXT:
break;
}
} else if (o instanceof CommentList) {
return true;

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/SideBySideTable.java
View File

@@ -593,6 +593,8 @@ public class SideBySideTable extends AbstractPatchContentTable {
m.addStyleName("wdi");
}
break;
case REPLACE:
break;
}
m.append(lineHtml);
m.closeTd();

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/UnifiedDiffTable.java
View File

@@ -70,6 +70,8 @@ public class UnifiedDiffTable extends AbstractPatchContentTable {
case INSERT:
createCommentEditor(row + 1, PC, pl.getLineB(), (short) 1);
break;
case REPLACE:
break;
}
}
}
@@ -159,6 +161,8 @@ public class UnifiedDiffTable extends AbstractPatchContentTable {
case INSERT:
createCommentEditor(row + 1, PC, pl.getLineB(), (short) 1);
break;
case REPLACE:
break;
}
}
@@ -537,6 +541,8 @@ public class UnifiedDiffTable extends AbstractPatchContentTable {
m.append("+");
m.append(text);
break;
case REPLACE:
break;
}
m.closeTd();
}