opendev/gerrit
Code Issues Proposed changes

Merge "Suppress Eclipse warnings about not closed resources"

Browse Source
This commit is contained in:
Shawn Pearce
2013-07-11 22:38:04 +00:00
committed by Gerrit Code Review
parent 7153095d99 9d46fd6ca1
commit 595d6f65f5
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/InitPluginStepsLoader.java
View File

@@ -64,9 +64,11 @@ public class InitPluginStepsLoader {
private InitStep loadInitStep(File jar) { private InitStep loadInitStep(File jar) {
try { try {
@SuppressWarnings("resource")
ClassLoader pluginLoader = ClassLoader pluginLoader =
new URLClassLoader(new URL[] {jar.toURI().toURL()}, new URLClassLoader(new URL[] {jar.toURI().toURL()},
InitPluginStepsLoader.class.getClassLoader()); InitPluginStepsLoader.class.getClassLoader());
@SuppressWarnings("resource")
JarFile jarFile = new JarFile(jar); JarFile jarFile = new JarFile(jar);
Attributes jarFileAttributes = jarFile.getManifest().getMainAttributes(); Attributes jarFileAttributes = jarFile.getManifest().getMainAttributes();
String initClassName = jarFileAttributes.getValue("Gerrit-InitStep"); String initClassName = jarFileAttributes.getValue("Gerrit-InitStep");

1
gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/IoUtil.java
View File

@@ -57,6 +57,7 @@ public final class IoUtil {
if (!(cl instanceof URLClassLoader)) { if (!(cl instanceof URLClassLoader)) {
throw noAddURL("Not loaded by URLClassLoader", null); throw noAddURL("Not loaded by URLClassLoader", null);
} }
@SuppressWarnings("resource")
URLClassLoader urlClassLoader = (URLClassLoader) cl; URLClassLoader urlClassLoader = (URLClassLoader) cl;
Method addURL; Method addURL;