opendev/gerrit
Code Issues Proposed changes

Correctly hide delete button on inherited permissions

Browse Source 
When we added per-branch access controls I accidentally removed this
filter to prevent the delete checkbox from showing up on rows which
are inherited from the magical -- All Projects --.  Put it back.

Change-Id: I32f7365af70380bc6d9c22ddf1038c4151340c5a
Signed-off-by: Shawn O. Pearce <sop@google.com>
Reviewed-by: Nico Sallembien <nsallembien@google.com>
This commit is contained in:
Shawn O. Pearce
2010-01-27 15:53:07 -08:00
parent 75542f1bc3
commit 5aa47fee31
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectRightsPanel.java
View File

@@ -408,7 +408,11 @@ public class ProjectRightsPanel extends Composite {
config.getApprovalTypes().getApprovalType(r.getApprovalCategoryId());
final AccountGroup group = groups.get(r.getAccountGroupId());
table.setWidget(row, 1, new CheckBox());
if (Gerrit.getConfig().getWildProject().equals(r.getProjectNameKey())) {
table.setText(row, 1, "");
} else {
table.setWidget(row, 1, new CheckBox());
}
if (ar != null) {
table.setText(row, 2, ar.getCategory().getName());