Allow to propose changes to access rights through code review
Users that are able to upload changes for code review for the refs/meta/config branch can now propose changes to the project access rights through code review directly from the ProjectAccessScreen. When editing the project access rights there will be a new button 'Save for Review' which will create a new change for the access rights modifications. Project owners are automatically added as reviewer to this change. If a project owner agrees to the access rights modifications he can simply approve and submit the change. Change-Id: Ica40ce3f57726bdb897e01783cc6da10f1d392cc Signed-off-by: Edwin Kempin <edwin.kempin@sap.com> Signed-off-by: Sasa Zivkov <sasa.zivkov@sap.com> Signed-off-by: Gustaf Lundh <gustaf.lundh@sonymobile.com> Signed-off-by: Ulrik Sjölin <ulrik.sjolin@sonyericsson.com>
This commit is contained in:
@@ -137,9 +137,7 @@ final class AdminSetParent extends SshCommand {
|
||||
config.getProject().setParentName(newParentKey);
|
||||
md.setMessage("Inherit access from "
|
||||
+ (newParentKey != null ? newParentKey.get() : allProjectsName.get()) + "\n");
|
||||
if (!config.commit(md)) {
|
||||
err.append("error: Could not update project " + name + "\n");
|
||||
}
|
||||
config.commit(md);
|
||||
} finally {
|
||||
md.close();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user