opendev/gerrit
Code Issues Proposed changes

ChangeNotes: Remove project arg from constructors

Browse Source 
We always pass a Change to the constructor, so this argument is not
necessary. It was originally so we could pass (project, ID) to the
constructor, but we don't do that currently, so until then it's
unnecessary.

Change-Id: I59d6632c28523bd2f405486899215e2f9ebfa685
This commit is contained in:
Dave Borowitz
2016-05-10 08:33:28 -07:00
parent 66b972fdeb
commit 5ad116e32d
3 changed files with 15 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/test/java/com/google/gerrit/server/notedb/AbstractChangeNotesTest.java
View File

@@ -211,7 +211,7 @@ public abstract class AbstractChangeNotesTest extends GerritBaseTests {
}
protected ChangeNotes newNotes(Change c) throws OrmException {
return new ChangeNotes(args, c.getProject(), c).load();
return new ChangeNotes(args, c).load();
}
protected static SubmitRecord submitRecord(String status,

2
gerrit-server/src/test/java/com/google/gerrit/testutil/TestChanges.java
View File

@@ -139,7 +139,7 @@ public class TestChanges {
expect(ctl.getChange()).andStubReturn(c);
expect(ctl.getProject()).andStubReturn(new Project(c.getProject()));
expect(ctl.getUser()).andStubReturn(user);
ChangeNotes notes = new ChangeNotes(args, c.getProject(), c).load();
ChangeNotes notes = new ChangeNotes(args, c).load();
expect(ctl.getNotes()).andStubReturn(notes);
expect(ctl.getId()).andStubReturn(c.getId());
EasyMock.replay(ctl);