opendev/gerrit
Code Issues Proposed changes

Set copyAllScoresIfNoCodeChange for Verified by default

Browse Source 
For the Verified label most users expect that the scores are copied if
there was no code change, hence this should be the default.

Change-Id: If625b6ef193d935ee7d409973cb12618d634d4e8
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This commit is contained in:
Edwin Kempin 2015-04-28 10:48:06 +02:00
parent 09f7f7b5d8
commit 5ae4ff4841
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Documentation/config-labels.txt
View File

@ -255,7 +255,8 @@ set and the same code delta as the previous patch set. This means only
the commit message is different. This can be used to enable sticky
approvals on labels that only depend on the code, reducing turn-around
if only the commit message is changed prior to submitting a change.
It is recommended to enable this for the Verified label if enabled.
For the Verified label that is installed by the link:pgm-init.html[init]
site program this is enabled by default.
Defaults to false.
[[label_copyAllScoresIfNoChange]]

3
gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/InitLabels.java
View File

@ -26,6 +26,8 @@ import java.util.Arrays;
@Singleton
public class InitLabels implements InitStep {
private static final String KEY_COPY_ALL_SCORES_IF_NO_CODE_CHANGE =
"copyAllScoresIfNoCodeChange";
private static final String KEY_LABEL = "label";
private static final String KEY_FUNCTION = "function";
private static final String KEY_VALUE = "value";
@ -58,6 +60,7 @@ public class InitLabels implements InitStep {
cfg.setString(KEY_LABEL, LABEL_VERIFIED, KEY_FUNCTION, "MaxWithBlock");
cfg.setStringList(KEY_LABEL, LABEL_VERIFIED, KEY_VALUE,
Arrays.asList(new String[] {"-1 Fails", " 0 No score", "+1 Verified"}));
cfg.setBoolean(KEY_LABEL, LABEL_VERIFIED, KEY_COPY_ALL_SCORES_IF_NO_CODE_CHANGE, true);
allProjectsConfig.save("Configure 'Verified' label");
}
}