Revert "Display the approval table on the Publish Comments screen."

This reverts commit 3fc98f99b4.
The display was buggy and listed users as "Anonymous Coward"
even though they had a Full Name supplied in the Account. I
don't have time to debug this myself, but users are unhappy
the table is confusing/useless with everyone being called
an Anonymous Coward so the change goes out.

Bug: issue 1383
CC: Joe Hansche <jhansche@myyearbook.com>
Change-Id: Ibe9f70bc001df4b3a04ee2eb4dfa194f75e5b3f0
This commit is contained in:
Shawn O. Pearce
2012-06-18 14:20:28 -07:00
parent 174a012288
commit 5b16d0f096
5 changed files with 12 additions and 111 deletions

View File

@@ -20,9 +20,6 @@ import com.google.gerrit.reviewdb.client.PatchLineComment;
import com.google.gerrit.reviewdb.client.PatchSetApproval;
import com.google.gerrit.reviewdb.client.PatchSetInfo;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.List;
public class PatchSetPublishDetail {
@@ -31,8 +28,6 @@ public class PatchSetPublishDetail {
protected Change change;
protected List<PatchLineComment> drafts;
protected List<PermissionRange> labels;
protected List<ApprovalDetail> approvals;
protected List<SubmitRecord> submitRecords;
protected List<PatchSetApproval> given;
protected boolean canSubmit;
@@ -44,23 +39,6 @@ public class PatchSetPublishDetail {
this.labels = labels;
}
public List<ApprovalDetail> getApprovals() {
return approvals;
}
public void setApprovals(Collection<ApprovalDetail> list) {
approvals = new ArrayList<ApprovalDetail>(list);
Collections.sort(approvals, ApprovalDetail.SORT);
}
public void setSubmitRecords(List<SubmitRecord> all) {
submitRecords = all;
}
public List<SubmitRecord> getSubmitRecords() {
return submitRecords;
}
public List<PatchSetApproval> getGiven() {
return given;
}