opendev/gerrit
Code Issues Proposed changes

Remove everywhere on-tap

Browse Source 
Recommended by polymer team to remove legacy on tap for on click.
On click has better performance and is well supported by browsers.

Change-Id: I30a03ae9c7f721d561b11784d07fb186a9fa0407
This commit is contained in:
Milutin Kristofic
2019-10-28 15:40:44 +01:00
parent b0ae5468d1
commit 5b1b46f56a
29 changed files with 72 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/behaviors/gr-tooltip-behavior/gr-tooltip-behavior.js
View File

@@ -89,7 +89,7 @@
this._tooltip = tooltip;
this.listen(window, 'scroll', '_handleWindowScroll');
this.listen(this, 'mouseleave', '_handleHideTooltip');
this.listen(this, 'tap', '_handleHideTooltip');
this.listen(this, 'click', '_handleHideTooltip');
},
_handleHideTooltip(e) {
@@ -101,7 +101,7 @@
this.unlisten(window, 'scroll', '_handleWindowScroll');
this.unlisten(this, 'mouseleave', '_handleHideTooltip');
this.unlisten(this, 'tap', '_handleHideTooltip');
this.unlisten(this, 'click', '_handleHideTooltip');
this.setAttribute('title', this._titleText);
if (this._tooltip && this._tooltip.parentNode) {
this._tooltip.parentNode.removeChild(this._tooltip);