opendev/gerrit
Code Issues Proposed changes

Merge "CopyableLabel: Avoid creating Flash movie for empty string"

Browse Source
This commit is contained in:
Edwin Kempin 2013-08-22 08:57:47 +00:00 committed by Gerrit Code Review
commit 5b89426048
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/clippy/client/CopyableLabel.java
View File

@ -130,7 +130,7 @@ public class CopyableLabel extends Composite implements HasText {
}
private void embedMovie() {
if (flashEnabled && UserAgent.hasFlash) {
if (flashEnabled && UserAgent.hasFlash && text.length() > 0) {
final String flashVars = "text=" + URL.encodeQueryString(getText());
final SafeHtmlBuilder h = new SafeHtmlBuilder();