opendev/gerrit
Code Issues Proposed changes

Flip order of _value testing recommended and disliked

Browse Source 
ChangeTable2 tests disliked, and then recommended. If both scores are
supplied by two different users, favor the disliked negative score
over the positive recommended score, matching ChangeTable2's own order
and thus avoid a weird case of a red "1" value with no leading +/- value.

Change-Id: Ic2ddac77ff57e4db2490ad6b7c8b6a16c1c90b43
This commit is contained in:
Shawn O. Pearce
2012-05-07 16:03:40 -07:00
parent 1084cb299d
commit 5c9fd14216
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfo.java
View File

@@ -95,8 +95,8 @@ public class ChangeInfo extends JavaScriptObject {
final native short _value()
/*-{
if (this.value) return this.value;
if (this.recommended) return 1;
if (this.disliked) return -1;
if (this.recommended) return 1;
return 0;
}-*/;