opendev/gerrit
Code Issues Proposed changes

canReadCommit: swap preconditions check to improve performance

Browse Source 
It is much cheaper to check READ access on a ref than to check
if a commit is merged into that ref. Therefore, do the checks in
this order and avoid traversal of potentially large commit graph
when we know that the user cannot read that branch.

Change-Id: I008990915e15854100a84b3d795f6c54efe35c81
This commit is contained in:
Sasa Zivkov 2013-11-14 15:22:32 +01:00
parent 16da16af68
commit 5cf89bc928
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java
View File

@ -506,8 +506,8 @@ public class ProjectControl {
} catch (IncorrectObjectTypeException e) {
continue;
}
if (rw.isMergedInto(commit, tip)
&& controlForRef(entry.getKey()).canPerform(Permission.READ)) {
if (controlForRef(entry.getKey()).canPerform(Permission.READ)
&& rw.isMergedInto(commit, tip)) {
return true;
}
}