opendev/gerrit
Code Issues Proposed changes

H2CacheImpl: Only log when pruning a nonzero number of entries

Browse Source 
Otherwise this is yet more log noise at startup.

Change-Id: I9f0f3057c00351b48c97aa903c8eea8ae2965656
This commit is contained in:
Dave Borowitz 2018-07-31 14:57:43 -07:00
parent 39e55225b8
commit 5d094c10fc
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
java/com/google/gerrit/server/cache/h2/H2CacheImpl.java vendored
View File

@ -532,8 +532,11 @@ public class H2CacheImpl<K, V> extends AbstractLoadingCache<K, V> implements Per
try (PreparedStatement ps = c.conn.prepareStatement("DELETE FROM data WHERE version!=?")) {
ps.setInt(1, version);
int oldEntries = ps.executeUpdate();
logger.atInfo().log(
"Pruned %d entries not matching version %d from cache %s", oldEntries, version, url);
if (oldEntries > 0) {
logger.atInfo().log(
"Pruned %d entries not matching version %d from cache %s",
oldEntries, version, url);
}
}
try (Statement s = c.conn.createStatement()) {
// Compute size without restricting to version (although obsolete data was just pruned