diff --git a/Documentation/dev-plugins.txt b/Documentation/dev-plugins.txt index 0efc3955b5..aaf3752956 100644 --- a/Documentation/dev-plugins.txt +++ b/Documentation/dev-plugins.txt @@ -990,9 +990,10 @@ buttons. Panel will be shown below the change info block. ** The following parameters are provided: -*** `GerritUiExtensionPoint.Key.CHANGE_ID`: +*** `GerritUiExtensionPoint.Key.CHANGE_INFO`: + -The numeric change ID +The link:rest-api-changes.html#change-info[ChangeInfo] entity for the +current change. * Project Info Screen: ** `GerritUiExtensionPoint.PROJECT_INFO_SCREEN_TOP`: diff --git a/gerrit-common/BUCK b/gerrit-common/BUCK index efe9595ed0..a36a9b7eab 100644 --- a/gerrit-common/BUCK +++ b/gerrit-common/BUCK @@ -24,15 +24,10 @@ gwt_module( name = 'client', srcs = glob([SRC + 'common/**/*.java'], excludes = EXCLUDES), gwt_xml = SRC + 'Common.gwt.xml', - deps = [ - ':annotations', + exported_deps = [ '//gerrit-extension-api:client', - '//gerrit-patch-jgit:client', '//gerrit-prettify:client', - '//gerrit-reviewdb:client', - '//lib:gwtjsonrpc', '//lib:gwtorm_client', - '//lib/jgit:Edit', ], visibility = ['PUBLIC'], ) diff --git a/gerrit-gwtui-common/BUCK b/gerrit-gwtui-common/BUCK index 2eb068401d..6ee0336bc2 100644 --- a/gerrit-gwtui-common/BUCK +++ b/gerrit-gwtui-common/BUCK @@ -1,3 +1,12 @@ +EXPORTED_DEPS = [ + '//gerrit-common:client', + '//gerrit-gwtexpui:Clippy', + '//gerrit-gwtexpui:GlobalKey', + '//gerrit-gwtexpui:Progress', + '//gerrit-gwtexpui:SafeHtml', + '//gerrit-gwtexpui:UserAgent', +] +DEPS = ['//lib/gwt:user'] SRC = 'src/main/java/com/google/gerrit/' DIFFY = glob(['src/main/resources/com/google/gerrit/client/diffy*.png']) @@ -6,7 +15,8 @@ gwt_module( srcs = glob([SRC + 'client/**/*.java']), gwt_xml = SRC + 'GerritGwtUICommon.gwt.xml', resources = glob(['src/main/**/*']), - deps = ['//lib/gwt:user'], + exported_deps = EXPORTED_DEPS, + provided_deps = DEPS, visibility = ['PUBLIC'], ) @@ -20,7 +30,8 @@ java_library( name = 'client-lib2', srcs = glob(['src/main/**/*.java']), resources = glob(['src/main/**/*']), - provided_deps = ['//lib/gwt:user'], + exported_deps = EXPORTED_DEPS, + provided_deps = DEPS, visibility = ['PUBLIC'], ) diff --git a/gerrit-gwtui-common/src/main/java/com/google/gerrit/GerritGwtUICommon.gwt.xml b/gerrit-gwtui-common/src/main/java/com/google/gerrit/GerritGwtUICommon.gwt.xml index eb551c426c..c147195076 100644 --- a/gerrit-gwtui-common/src/main/java/com/google/gerrit/GerritGwtUICommon.gwt.xml +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/GerritGwtUICommon.gwt.xml @@ -14,5 +14,13 @@ limitations under the License. --> + + + + + + + + diff --git a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/GerritUiExtensionPoint.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/GerritUiExtensionPoint.java index e22625cab9..61f73c0ccc 100644 --- a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/GerritUiExtensionPoint.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/GerritUiExtensionPoint.java @@ -34,6 +34,6 @@ public enum GerritUiExtensionPoint { PROJECT_INFO_SCREEN_TOP, PROJECT_INFO_SCREEN_BOTTOM; public enum Key { - ACCOUNT_INFO, CHANGE_ID, PROJECT_NAME + ACCOUNT_INFO, CHANGE_INFO, PROJECT_NAME } } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/actions/ActionInfo.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ActionInfo.java similarity index 96% rename from gerrit-gwtui/src/main/java/com/google/gerrit/client/actions/ActionInfo.java rename to gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ActionInfo.java index ef0c4b5038..3b283ec78d 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/actions/ActionInfo.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ActionInfo.java @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.client.actions; +package com.google.gerrit.client.info; import com.google.gwt.core.client.JavaScriptObject; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfo.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ChangeInfo.java similarity index 97% rename from gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfo.java rename to gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ChangeInfo.java index 5b7e304cf6..695c126368 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeInfo.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/ChangeInfo.java @@ -12,12 +12,8 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.client.changes; +package com.google.gerrit.client.info; -import com.google.gerrit.client.WebLinkInfo; -import com.google.gerrit.client.actions.ActionInfo; -import com.google.gerrit.client.diff.FileInfo; -import com.google.gerrit.client.info.AccountInfo; import com.google.gerrit.client.rpc.NativeMap; import com.google.gerrit.client.rpc.NativeString; import com.google.gerrit.client.rpc.Natives; @@ -128,8 +124,8 @@ public class ChangeInfo extends JavaScriptObject { public final native boolean hasActions() /*-{ return this.hasOwnProperty('actions') }-*/; public final native NativeMap actions() /*-{ return this.actions; }-*/; - final native int _number() /*-{ return this._number; }-*/; - final native boolean _more_changes() + public final native int _number() /*-{ return this._number; }-*/; + public final native boolean _more_changes() /*-{ return this._more_changes ? true : false; }-*/; public final boolean submittable() { @@ -225,7 +221,7 @@ public class ChangeInfo extends JavaScriptObject { public final native boolean optional() /*-{ return this.optional ? true : false; }-*/; public final native boolean blocking() /*-{ return this.blocking ? true : false; }-*/; public final native short defaultValue() /*-{ return this.default_value; }-*/; - final native short _value() + public final native short _value() /*-{ if (this.value) return this.value; if (this.disliked) return -1; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/FileInfo.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/FileInfo.java similarity index 95% rename from gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/FileInfo.java rename to gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/FileInfo.java index 77b28d4e07..b21078ec1d 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/FileInfo.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/FileInfo.java @@ -12,9 +12,8 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.client.diff; +package com.google.gerrit.client.info; -import com.google.gerrit.client.changes.Util; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.reviewdb.client.Patch; import com.google.gwt.core.client.JavaScriptObject; @@ -64,7 +63,7 @@ public class FileInfo extends JavaScriptObject { public static String getFileName(String path) { String fileName = Patch.COMMIT_MSG.equals(path) - ? Util.C.commitMessage() + ? "Commit Message" : path; int s = fileName.lastIndexOf('/'); return s >= 0 ? fileName.substring(s + 1) : fileName; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/WebLinkInfo.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/WebLinkInfo.java similarity index 97% rename from gerrit-gwtui/src/main/java/com/google/gerrit/client/WebLinkInfo.java rename to gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/WebLinkInfo.java index 45731f777d..367486bd89 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/WebLinkInfo.java +++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/WebLinkInfo.java @@ -12,7 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -package com.google.gerrit.client; +package com.google.gerrit.client.info; import com.google.gwt.core.client.JavaScriptObject; import com.google.gwt.user.client.ui.Anchor; diff --git a/gerrit-gwtui/BUCK b/gerrit-gwtui/BUCK index 0437f5ca92..5eed21a5e0 100644 --- a/gerrit-gwtui/BUCK +++ b/gerrit-gwtui/BUCK @@ -27,24 +27,10 @@ gwt_module( deps = [ ':freebie_application_icon_set', '//gerrit-gwtui-common:diffy_logo', - '//gerrit-gwtexpui:Clippy', - '//gerrit-gwtexpui:GlobalKey', - '//gerrit-gwtexpui:Progress', - '//gerrit-gwtexpui:SafeHtml', - '//gerrit-gwtexpui:UserAgent', '//gerrit-gwtui-common:client', - '//gerrit-common:client', - '//gerrit-extension-api:client', - '//gerrit-patch-jgit:client', - '//gerrit-prettify:client', - '//gerrit-reviewdb:client', '//gerrit-gwtexpui:CSS', - '//lib:gwtjsonrpc', - '//lib:gwtjsonrpc_src', - '//lib:gwtorm_client', '//lib/codemirror:codemirror', '//lib/gwt:user', - '//lib/jgit:Edit', ], visibility = [ '//tools/eclipse:classpath', diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/GerritGwtUI.gwt.xml b/gerrit-gwtui/src/main/java/com/google/gerrit/GerritGwtUI.gwt.xml index 0f5065fa7d..9ac919b099 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/GerritGwtUI.gwt.xml +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/GerritGwtUI.gwt.xml @@ -18,17 +18,9 @@ - - - - - - - - diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/DiffWebLinkInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/DiffWebLinkInfo.java index bcf4256e36..d52838d3a5 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/DiffWebLinkInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/DiffWebLinkInfo.java @@ -14,6 +14,8 @@ package com.google.gerrit.client; +import com.google.gerrit.client.info.WebLinkInfo; + public class DiffWebLinkInfo extends WebLinkInfo { public final native boolean showOnSideBySideDiffView() /*-{ return this.show_on_side_by_side_diff_view || false; }-*/; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/actions/ActionButton.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/actions/ActionButton.java index 2e2d31449e..8f5d7a83e8 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/actions/ActionButton.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/actions/ActionButton.java @@ -19,9 +19,10 @@ import com.google.gerrit.client.api.ChangeGlue; import com.google.gerrit.client.api.EditGlue; import com.google.gerrit.client.api.ProjectGlue; import com.google.gerrit.client.api.RevisionGlue; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.EditInfo; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ActionInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.EditInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.projects.BranchInfo; import com.google.gerrit.reviewdb.client.Project; import com.google.gwt.event.dom.client.ClickEvent; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/CreateChangeAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/CreateChangeAction.java index de83354e75..ad8a595698 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/CreateChangeAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/CreateChangeAction.java @@ -16,7 +16,7 @@ package com.google.gerrit.client.admin; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.ui.CreateChangeDialog; import com.google.gerrit.common.PageLinks; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/EditConfigAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/EditConfigAction.java index b5f87cf785..3e6086ba92 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/EditConfigAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/EditConfigAction.java @@ -17,7 +17,7 @@ package com.google.gerrit.client.admin; import com.google.gerrit.client.Dispatcher; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gerrit.reviewdb.client.RefNames; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectBranchesScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectBranchesScreen.java index 283c834305..725fb0999f 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectBranchesScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectBranchesScreen.java @@ -21,12 +21,12 @@ import com.google.gerrit.client.ConfirmationDialog; import com.google.gerrit.client.ErrorDialog; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.VoidResult; -import com.google.gerrit.client.WebLinkInfo; import com.google.gerrit.client.access.AccessMap; import com.google.gerrit.client.access.ProjectAccessInfo; import com.google.gerrit.client.actions.ActionButton; -import com.google.gerrit.client.actions.ActionInfo; import com.google.gerrit.client.config.GitwebInfo; +import com.google.gerrit.client.info.ActionInfo; +import com.google.gerrit.client.info.WebLinkInfo; import com.google.gerrit.client.projects.BranchInfo; import com.google.gerrit.client.projects.ProjectApi; import com.google.gerrit.client.rpc.GerritCallback; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectInfoScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectInfoScreen.java index 97240009e5..7a9415b509 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectInfoScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectInfoScreen.java @@ -20,12 +20,12 @@ import com.google.gerrit.client.StringListPanel; import com.google.gerrit.client.access.AccessMap; import com.google.gerrit.client.access.ProjectAccessInfo; import com.google.gerrit.client.actions.ActionButton; -import com.google.gerrit.client.actions.ActionInfo; import com.google.gerrit.client.api.ExtensionPanel; import com.google.gerrit.client.change.Resources; import com.google.gerrit.client.config.DownloadInfo.DownloadCommandInfo; import com.google.gerrit.client.config.DownloadInfo.DownloadSchemeInfo; import com.google.gerrit.client.download.DownloadPanel; +import com.google.gerrit.client.info.ActionInfo; import com.google.gerrit.client.projects.ConfigInfo; import com.google.gerrit.client.projects.ConfigInfo.ConfigParameterInfo; import com.google.gerrit.client.projects.ConfigInfo.ConfigParameterValue; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java index 2ee6c8543d..6990996110 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java @@ -18,8 +18,8 @@ import static com.google.gerrit.common.PageLinks.ADMIN_PROJECTS; import com.google.gerrit.client.Dispatcher; import com.google.gerrit.client.Gerrit; -import com.google.gerrit.client.WebLinkInfo; import com.google.gerrit.client.config.GitwebInfo; +import com.google.gerrit.client.info.WebLinkInfo; import com.google.gerrit.client.projects.ProjectInfo; import com.google.gerrit.client.projects.ProjectMap; import com.google.gerrit.client.rpc.GerritCallback; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ActionContext.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ActionContext.java index ec5c4a68fc..a4fbb85715 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ActionContext.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ActionContext.java @@ -15,10 +15,10 @@ package com.google.gerrit.client.api; import com.google.gerrit.client.actions.ActionButton; -import com.google.gerrit.client.actions.ActionInfo; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.EditInfo; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ActionInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.EditInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.projects.BranchInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.rpc.NativeString; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ChangeGlue.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ChangeGlue.java index e831e8b023..82b6810592 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ChangeGlue.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ChangeGlue.java @@ -15,10 +15,10 @@ package com.google.gerrit.client.api; import com.google.gerrit.client.actions.ActionButton; -import com.google.gerrit.client.actions.ActionInfo; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ActionInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.rpc.RestApi; import com.google.gwt.core.client.JavaScriptObject; import com.google.gwt.core.client.JsArray; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/DefaultActions.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/DefaultActions.java index c092375623..55c40f87bb 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/DefaultActions.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/DefaultActions.java @@ -15,8 +15,8 @@ package com.google.gerrit.client.api; import com.google.gerrit.client.Gerrit; -import com.google.gerrit.client.actions.ActionInfo; -import com.google.gerrit.client.changes.ChangeInfo; +import com.google.gerrit.client.info.ActionInfo; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.rpc.NativeString; import com.google.gerrit.client.rpc.RestApi; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/EditGlue.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/EditGlue.java index f968fd2fb8..49b150aa60 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/EditGlue.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/EditGlue.java @@ -15,10 +15,10 @@ package com.google.gerrit.client.api; import com.google.gerrit.client.actions.ActionButton; -import com.google.gerrit.client.actions.ActionInfo; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.EditInfo; +import com.google.gerrit.client.info.ActionInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.EditInfo; import com.google.gerrit.client.rpc.RestApi; import com.google.gwt.core.client.JavaScriptObject; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ProjectGlue.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ProjectGlue.java index 3f2e794aff..69887e7363 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ProjectGlue.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/ProjectGlue.java @@ -15,7 +15,7 @@ package com.google.gerrit.client.api; import com.google.gerrit.client.actions.ActionButton; -import com.google.gerrit.client.actions.ActionInfo; +import com.google.gerrit.client.info.ActionInfo; import com.google.gerrit.client.projects.BranchInfo; import com.google.gerrit.client.projects.ProjectApi; import com.google.gerrit.client.rpc.RestApi; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/RevisionGlue.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/RevisionGlue.java index d708e8c8e2..914ef85917 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/RevisionGlue.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/RevisionGlue.java @@ -15,10 +15,10 @@ package com.google.gerrit.client.api; import com.google.gerrit.client.actions.ActionButton; -import com.google.gerrit.client.actions.ActionInfo; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ActionInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.rpc.RestApi; import com.google.gwt.core.client.JavaScriptObject; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AbandonAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AbandonAction.java index 54b83f1937..e93bcd9535 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AbandonAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AbandonAction.java @@ -16,7 +16,7 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.common.PageLinks; import com.google.gerrit.reviewdb.client.Change; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Actions.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Actions.java index 3df0b2d21b..033a3a81af 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Actions.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Actions.java @@ -16,10 +16,10 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.actions.ActionButton; -import com.google.gerrit.client.actions.ActionInfo; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.CommitInfo; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ActionInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.CommitInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.rpc.NativeMap; import com.google.gerrit.reviewdb.client.Change; import com.google.gwt.core.client.GWT; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AddFileAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AddFileAction.java index b2cac89641..195623a1b3 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AddFileAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AddFileAction.java @@ -14,7 +14,7 @@ package com.google.gerrit.client.change; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.reviewdb.client.Change; import com.google.gwt.event.logical.shared.CloseEvent; import com.google.gwt.event.logical.shared.CloseHandler; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AddFileBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AddFileBox.java index 09de2c877a..f747e0d157 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AddFileBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/AddFileBox.java @@ -16,7 +16,7 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Dispatcher; import com.google.gerrit.client.Gerrit; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.ui.RemoteSuggestBox; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.PatchSet; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen.java index 2c7d137c3b..7e1b5d30b6 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeScreen.java @@ -19,24 +19,24 @@ import com.google.gerrit.client.ErrorDialog; import com.google.gerrit.client.FormatUtil; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.GerritUiExtensionPoint; -import com.google.gerrit.client.actions.ActionInfo; import com.google.gerrit.client.api.ChangeGlue; import com.google.gerrit.client.api.ExtensionPanel; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.CommitInfo; -import com.google.gerrit.client.changes.ChangeInfo.EditInfo; -import com.google.gerrit.client.changes.ChangeInfo.LabelInfo; -import com.google.gerrit.client.changes.ChangeInfo.MessageInfo; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; import com.google.gerrit.client.changes.ChangeList; import com.google.gerrit.client.changes.CommentInfo; import com.google.gerrit.client.changes.RevisionInfoCache; import com.google.gerrit.client.changes.StarredChanges; import com.google.gerrit.client.changes.Util; import com.google.gerrit.client.diff.DiffApi; -import com.google.gerrit.client.diff.FileInfo; +import com.google.gerrit.client.info.ActionInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.FileInfo; import com.google.gerrit.client.info.AccountInfo.AvatarInfo; +import com.google.gerrit.client.info.ChangeInfo.CommitInfo; +import com.google.gerrit.client.info.ChangeInfo.EditInfo; +import com.google.gerrit.client.info.ChangeInfo.LabelInfo; +import com.google.gerrit.client.info.ChangeInfo.MessageInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.projects.ConfigInfoCache; import com.google.gerrit.client.projects.ConfigInfoCache.Entry; import com.google.gerrit.client.rpc.CallbackGroup; @@ -230,7 +230,6 @@ public class ChangeScreen extends Screen { @Override protected void onLoad() { super.onLoad(); - addExtensionPoints(); CallbackGroup group = new CallbackGroup(); if (Gerrit.isSignedIn()) { ChangeList.query("change:" + changeId.get() + " has:draft", @@ -262,26 +261,28 @@ public class ChangeScreen extends Screen { @Override public void onSuccess(ChangeInfo info) { info.init(); + addExtensionPoints(info); loadConfigInfo(info, base); } })); } - private void addExtensionPoints() { + private void addExtensionPoints(ChangeInfo change) { addExtensionPoint(GerritUiExtensionPoint.CHANGE_SCREEN_HEADER, - headerExtension); + headerExtension, change); addExtensionPoint(GerritUiExtensionPoint.CHANGE_SCREEN_HEADER_RIGHT_OF_BUTTONS, - headerExtensionMiddle); + headerExtensionMiddle, change); addExtensionPoint(GerritUiExtensionPoint.CHANGE_SCREEN_HEADER_RIGHT_OF_POP_DOWNS, - headerExtensionRight); + headerExtensionRight, change); addExtensionPoint( GerritUiExtensionPoint.CHANGE_SCREEN_BELOW_CHANGE_INFO_BLOCK, - changeExtension); + changeExtension, change); } - private void addExtensionPoint(GerritUiExtensionPoint extensionPoint, Panel p) { + private void addExtensionPoint(GerritUiExtensionPoint extensionPoint, + Panel p, ChangeInfo change) { ExtensionPanel extensionPanel = new ExtensionPanel(extensionPoint); - extensionPanel.putInt(GerritUiExtensionPoint.Key.CHANGE_ID, changeId.get()); + extensionPanel.putObject(GerritUiExtensionPoint.Key.CHANGE_INFO, change); p.add(extensionPanel); } diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/CherryPickAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/CherryPickAction.java index 357f04c642..3b72581893 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/CherryPickAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/CherryPickAction.java @@ -16,8 +16,8 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; import com.google.gerrit.client.changes.Util; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.ui.CherryPickDialog; import com.google.gerrit.common.PageLinks; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/CommitBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/CommitBox.java index bfaff93712..8c2840dcb1 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/CommitBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/CommitBox.java @@ -17,13 +17,13 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.AvatarImage; import com.google.gerrit.client.FormatUtil; import com.google.gerrit.client.Gerrit; -import com.google.gerrit.client.WebLinkInfo; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.CommitInfo; -import com.google.gerrit.client.changes.ChangeInfo.GitPerson; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; import com.google.gerrit.client.config.GitwebInfo; import com.google.gerrit.client.info.AccountInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.WebLinkInfo; +import com.google.gerrit.client.info.ChangeInfo.CommitInfo; +import com.google.gerrit.client.info.ChangeInfo.GitPerson; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.client.ui.CommentLinkProcessor; import com.google.gerrit.client.ui.InlineHyperlink; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DeleteFileAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DeleteFileAction.java index c00644cd94..3a7977a7f0 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DeleteFileAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DeleteFileAction.java @@ -14,7 +14,7 @@ package com.google.gerrit.client.change; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.reviewdb.client.Change; import com.google.gwt.event.logical.shared.CloseEvent; import com.google.gwt.event.logical.shared.CloseHandler; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DeleteFileBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DeleteFileBox.java index aa2b6f0ab5..3d889d0461 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DeleteFileBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DeleteFileBox.java @@ -17,7 +17,7 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.VoidResult; import com.google.gerrit.client.changes.ChangeEditApi; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.ui.RemoteSuggestBox; import com.google.gerrit.common.PageLinks; import com.google.gerrit.reviewdb.client.Change; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DownloadAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DownloadAction.java index 34e67ddd86..9698aefea5 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DownloadAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DownloadAction.java @@ -14,7 +14,7 @@ package com.google.gerrit.client.change; -import com.google.gerrit.client.changes.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gwt.user.client.ui.UIObject; import com.google.gwt.user.client.ui.Widget; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DownloadBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DownloadBox.java index 6d391988ae..85cdec2e9e 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DownloadBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/DownloadBox.java @@ -17,10 +17,10 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.account.AccountApi; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.EditInfo; -import com.google.gerrit.client.changes.ChangeInfo.FetchInfo; import com.google.gerrit.client.changes.ChangeList; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.EditInfo; +import com.google.gerrit.client.info.ChangeInfo.FetchInfo; import com.google.gerrit.client.rpc.NativeMap; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.client.rpc.RestApi; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java index dd8df36f8f..8355e5a03d 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FileTable.java @@ -22,7 +22,7 @@ import com.google.gerrit.client.changes.ChangeEditApi; import com.google.gerrit.client.changes.CommentInfo; import com.google.gerrit.client.changes.ReviewInfo; import com.google.gerrit.client.changes.Util; -import com.google.gerrit.client.diff.FileInfo; +import com.google.gerrit.client.info.FileInfo; import com.google.gerrit.client.patches.PatchUtil; import com.google.gerrit.client.rpc.CallbackGroup; import com.google.gerrit.client.rpc.NativeMap; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FollowUpAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FollowUpAction.java index 8f31010e39..29283b8221 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FollowUpAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/FollowUpAction.java @@ -16,7 +16,7 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.common.PageLinks; import com.google.gwt.user.client.ui.Button; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java index d2afbcf933..55f66b7fff 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java @@ -15,7 +15,7 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.common.PageLinks; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java index 47a870b643..92a0fc8cb7 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java @@ -14,9 +14,9 @@ package com.google.gerrit.client.change; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.MessageInfo; import com.google.gerrit.client.changes.CommentInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.MessageInfo; import com.google.gerrit.client.rpc.NativeMap; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.client.ui.CommentLinkProcessor; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/IncludedInBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/IncludedInBox.java index 74c187e5cc..6493f11953 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/IncludedInBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/IncludedInBox.java @@ -15,7 +15,7 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo.IncludedInInfo; +import com.google.gerrit.client.info.ChangeInfo.IncludedInInfo; import com.google.gerrit.reviewdb.client.Change; import com.google.gwt.core.client.GWT; import com.google.gwt.core.client.JsArrayString; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java index aceed5762f..eb2278da40 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java @@ -16,12 +16,12 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.ApprovalInfo; -import com.google.gerrit.client.changes.ChangeInfo.LabelInfo; import com.google.gerrit.client.changes.Util; import com.google.gerrit.client.info.AccountInfo; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.info.AccountInfo.AvatarInfo; +import com.google.gerrit.client.info.ChangeInfo.ApprovalInfo; +import com.google.gerrit.client.info.ChangeInfo.LabelInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.common.PageLinks; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Message.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Message.java index 8464f2a4ee..9bb3a76c27 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Message.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Message.java @@ -17,9 +17,9 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.AvatarImage; import com.google.gerrit.client.FormatUtil; import com.google.gerrit.client.Gerrit; -import com.google.gerrit.client.changes.ChangeInfo.MessageInfo; import com.google.gerrit.client.changes.CommentInfo; import com.google.gerrit.client.changes.Util; +import com.google.gerrit.client.info.ChangeInfo.MessageInfo; import com.google.gerrit.client.ui.CommentLinkProcessor; import com.google.gerrit.reviewdb.client.Patch; import com.google.gerrit.reviewdb.client.PatchSet; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PatchSetsAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PatchSetsAction.java index 3842ee6fe2..5e2b8e367e 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PatchSetsAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PatchSetsAction.java @@ -14,7 +14,7 @@ package com.google.gerrit.client.change; -import com.google.gerrit.client.changes.ChangeInfo.EditInfo; +import com.google.gerrit.client.info.ChangeInfo.EditInfo; import com.google.gerrit.reviewdb.client.Change; import com.google.gwt.user.client.ui.UIObject; import com.google.gwt.user.client.ui.Widget; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PatchSetsBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PatchSetsBox.java index 582126846d..1d7661237e 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PatchSetsBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PatchSetsBox.java @@ -17,11 +17,11 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.FormatUtil; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.CommitInfo; -import com.google.gerrit.client.changes.ChangeInfo.EditInfo; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; import com.google.gerrit.client.changes.ChangeList; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.CommitInfo; +import com.google.gerrit.client.info.ChangeInfo.EditInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.rpc.NativeMap; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.client.rpc.RestApi; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PathSuggestOracle.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PathSuggestOracle.java index 7667559a14..2ca26cee9e 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PathSuggestOracle.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/PathSuggestOracle.java @@ -15,7 +15,7 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.reviewdb.client.Change; import com.google.gwt.core.client.JsArrayString; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/QuickApprove.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/QuickApprove.java index 105a3c84c5..ebeb574324 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/QuickApprove.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/QuickApprove.java @@ -16,10 +16,10 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.LabelInfo; import com.google.gerrit.client.changes.ReviewInput; import com.google.gerrit.client.changes.ReviewInput.DraftHandling; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.LabelInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.common.PageLinks; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RebaseAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RebaseAction.java index 790198b014..986bd78d4d 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RebaseAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RebaseAction.java @@ -16,7 +16,7 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.ui.RebaseDialog; import com.google.gerrit.common.PageLinks; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChanges.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChanges.java index 7f4fb59dc2..ae1a608f81 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChanges.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChanges.java @@ -18,10 +18,10 @@ import static com.google.gerrit.common.PageLinks.op; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.CommitInfo; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; import com.google.gerrit.client.changes.ChangeList; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.CommitInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.extensions.client.ListChangesOption; import com.google.gerrit.reviewdb.client.Change; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChangesTab.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChangesTab.java index ab47b69626..aa27d16816 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChangesTab.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RelatedChangesTab.java @@ -16,9 +16,9 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.change.RelatedChanges.ChangeAndCommit; -import com.google.gerrit.client.changes.ChangeInfo.CommitInfo; import com.google.gerrit.client.changes.Util; import com.google.gerrit.client.config.GitwebInfo; +import com.google.gerrit.client.info.ChangeInfo.CommitInfo; import com.google.gerrit.common.PageLinks; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.PatchSet; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RenameFileAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RenameFileAction.java index ded427acac..9783cf43e2 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RenameFileAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RenameFileAction.java @@ -14,7 +14,7 @@ package com.google.gerrit.client.change; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.reviewdb.client.Change; import com.google.gwt.event.logical.shared.CloseEvent; import com.google.gwt.event.logical.shared.CloseHandler; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RenameFileBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RenameFileBox.java index d6ab9ae73c..d0d8b4883b 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RenameFileBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RenameFileBox.java @@ -17,7 +17,7 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.VoidResult; import com.google.gerrit.client.changes.ChangeEditApi; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.ui.RemoteSuggestBox; import com.google.gerrit.common.PageLinks; import com.google.gerrit.reviewdb.client.Change; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java index 303bb47f48..7882eecf7f 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyAction.java @@ -14,10 +14,10 @@ package com.google.gerrit.client.change; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.LabelInfo; -import com.google.gerrit.client.changes.ChangeInfo.MessageInfo; import com.google.gerrit.client.changes.ReviewInput; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.LabelInfo; +import com.google.gerrit.client.info.ChangeInfo.MessageInfo; import com.google.gerrit.client.rpc.NativeMap; import com.google.gerrit.client.ui.CommentLinkProcessor; import com.google.gerrit.reviewdb.client.PatchSet; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java index aec617aa6a..626e7c052d 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ReplyBox.java @@ -18,13 +18,13 @@ import static com.google.gwt.event.dom.client.KeyCodes.KEY_ENTER; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo.ApprovalInfo; -import com.google.gerrit.client.changes.ChangeInfo.LabelInfo; -import com.google.gerrit.client.changes.ChangeInfo.MessageInfo; import com.google.gerrit.client.changes.CommentInfo; import com.google.gerrit.client.changes.ReviewInput; import com.google.gerrit.client.changes.ReviewInput.DraftHandling; import com.google.gerrit.client.changes.Util; +import com.google.gerrit.client.info.ChangeInfo.ApprovalInfo; +import com.google.gerrit.client.info.ChangeInfo.LabelInfo; +import com.google.gerrit.client.info.ChangeInfo.MessageInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.rpc.NativeMap; import com.google.gerrit.client.rpc.Natives; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RestoreAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RestoreAction.java index 5ec292b984..253c9a7549 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RestoreAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RestoreAction.java @@ -16,7 +16,7 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.common.PageLinks; import com.google.gerrit.reviewdb.client.Change; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RevertAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RevertAction.java index fe0e6d0fd1..ae1b5d1918 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RevertAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/RevertAction.java @@ -16,8 +16,8 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; import com.google.gerrit.client.changes.Util; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.ui.TextAreaActionDialog; import com.google.gerrit.common.PageLinks; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Reviewers.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Reviewers.java index 22a7155099..5a01c46f24 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Reviewers.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Reviewers.java @@ -18,11 +18,11 @@ import com.google.gerrit.client.ConfirmationCallback; import com.google.gerrit.client.ConfirmationDialog; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.ApprovalInfo; -import com.google.gerrit.client.changes.ChangeInfo.LabelInfo; import com.google.gerrit.client.changes.Util; import com.google.gerrit.client.info.AccountInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.ApprovalInfo; +import com.google.gerrit.client.info.ChangeInfo.LabelInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.rpc.NativeMap; import com.google.gerrit.client.rpc.NativeString; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/SubmitAction.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/SubmitAction.java index f45b983bb1..ad1043ab41 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/SubmitAction.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/SubmitAction.java @@ -17,9 +17,9 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.api.ChangeGlue; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; import com.google.gerrit.client.changes.SubmitInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.common.PageLinks; import com.google.gerrit.reviewdb.client.Change; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Topic.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Topic.java index b3eff938d2..bd9bec32e9 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Topic.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Topic.java @@ -16,7 +16,7 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.ui.InlineHyperlink; import com.google.gerrit.common.PageLinks; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/UpdateAvailableBar.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/UpdateAvailableBar.java index 2daa9ea3a3..c14e628b8c 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/UpdateAvailableBar.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/UpdateAvailableBar.java @@ -14,7 +14,7 @@ package com.google.gerrit.client.change; -import com.google.gerrit.client.changes.ChangeInfo.MessageInfo; +import com.google.gerrit.client.info.ChangeInfo.MessageInfo; import com.google.gwt.core.client.GWT; import com.google.gwt.dom.client.Element; import com.google.gwt.event.dom.client.ClickEvent; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/UpdateCheckTimer.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/UpdateCheckTimer.java index 1e446926bd..b1c97612e1 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/UpdateCheckTimer.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/UpdateCheckTimer.java @@ -15,7 +15,7 @@ package com.google.gerrit.client.change; import com.google.gerrit.client.Gerrit; -import com.google.gerrit.client.changes.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.ui.UserActivityMonitor; import com.google.gwt.event.logical.shared.ValueChangeEvent; import com.google.gwt.event.logical.shared.ValueChangeHandler; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/AccountDashboardScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/AccountDashboardScreen.java index a32a914eda..f53ecf8c19 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/AccountDashboardScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/AccountDashboardScreen.java @@ -16,6 +16,7 @@ package com.google.gerrit.client.changes; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.NotFoundScreen; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.client.rpc.ScreenLoadCallback; import com.google.gerrit.client.ui.InlineHyperlink; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeApi.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeApi.java index 46d5067c16..9cafeec2f9 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeApi.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeApi.java @@ -15,9 +15,10 @@ package com.google.gerrit.client.changes; import com.google.gerrit.client.Gerrit; -import com.google.gerrit.client.changes.ChangeInfo.CommitInfo; -import com.google.gerrit.client.changes.ChangeInfo.EditInfo; -import com.google.gerrit.client.changes.ChangeInfo.IncludedInInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.CommitInfo; +import com.google.gerrit.client.info.ChangeInfo.EditInfo; +import com.google.gerrit.client.info.ChangeInfo.IncludedInInfo; import com.google.gerrit.client.rpc.CallbackGroup.Callback; import com.google.gerrit.client.rpc.NativeString; import com.google.gerrit.client.rpc.RestApi; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeList.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeList.java index 5fcaf24028..cea914277a 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeList.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeList.java @@ -14,6 +14,7 @@ package com.google.gerrit.client.changes; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.RestApi; import com.google.gerrit.extensions.client.ListChangesOption; import com.google.gwt.core.client.JsArray; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable.java index ae1dfb2632..5f61d3f0ec 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable.java @@ -18,8 +18,9 @@ import static com.google.gerrit.client.FormatUtil.relativeFormat; import static com.google.gerrit.client.FormatUtil.shortFormat; import com.google.gerrit.client.Gerrit; -import com.google.gerrit.client.changes.ChangeInfo.LabelInfo; import com.google.gerrit.client.info.AccountInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo.LabelInfo; import com.google.gerrit.client.ui.AccountLinkPanel; import com.google.gerrit.client.ui.BranchLink; import com.google.gerrit.client.ui.ChangeLink; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/QueryScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/QueryScreen.java index dddbd61264..2b3c6ae3c0 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/QueryScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/QueryScreen.java @@ -15,6 +15,7 @@ package com.google.gerrit.client.changes; import com.google.gerrit.client.Gerrit; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.common.PageLinks; import com.google.gerrit.reviewdb.client.Change; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/RevisionInfoCache.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/RevisionInfoCache.java index 53d618c37a..48e3052d23 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/RevisionInfoCache.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/RevisionInfoCache.java @@ -14,7 +14,7 @@ package com.google.gerrit.client.changes; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.PatchSet; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/config/GitwebInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/config/GitwebInfo.java index 60b10e566c..9dce13b369 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/config/GitwebInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/config/GitwebInfo.java @@ -14,7 +14,7 @@ package com.google.gerrit.client.config; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.common.data.ParameterizedString; import com.google.gerrit.reviewdb.client.Branch; import com.google.gerrit.reviewdb.client.PatchSet; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffApi.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffApi.java index 18d673ab39..800da9182d 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffApi.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffApi.java @@ -15,6 +15,7 @@ package com.google.gerrit.client.diff; import com.google.gerrit.client.changes.ChangeApi; +import com.google.gerrit.client.info.FileInfo; import com.google.gerrit.client.rpc.NativeMap; import com.google.gerrit.client.rpc.RestApi; import com.google.gerrit.reviewdb.client.AccountDiffPreference; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffInfo.java index f7f4528261..923a995b88 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffInfo.java @@ -15,7 +15,7 @@ package com.google.gerrit.client.diff; import com.google.gerrit.client.DiffWebLinkInfo; -import com.google.gerrit.client.WebLinkInfo; +import com.google.gerrit.client.info.WebLinkInfo; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.reviewdb.client.AccountGeneralPreferences.DiffView; import com.google.gerrit.reviewdb.client.Patch.ChangeType; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.java index b188c59512..10b301d3fe 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/DiffTable.java @@ -15,7 +15,7 @@ package com.google.gerrit.client.diff; import com.google.gerrit.client.account.DiffPreferences; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.reviewdb.client.Patch.ChangeType; import com.google.gerrit.reviewdb.client.PatchSet; import com.google.gwt.core.client.GWT; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Header.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Header.java index 799eee563b..efdab19573 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Header.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/Header.java @@ -16,14 +16,15 @@ package com.google.gerrit.client.diff; import com.google.gerrit.client.Dispatcher; import com.google.gerrit.client.Gerrit; -import com.google.gerrit.client.WebLinkInfo; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; import com.google.gerrit.client.changes.ReviewInfo; import com.google.gerrit.client.changes.Util; import com.google.gerrit.client.config.GitwebInfo; import com.google.gerrit.client.diff.DiffInfo.Region; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.FileInfo; +import com.google.gerrit.client.info.WebLinkInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.patches.PatchUtil; import com.google.gerrit.client.rpc.CallbackGroup; import com.google.gerrit.client.rpc.GerritCallback; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PatchSetSelectBox.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PatchSetSelectBox.java index e597398805..a6d15e0364 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PatchSetSelectBox.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/PatchSetSelectBox.java @@ -16,8 +16,8 @@ package com.google.gerrit.client.diff; import com.google.gerrit.client.Dispatcher; import com.google.gerrit.client.Gerrit; -import com.google.gerrit.client.WebLinkInfo; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; +import com.google.gerrit.client.info.WebLinkInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.patches.PatchUtil; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.client.ui.InlineHyperlink; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySide.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySide.java index 3d01aee7f5..8849e26da0 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySide.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySide.java @@ -24,12 +24,13 @@ import com.google.gerrit.client.account.DiffPreferences; import com.google.gerrit.client.change.ChangeScreen; import com.google.gerrit.client.change.FileTable; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; -import com.google.gerrit.client.changes.ChangeInfo.EditInfo; -import com.google.gerrit.client.changes.ChangeInfo.RevisionInfo; import com.google.gerrit.client.changes.ChangeList; import com.google.gerrit.client.diff.DiffInfo.FileMeta; import com.google.gerrit.client.diff.LineMapper.LineOnOtherInfo; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.FileInfo; +import com.google.gerrit.client.info.ChangeInfo.EditInfo; +import com.google.gerrit.client.info.ChangeInfo.RevisionInfo; import com.google.gerrit.client.patches.PatchUtil; import com.google.gerrit.client.projects.ConfigInfoCache; import com.google.gerrit.client.rpc.CallbackGroup; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditScreen.java index 698546dee3..e5a5b53631 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/editor/EditScreen.java @@ -25,11 +25,11 @@ import com.google.gerrit.client.VoidResult; import com.google.gerrit.client.account.DiffPreferences; import com.google.gerrit.client.changes.ChangeApi; import com.google.gerrit.client.changes.ChangeEditApi; -import com.google.gerrit.client.changes.ChangeInfo; import com.google.gerrit.client.diff.DiffApi; import com.google.gerrit.client.diff.DiffInfo; -import com.google.gerrit.client.diff.FileInfo; import com.google.gerrit.client.diff.Header; +import com.google.gerrit.client.info.ChangeInfo; +import com.google.gerrit.client.info.FileInfo; import com.google.gerrit.client.patches.PatchUtil; import com.google.gerrit.client.rpc.CallbackGroup; import com.google.gerrit.client.rpc.GerritCallback; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/NavLinks.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/NavLinks.java index 352ade73c7..8491c6139c 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/NavLinks.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/NavLinks.java @@ -15,8 +15,8 @@ package com.google.gerrit.client.patches; import com.google.gerrit.client.Gerrit; -import com.google.gerrit.client.WebLinkInfo; import com.google.gerrit.client.changes.Util; +import com.google.gerrit.client.info.WebLinkInfo; import com.google.gerrit.client.ui.ChangeLink; import com.google.gerrit.client.ui.InlineHyperlink; import com.google.gerrit.reviewdb.client.PatchSet; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/UnifiedPatchScreen.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/UnifiedPatchScreen.java index 24793229d7..bfa308aa86 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/UnifiedPatchScreen.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/patches/UnifiedPatchScreen.java @@ -18,9 +18,9 @@ import com.google.gerrit.client.Dispatcher; import com.google.gerrit.client.ErrorDialog; import com.google.gerrit.client.Gerrit; import com.google.gerrit.client.RpcStatus; -import com.google.gerrit.client.WebLinkInfo; import com.google.gerrit.client.diff.DiffApi; import com.google.gerrit.client.diff.DiffInfo; +import com.google.gerrit.client.info.WebLinkInfo; import com.google.gerrit.client.projects.ConfigInfoCache; import com.google.gerrit.client.rpc.CallbackGroup; import com.google.gerrit.client.rpc.GerritCallback; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/BranchInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/BranchInfo.java index 0284aa3c14..b94f5d55e6 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/BranchInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/BranchInfo.java @@ -14,8 +14,8 @@ package com.google.gerrit.client.projects; -import com.google.gerrit.client.WebLinkInfo; -import com.google.gerrit.client.actions.ActionInfo; +import com.google.gerrit.client.info.ActionInfo; +import com.google.gerrit.client.info.WebLinkInfo; import com.google.gerrit.client.rpc.NativeMap; import com.google.gerrit.reviewdb.client.RefNames; import com.google.gwt.core.client.JavaScriptObject; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ConfigInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ConfigInfo.java index 2c0bab3b97..3f3875a1de 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ConfigInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ConfigInfo.java @@ -15,7 +15,7 @@ package com.google.gerrit.client.projects; import com.google.gerrit.client.ErrorDialog; -import com.google.gerrit.client.actions.ActionInfo; +import com.google.gerrit.client.info.ActionInfo; import com.google.gerrit.client.rpc.NativeMap; import com.google.gerrit.extensions.client.InheritableBoolean; import com.google.gerrit.extensions.client.ProjectState; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ConfigInfoCache.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ConfigInfoCache.java index e000a973df..6a1ba11849 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ConfigInfoCache.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ConfigInfoCache.java @@ -15,7 +15,7 @@ package com.google.gerrit.client.projects; import com.google.gerrit.client.changes.ChangeApi; -import com.google.gerrit.client.changes.ChangeInfo; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.ui.CommentLinkProcessor; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.Project; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectInfo.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectInfo.java index 029e59b2c4..00a403484a 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectInfo.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/projects/ProjectInfo.java @@ -14,7 +14,7 @@ package com.google.gerrit.client.projects; -import com.google.gerrit.client.WebLinkInfo; +import com.google.gerrit.client.info.WebLinkInfo; import com.google.gerrit.extensions.client.ProjectState; import com.google.gerrit.reviewdb.client.Project; import com.google.gwt.core.client.JavaScriptObject; diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/RebaseDialog.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/RebaseDialog.java index 18d3443498..1a9fc4bbdf 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/RebaseDialog.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/RebaseDialog.java @@ -15,9 +15,9 @@ package com.google.gerrit.client.ui; import com.google.gerrit.client.Gerrit; -import com.google.gerrit.client.changes.ChangeInfo; import com.google.gerrit.client.changes.ChangeList; import com.google.gerrit.client.changes.Util; +import com.google.gerrit.client.info.ChangeInfo; import com.google.gerrit.client.rpc.GerritCallback; import com.google.gerrit.client.rpc.Natives; import com.google.gerrit.common.PageLinks; diff --git a/gerrit-patch-jgit/BUCK b/gerrit-patch-jgit/BUCK index 64155bf7df..b54499f815 100644 --- a/gerrit-patch-jgit/BUCK +++ b/gerrit-patch-jgit/BUCK @@ -9,9 +9,9 @@ gwt_module( gwt_xml = SRC + 'JGit.gwt.xml', deps = [ '//lib:gwtjsonrpc', - '//lib/gwt:user', '//lib/jgit:Edit', ], + provided_deps = ['//lib/gwt:user'], visibility = ['PUBLIC'], ) diff --git a/gerrit-plugin-gwtui/BUCK b/gerrit-plugin-gwtui/BUCK index 0f4c064b47..132ade5afe 100644 --- a/gerrit-plugin-gwtui/BUCK +++ b/gerrit-plugin-gwtui/BUCK @@ -9,7 +9,6 @@ java_binary( name = 'gwtui-api', deps = [ ':gwtui-api-lib', - '//gerrit-extension-api:client-lib', '//gerrit-gwtui-common:client-lib', ], visibility = ['PUBLIC'], @@ -25,14 +24,7 @@ java_library( name = 'gwtui-api-lib2', srcs = SRCS, resources = glob(['src/main/**/*']), - exported_deps = [ - '//gerrit-extension-api:client-lib', - '//gerrit-gwtexpui:Clippy', - '//gerrit-gwtexpui:GlobalKey', - '//gerrit-gwtexpui:SafeHtml', - '//gerrit-gwtexpui:UserAgent', - '//gerrit-gwtui-common:client-lib2', - ], + exported_deps = ['//gerrit-gwtui-common:client-lib2'], provided_deps = DEPS + ['//lib/gwt:dev'], visibility = ['PUBLIC'], ) @@ -67,8 +59,12 @@ java_doc( paths = COMMON + GWTEXPUI, srcs = SRCS, deps = DEPS + [ + '//lib:gwtjsonrpc', + '//lib:gwtorm_client', '//lib/gwt:dev__jar', '//gerrit-gwtui-common:client-lib2', + '//gerrit-common:client', + '//gerrit-reviewdb:client', ], visibility = ['PUBLIC'], do_it_wrong = True, diff --git a/gerrit-prettify/BUCK b/gerrit-prettify/BUCK index b98a149eb7..6728ba6d42 100644 --- a/gerrit-prettify/BUCK +++ b/gerrit-prettify/BUCK @@ -12,13 +12,16 @@ gwt_module( ]), deps = [ ':google-code-prettify', + '//gerrit-gwtexpui:SafeHtml', + ], + exported_deps = [ '//gerrit-patch-jgit:client', '//gerrit-reviewdb:client', - '//gerrit-gwtexpui:SafeHtml', '//lib:gwtjsonrpc', - '//lib/gwt:user', + '//lib:gwtjsonrpc_src', '//lib/jgit:Edit', ], + provided_deps = ['//lib/gwt:user'], visibility = ['PUBLIC'], ) diff --git a/plugins/cookbook-plugin b/plugins/cookbook-plugin index 2ff713f3d3..1d3335f4ff 160000 --- a/plugins/cookbook-plugin +++ b/plugins/cookbook-plugin @@ -1 +1 @@ -Subproject commit 2ff713f3d3f0bbabf00b73c74705cd3741f61a70 +Subproject commit 1d3335f4ffcde22e8cd74a0130619344932ed3b8