opendev/gerrit
Code Issues Proposed changes

Don't remove dashes from approval category name.

Browse Source 
If an approval category name contained a dash, it was removed
by Gerrit. On the other side a space in an approval category name
is converted to a dash. This was confusing for writing Prolog
submit rules. If, for example, one defined a new category named
'X-Y', then in the Prolog code the proper name for that category
would be 'XY' which was unintuitive.

Change-Id: I070a7a5128df1c5d0dd1de5f0385d3d933571702
Signed-off-by: Sasa Zivkov <sasa.zivkov@sap.com>
This commit is contained in:
Sasa Zivkov
2012-09-25 09:29:54 +02:00
parent 03ae1eca36
commit 5d960dcdb5
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/ApprovalCategory.java
View File

@@ -105,7 +105,8 @@ public final class ApprovalCategory {
char c = name.charAt(i); char c = name.charAt(i);
if (('0' <= c && c <= '9') // if (('0' <= c && c <= '9') //
|| ('a' <= c && c <= 'z') // || ('a' <= c && c <= 'z') //
|| ('A' <= c && c <= 'Z')) { || ('A' <= c && c <= 'Z') //
|| (c == '-')) {
r.append(c); r.append(c);
} else if (c == ' ') { } else if (c == ' ') {
r.append('-'); r.append('-');