opendev/gerrit
Code Issues Proposed changes

Use javax.inject.Inject instead of com.google.inject.Inject

Browse Source 
The Guice team is discouraging use of its specific annotation where
possible, to increase JSR330 compliance.

Leave optional injection alone for now, which needs to be manually
replaced with OptionalBinder.

Change-Id: I4f53a518ba6f36fd67af12f3540dc44cbad07ff8
This commit is contained in:
Dave Borowitz
2014-09-29 16:33:00 -07:00
parent ca48514228
commit 5db3bba3e2
638 changed files with 1210 additions and 638 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-lucene/src/main/java/com/google/gerrit/lucene/LuceneIndexModule.java
View File

@@ -22,10 +22,11 @@ import com.google.gerrit.server.index.IndexCollection;
import com.google.gerrit.server.index.IndexModule;
import com.google.gerrit.server.index.Schema;
import com.google.gerrit.server.query.change.ChangeData;
import com.google.inject.Inject;
import com.google.inject.Provides;
import com.google.inject.Singleton;
import javax.inject.Inject;
public class LuceneIndexModule extends LifecycleModule {
private final Integer singleVersion;
private final int threads;

3
gerrit-lucene/src/main/java/com/google/gerrit/lucene/LuceneVersionManager.java
View File

@@ -25,7 +25,6 @@ import com.google.gerrit.server.index.ChangeSchemas;
import com.google.gerrit.server.index.IndexCollection;
import com.google.gerrit.server.index.Schema;
import com.google.gerrit.server.query.change.ChangeData;
import com.google.inject.Inject;
import com.google.inject.ProvisionException;
import com.google.inject.Singleton;
@@ -42,6 +41,8 @@ import java.util.Collection;
import java.util.List;
import java.util.TreeMap;
import javax.inject.Inject;
@Singleton
class LuceneVersionManager implements LifecycleListener {
private static final Logger log = LoggerFactory

3
gerrit-lucene/src/main/java/com/google/gerrit/lucene/OnlineReindexer.java
View File

@@ -21,7 +21,6 @@ import com.google.gerrit.server.index.ChangeBatchIndexer;
import com.google.gerrit.server.index.ChangeIndex;
import com.google.gerrit.server.index.IndexCollection;
import com.google.gerrit.server.project.ProjectCache;
import com.google.inject.Inject;
import com.google.inject.assistedinject.Assisted;
import org.slf4j.Logger;
@@ -30,6 +29,8 @@ import org.slf4j.LoggerFactory;
import java.io.IOException;
import java.util.List;
import javax.inject.Inject;
public class OnlineReindexer {
private static final Logger log = LoggerFactory
.getLogger(OnlineReindexer.class);