Use try-with-resources statements

- instead of finally blocks
- in cases of missing try-finally

Change-Id: I94f481a33d8e6a3180c436245d6e95e4d525280c

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/AccountCreator.java

@@ -71,8 +71,7 @@ public class AccountCreator {
     if (account != null) {
       return account;
     }
-    ReviewDb db = reviewDbProvider.open();
+    try (ReviewDb db = reviewDbProvider.open()) {
-    try {
       Account.Id id = new Account.Id(db.nextAccountId());
       KeyPair sshKey = genSshKey();
       AccountSshKey key =
@@ -115,8 +114,6 @@ public class AccountCreator {
           new TestAccount(id, username, email, fullName, sshKey, httpPass);
       accounts.put(username, account);
       return account;
-    } finally {
-      db.close();
     }
   }
 

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/GcAssert.java

@@ -58,8 +58,7 @@ public class GcAssert {
 
   private String[] getPackFiles(Project.NameKey p)
       throws RepositoryNotFoundException, IOException {
-    Repository repo = repoManager.openRepository(p);
+    try (Repository repo = repoManager.openRepository(p)) {
-    try {
       File packDir = new File(repo.getDirectory(), "objects/pack");
       return packDir.list(new FilenameFilter() {
         @Override
@@ -67,8 +66,6 @@ public class GcAssert {
           return name.endsWith(".pack");
         }
       });
-    } finally {
-      repo.close();
     }
   }
 }

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/git/VisibleRefFilterIT.java

@@ -115,8 +115,7 @@ public class VisibleRefFilterIT extends AbstractDaemonTest {
     c2 = br.getChange().getId();
     r2 = changeRefPrefix(c2);
 
-    Repository repo = repoManager.openRepository(project);
+    try (Repository repo = repoManager.openRepository(project)) {
-    try {
       // master-tag -> master
       RefUpdate mtu = repo.updateRef("refs/tags/master-tag");
       mtu.setExpectedOldObjectId(ObjectId.zeroId());
@@ -128,8 +127,6 @@ public class VisibleRefFilterIT extends AbstractDaemonTest {
       btu.setExpectedOldObjectId(ObjectId.zeroId());
       btu.setNewObjectId(repo.getRef("refs/heads/branch").getObjectId());
       assertThat(btu.update()).isEqualTo(RefUpdate.Result.NEW);
-    } finally {
-      repo.close();
     }
   }
 

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/change/AbstractSubmit.java

@@ -249,15 +249,12 @@ public abstract class AbstractSubmit extends AbstractDaemonTest {
     ChangeInfo c = get(changeId, CURRENT_REVISION);
     assertThat(c.currentRevision).isEqualTo(expectedId.name());
     assertThat(c.revisions.get(expectedId.name())._number).isEqualTo(expectedNum);
-    Repository repo =
+    try (Repository repo =
-        repoManager.openRepository(new Project.NameKey(c.project));
+        repoManager.openRepository(new Project.NameKey(c.project))) {
-    try {
       Ref ref = repo.getRef(
           new PatchSet.Id(new Change.Id(c._number), expectedNum).toRefName());
       assertThat(ref).isNotNull();
       assertThat(ref.getObjectId()).isEqualTo(expectedId);
-    } finally {
-      repo.close();
     }
   }
 

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/project/CreateProjectIT.java

@@ -263,13 +263,10 @@ public class CreateProjectIT extends AbstractDaemonTest {
 
   private void assertHead(String projectName, String expectedRef)
       throws RepositoryNotFoundException, IOException {
-    Repository repo =
+    try (Repository repo =
-        repoManager.openRepository(new Project.NameKey(projectName));
+        repoManager.openRepository(new Project.NameKey(projectName))) {
-    try {
       assertThat(repo.getRef(Constants.HEAD).getTarget().getName())
         .isEqualTo(expectedRef);
-    } finally {
-      repo.close();
     }
   }
 

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/server/project/LabelTypeIT.java

@@ -330,12 +330,9 @@ public class LabelTypeIT extends AbstractDaemonTest {
   private void merge(PushOneCommit.Result r) throws Exception {
     revision(r).review(ReviewInput.approve());
     revision(r).submit();
-    Repository repo = repoManager.openRepository(project);
+    try (Repository repo = repoManager.openRepository(project)) {
-    try {
       assertThat(repo.getRef("refs/heads/master").getObjectId()).isEqualTo(
           r.getCommitId());
-    } finally {
-      repo.close();
     }
   }
 

gerrit-cache-h2/src/main/java/com/google/gerrit/server/cache/h2/H2CacheImpl.java

@@ -258,15 +258,10 @@ public class H2CacheImpl<K, V> extends AbstractLoadingCache<K, V> implements
 
         @Override
         public void funnel(K from, PrimitiveSink into) {
-          try {
+          try (ObjectOutputStream ser =
-            ObjectOutputStream ser =
+              new ObjectOutputStream(new SinkOutputStream(into))) {
-                new ObjectOutputStream(new SinkOutputStream(into));
+            ser.writeObject(from);
-            try {
+            ser.flush();
-              ser.writeObject(from);
-              ser.flush();
-            } finally {
-              ser.close();
-            }
           } catch (IOException err) {
             throw new RuntimeException("Cannot hash as Serializable", err);
           }

gerrit-gwtexpui/src/main/java/com/google/gwtexpui/css/rebind/CssLinker.java

@@ -77,19 +77,14 @@ public class CssLinker extends AbstractLinker {
 
   private String name(final TreeLogger logger, final PublicResource r)
       throws UnableToCompleteException {
-    final InputStream in = r.getContents(logger);
     final ByteArrayOutputStream tmp = new ByteArrayOutputStream();
-    try {
+    try (InputStream in = r.getContents(logger)) {
-      try {
+      final byte[] buf = new byte[2048];
-        final byte[] buf = new byte[2048];
+      int n;
-        int n;
+      while ((n = in.read(buf)) >= 0) {
-        while ((n = in.read(buf)) >= 0) {
+        tmp.write(buf, 0, n);
-          tmp.write(buf, 0, n);
-        }
-        tmp.close();
-      } finally {
-        in.close();
       }
+      tmp.close();
     } catch (IOException e) {
       final UnableToCompleteException ute = new UnableToCompleteException();
       ute.initCause(e);

gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/become/BecomeAnyAccountLoginServlet.java

@@ -104,11 +104,8 @@ class BecomeAnyAccountLoginServlet extends HttpServlet {
       rsp.setContentType("text/html");
       rsp.setCharacterEncoding(HtmlDomUtil.ENC.name());
       rsp.setContentLength(raw.length);
-      final OutputStream out = rsp.getOutputStream();
+      try (OutputStream out = rsp.getOutputStream()) {
-      try {
         out.write(raw);
-      } finally {
-        out.close();
       }
       return;
     }
@@ -129,13 +126,13 @@ class BecomeAnyAccountLoginServlet extends HttpServlet {
     } else {
       rsp.setContentType("text/html");
       rsp.setCharacterEncoding(HtmlDomUtil.ENC.name());
-      final Writer out = rsp.getWriter();
+      try (Writer out = rsp.getWriter()) {
-      out.write("<html>");
+        out.write("<html>");
-      out.write("<body>");
+        out.write("<body>");
-      out.write("<h1>Account Not Found</h1>");
+        out.write("<h1>Account Not Found</h1>");
-      out.write("</body>");
+        out.write("</body>");
-      out.write("</html>");
+        out.write("</html>");
-      out.close();
+      }
     }
   }
 
@@ -147,8 +144,7 @@ class BecomeAnyAccountLoginServlet extends HttpServlet {
     }
 
     Element userlistElement = HtmlDomUtil.find(doc, "userlist");
-    ReviewDb db = schema.open();
+    try (ReviewDb db = schema.open()) {
-    try {
       ResultSet<Account> accounts = db.accounts().firstNById(100);
       for (Account a : accounts) {
         String displayName;
@@ -168,8 +164,6 @@ class BecomeAnyAccountLoginServlet extends HttpServlet {
         userlistElement.appendChild(linkElement);
         userlistElement.appendChild(doc.createElement("br"));
       }
-    } finally {
-      db.close();
     }
 
     return HtmlDomUtil.toUTF8(doc);
@@ -190,15 +184,10 @@ class BecomeAnyAccountLoginServlet extends HttpServlet {
   }
 
   private AuthResult byUserName(final String userName) {
-    try {
+    try (ReviewDb db = schema.open()) {
-      final ReviewDb db = schema.open();
+      AccountExternalId.Key key =
-      try {
+          new AccountExternalId.Key(SCHEME_USERNAME, userName);
-        AccountExternalId.Key key =
+      return auth(db.accountExternalIds().get(key));
-            new AccountExternalId.Key(SCHEME_USERNAME, userName);
-        return auth(db.accountExternalIds().get(key));
-      } finally {
-        db.close();
-      }
     } catch (OrmException e) {
       getServletContext().log("cannot query database", e);
       return null;
@@ -206,14 +195,9 @@ class BecomeAnyAccountLoginServlet extends HttpServlet {
   }
 
   private AuthResult byPreferredEmail(final String email) {
-    try {
+    try (ReviewDb db = schema.open()) {
-      final ReviewDb db = schema.open();
+      List<Account> matches = db.accounts().byPreferredEmail(email).toList();
-      try {
+      return matches.size() == 1 ? auth(matches.get(0)) : null;
-        List<Account> matches = db.accounts().byPreferredEmail(email).toList();
-        return matches.size() == 1 ? auth(matches.get(0)) : null;
-      } finally {
-        db.close();
-      }
     } catch (OrmException e) {
       getServletContext().log("cannot query database", e);
       return null;
@@ -227,13 +211,8 @@ class BecomeAnyAccountLoginServlet extends HttpServlet {
     } catch (NumberFormatException nfe) {
       return null;
     }
-    try {
+    try (ReviewDb db = schema.open()) {
-      final ReviewDb db = schema.open();
+      return auth(db.accounts().get(id));
-      try {
-        return auth(db.accounts().get(id));
-      } finally {
-        db.close();
-      }
     } catch (OrmException e) {
       getServletContext().log("cannot query database", e);
       return null;

gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/container/HttpAuthFilter.java

@@ -111,11 +111,8 @@ class HttpAuthFilter implements Filter {
       rsp.setContentType("text/html");
       rsp.setCharacterEncoding(HtmlDomUtil.ENC.name());
       rsp.setContentLength(tosend.length);
-      final OutputStream out = rsp.getOutputStream();
+      try (OutputStream out = rsp.getOutputStream()) {
-      try {
         out.write(tosend);
-      } finally {
-        out.close();
       }
     }
   }

gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/container/HttpLoginServlet.java

@@ -104,12 +104,8 @@ class HttpLoginServlet extends HttpServlet {
       rsp.setContentType("text/html");
       rsp.setCharacterEncoding("UTF-8");
       rsp.setContentLength(bin.length);
-      final ServletOutputStream out = rsp.getOutputStream();
+      try (ServletOutputStream out = rsp.getOutputStream()) {
-      try {
         out.write(bin);
-      } finally {
-        out.flush();
-        out.close();
       }
       return;
     }

gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/ldap/LdapLoginServlet.java

@@ -92,11 +92,8 @@ class LdapLoginServlet extends HttpServlet {
     res.setContentType("text/html");
     res.setCharacterEncoding("UTF-8");
     res.setContentLength(bin.length);
-    ServletOutputStream out = res.getOutputStream();
+    try (ServletOutputStream out = res.getOutputStream()) {
-    try {
       out.write(bin);
-    } finally {
-      out.close();
     }
   }
 

gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitLogoServlet.java

@@ -72,11 +72,8 @@ class GitLogoServlet extends HttpServlet {
       rsp.setDateHeader("Last-Modified", modified);
       CacheHeaders.setCacheable(req, rsp, 5, TimeUnit.MINUTES);
 
-      final ServletOutputStream os = rsp.getOutputStream();
+      try (ServletOutputStream os = rsp.getOutputStream()) {
-      try {
         os.write(raw);
-      } finally {
-        os.close();
       }
     } else {
       CacheHeaders.setNotCacheable(rsp);

gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitwebCssServlet.java

@@ -101,11 +101,8 @@ abstract class GitwebCssServlet extends HttpServlet {
       rsp.setDateHeader("Last-Modified", modified);
       CacheHeaders.setCacheable(req, rsp, 5, TimeUnit.MINUTES);
 
-      final ServletOutputStream os = rsp.getOutputStream();
+      try (ServletOutputStream os = rsp.getOutputStream()) {
-      try {
         os.write(toSend);
-      } finally {
-        os.close();
       }
     } else {
       CacheHeaders.setNotCacheable(rsp);

gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitwebJavaScriptServlet.java

@@ -72,11 +72,8 @@ class GitwebJavaScriptServlet extends HttpServlet {
       rsp.setDateHeader("Last-Modified", modified);
       CacheHeaders.setCacheable(req, rsp, 5, TimeUnit.MINUTES);
 
-      final ServletOutputStream os = rsp.getOutputStream();
+      try (ServletOutputStream os = rsp.getOutputStream()) {
-      try {
         os.write(raw);
-      } finally {
-        os.close();
       }
     } else {
       CacheHeaders.setNotCacheable(rsp);

gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitwebServlet.java

@@ -414,19 +414,14 @@ class GitwebServlet extends HttpServlet {
       return;
     }
 
-    final Repository repo;
+
-    try {
+    try (@SuppressWarnings("UnusedDeclaration") // only open for existence-check
-      repo = repoManager.openRepository(nameKey);
+         Repository repo = repoManager.openRepository(nameKey)) {
+      CacheHeaders.setNotCacheable(rsp);
+      exec(req, rsp, project);
     } catch (RepositoryNotFoundException e) {
       getServletContext().log("Cannot open repository", e);
       rsp.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
-      return;
-    }
-    try {
-      CacheHeaders.setNotCacheable(rsp);
-      exec(req, rsp, project);
-    } finally {
-      repo.close();
     }
   }
 
@@ -476,25 +471,15 @@ class GitwebServlet extends HttpServlet {
       proc.getOutputStream().close();
     }
 
-    try {
+    try (InputStream in = new BufferedInputStream(proc.getInputStream(), bufferSize)) {
-      final InputStream in;
+      readCgiHeaders(rsp, in);
 
-      in = new BufferedInputStream(proc.getInputStream(), bufferSize);
+      try (OutputStream out = rsp.getOutputStream()) {
-      try {
+        final byte[] buf = new byte[bufferSize];
-        readCgiHeaders(rsp, in);
+        int n;
-
+        while ((n = in.read(buf)) > 0) {
-        final OutputStream out = rsp.getOutputStream();
+          out.write(buf, 0, n);
-        try {
-          final byte[] buf = new byte[bufferSize];
-          int n;
-          while ((n = in.read(buf)) > 0) {
-            out.write(buf, 0, n);
-          }
-        } finally {
-          out.close();
         }
-      } finally {
-        in.close();
       }
     } catch (IOException e) {
       // The browser has probably closed its input stream. We don't
@@ -651,16 +636,11 @@ class GitwebServlet extends HttpServlet {
     new Thread(new Runnable() {
       @Override
       public void run() {
-        try {
+        try (BufferedReader br =
-          final BufferedReader br =
+            new BufferedReader(new InputStreamReader(in, "ISO-8859-1"))) {
-              new BufferedReader(new InputStreamReader(in, "ISO-8859-1"));
+          String line;
-          try {
+          while ((line = br.readLine()) != null) {
-            String line;
+            log.error("CGI: " + line);
-            while ((line = br.readLine()) != null) {
-              log.error("CGI: " + line);
-            }
-          } finally {
-            br.close();
           }
         } catch (IOException e) {
           log.debug("Unexpected error copying stderr from CGI", e);

gerrit-httpd/src/main/java/com/google/gerrit/httpd/plugins/HttpPluginServlet.java

@@ -411,18 +411,18 @@ class HttpPluginServlet extends HttpServlet
 
     if (about != null) {
       InputStreamReader isr = new InputStreamReader(scanner.getInputStream(about));
-      BufferedReader reader = new BufferedReader(isr);
       StringBuilder aboutContent = new StringBuilder();
-      String line;
+      try (BufferedReader reader = new BufferedReader(isr)) {
-      while ((line = reader.readLine()) != null) {
+        String line;
-        line = line.trim();
+        while ((line = reader.readLine()) != null) {
-        if (line.isEmpty()) {
+          line = line.trim();
-          aboutContent.append("\n");
+          if (line.isEmpty()) {
-        } else {
+            aboutContent.append("\n");
-          aboutContent.append(line).append("\n");
+          } else {
+            aboutContent.append(line).append("\n");
+          }
         }
       }
-      reader.close();
 
       // Only append the About section if there was anything in it
       if (aboutContent.toString().trim().length() > 0) {
@@ -641,11 +641,8 @@ class HttpPluginServlet extends HttpServlet
   private static byte[] readWholeEntry(PluginContentScanner scanner, PluginEntry entry)
       throws IOException {
     byte[] data = new byte[entry.getSize().get().intValue()];
-    InputStream in = scanner.getInputStream(entry);
+    try (InputStream in = scanner.getInputStream(entry)) {
-    try {
       IO.readFully(in, data, 0, data.length);
-    } finally {
-      in.close();
     }
     return data;
   }

gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/HostPageServlet.java

@@ -128,25 +128,20 @@ public class HostPageServlet extends HttpServlet {
     }
 
     String src = "gerrit_ui/gerrit_ui.nocache.js";
-    InputStream in = servletContext.getResourceAsStream("/" + src);
+    try (InputStream in = servletContext.getResourceAsStream("/" + src)) {
-    if (in != null) {
+      if (in != null) {
-      Hasher md = Hashing.md5().newHasher();
+        Hasher md = Hashing.md5().newHasher();
-      try {
+        final byte[] buf = new byte[1024];
-        try {
+        int n;
-          final byte[] buf = new byte[1024];
+        while ((n = in.read(buf)) > 0) {
-          int n;
+          md.putBytes(buf, 0, n);
-          while ((n = in.read(buf)) > 0) {
-            md.putBytes(buf, 0, n);
-          }
-        } finally {
-          in.close();
         }
-      } catch (IOException e) {
+        src += "?content=" + md.hash().toString();
-        throw new IOException("Failed reading " + src, e);
+      } else {
+        log.debug("No " + src + " in webapp root; keeping noncache.js URL");
       }
-      src += "?content=" + md.hash().toString();
+    } catch (IOException e) {
-    } else {
+      throw new IOException("Failed reading " + src, e);
-      log.debug("No " + src + " in webapp root; keeping noncache.js URL");
     }
 
     noCacheName = src;
@@ -224,11 +219,8 @@ public class HostPageServlet extends HttpServlet {
     rsp.setContentType("text/html");
     rsp.setCharacterEncoding(HtmlDomUtil.ENC.name());
     rsp.setContentLength(tosend.length);
-    final OutputStream out = rsp.getOutputStream();
+    try (OutputStream out = rsp.getOutputStream()) {
-    try {
       out.write(tosend);
-    } finally {
-      out.close();
     }
   }
 

gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/LegacyGerritServlet.java

@@ -70,11 +70,8 @@ public class LegacyGerritServlet extends HttpServlet {
     rsp.setContentType("text/html");
     rsp.setCharacterEncoding(HtmlDomUtil.ENC.name());
     rsp.setContentLength(tosend.length);
-    final OutputStream out = rsp.getOutputStream();
+    try (OutputStream out = rsp.getOutputStream()) {
-    try {
       out.write(tosend);
-    } finally {
-      out.close();
     }
   }
 }

gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/SshInfoServlet.java

@@ -90,11 +90,8 @@ public class SshInfoServlet extends HttpServlet {
     CacheHeaders.setNotCacheable(rsp);
     rsp.setCharacterEncoding("UTF-8");
     rsp.setContentType("text/plain");
-    final PrintWriter w = rsp.getWriter();
+    try (PrintWriter w = rsp.getWriter()) {
-    try {
       w.write(out);
-    } finally {
-      w.close();
     }
   }
 }

gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/StaticServlet.java

@@ -199,11 +199,8 @@ public class StaticServlet extends HttpServlet {
     rsp.setHeader(ETAG, r.etag);
     rsp.setContentType(r.contentType);
     rsp.setContentLength(tosend.length);
-    final OutputStream out = rsp.getOutputStream();
+    try (OutputStream out = rsp.getOutputStream()) {
-    try {
       out.write(tosend);
-    } finally {
-      out.close();
     }
   }
 

gerrit-httpd/src/main/java/com/google/gerrit/httpd/raw/ToolServlet.java

@@ -82,11 +82,8 @@ public class ToolServlet extends HttpServlet {
     rsp.setHeader(HDR_CACHE_CONTROL, "no-cache, must-revalidate");
     rsp.setContentType("application/octet-stream");
     rsp.setContentLength(tosend.length);
-    final OutputStream out = rsp.getOutputStream();
+    try (OutputStream out = rsp.getOutputStream()) {
-    try {
       out.write(tosend);
-    } finally {
-      out.close();
     }
   }
 
@@ -148,11 +145,8 @@ public class ToolServlet extends HttpServlet {
     rsp.setContentType("text/html");
     rsp.setCharacterEncoding("UTF-8");
     rsp.setContentLength(tosend.length);
-    final OutputStream out = rsp.getOutputStream();
+    try (OutputStream out = rsp.getOutputStream()) {
-    try {
       out.write(tosend);
-    } finally {
-      out.close();
     }
   }
 }

gerrit-httpd/src/main/java/com/google/gerrit/httpd/restapi/RestApiServlet.java

@@ -522,8 +522,7 @@ public class RestApiServlet extends HttpServlet {
       IllegalArgumentException, NoSuchMethodException, IllegalAccessException,
       InstantiationException, InvocationTargetException, MethodNotAllowedException {
     if (isType(JSON_TYPE, req.getContentType())) {
-      BufferedReader br = req.getReader();
+      try (BufferedReader br = req.getReader()) {
-      try {
         JsonReader json = new JsonReader(br);
         json.setLenient(true);
 
@@ -537,8 +536,6 @@ public class RestApiServlet extends HttpServlet {
           return parseString(json.nextString(), type);
         }
         return OutputFormat.JSON.newGson().fromJson(json, type);
-      } finally {
-        br.close();
       }
     } else if (("PUT".equals(req.getMethod()) || "POST".equals(req.getMethod()))
         && acceptsRawInput(type)) {
@@ -548,8 +545,7 @@ public class RestApiServlet extends HttpServlet {
     } else if (hasNoBody(req)) {
       return createInstance(type);
     } else if (isType("text/plain", req.getContentType())) {
-      BufferedReader br = req.getReader();
+      try (BufferedReader br = req.getReader()) {
-      try {
         char[] tmp = new char[256];
         StringBuilder sb = new StringBuilder();
         int n;
@@ -557,8 +553,6 @@ public class RestApiServlet extends HttpServlet {
           sb.append(tmp, 0, n);
         }
         return parseString(sb.toString(), type);
-      } finally {
-        br.close();
       }
     } else if ("POST".equals(req.getMethod())
         && isType(FORM_TYPE, req.getContentType())) {
@@ -772,11 +766,8 @@ public class RestApiServlet extends HttpServlet {
       }
 
       if (req == null || !"HEAD".equals(req.getMethod())) {
-        OutputStream dst = res.getOutputStream();
+        try (OutputStream dst = res.getOutputStream()) {
-        try {
           bin.writeTo(dst);
-        } finally {
-          dst.close();
         }
       }
     } finally {
@@ -1078,9 +1069,9 @@ public class RestApiServlet extends HttpServlet {
   private static BinaryResult compress(BinaryResult bin)
       throws IOException {
     TemporaryBuffer.Heap buf = heap(HEAP_EST_SIZE, 20 << 20);
-    GZIPOutputStream gz = new GZIPOutputStream(buf);
+    try (GZIPOutputStream gz = new GZIPOutputStream(buf)) {
-    bin.writeTo(gz);
+      bin.writeTo(gz);
-    gz.close();
+    }
     return asBinaryResult(buf).setContentType(bin.getContentType());
   }
 

gerrit-launcher/src/main/java/com/google/gerrit/launcher/GerritLauncher.java

@@ -102,16 +102,11 @@ public final class GerritLauncher {
       return "";
     }
 
-    try {
+    try (JarFile jar = new JarFile(me)) {
-      final JarFile jar = new JarFile(me);
+      Manifest mf = jar.getManifest();
-      try {
+      Attributes att = mf.getMainAttributes();
-        Manifest mf = jar.getManifest();
+      String val = att.getValue(Attributes.Name.IMPLEMENTATION_VERSION);
-        Attributes att = mf.getMainAttributes();
+      return val != null ? val : "";
-        String val = att.getValue(Attributes.Name.IMPLEMENTATION_VERSION);
-        return val != null ? val : "";
-      } finally {
-        jar.close();
-      }
     } catch (IOException e) {
       return "";
     }
@@ -202,28 +197,23 @@ public final class GerritLauncher {
     }
 
     final SortedMap<String, URL> jars = new TreeMap<>();
-    try {
+    try (ZipFile zf = new ZipFile(path)) {
-      final ZipFile zf = new ZipFile(path);
+      final Enumeration<? extends ZipEntry> e = zf.entries();
-      try {
+      while (e.hasMoreElements()) {
-        final Enumeration<? extends ZipEntry> e = zf.entries();
+        final ZipEntry ze = e.nextElement();
-        while (e.hasMoreElements()) {
+        if (ze.isDirectory()) {
-          final ZipEntry ze = e.nextElement();
+          continue;
-          if (ze.isDirectory()) {
+        }
-            continue;
-          }
 
-          String name = ze.getName();
+        String name = ze.getName();
-          if (name.startsWith("WEB-INF/lib/")) {
+        if (name.startsWith("WEB-INF/lib/")) {
+          extractJar(zf, ze, jars);
+        } else if (name.startsWith("WEB-INF/pgm-lib/")) {
+          // Some Prolog tools are restricted.
+          if (prologCompiler || !name.startsWith("WEB-INF/pgm-lib/prolog-")) {
             extractJar(zf, ze, jars);
-          } else if (name.startsWith("WEB-INF/pgm-lib/")) {
-            // Some Prolog tools are restricted.
-            if (prologCompiler || !name.startsWith("WEB-INF/pgm-lib/prolog-")) {
-              extractJar(zf, ze, jars);
-            }
           }
         }
-      } finally {
-        zf.close();
       }
     } catch (IOException e) {
       throw new IOException("Cannot obtain libraries from " + path, e);
@@ -257,20 +247,13 @@ public final class GerritLauncher {
   private static void extractJar(ZipFile zf, ZipEntry ze,
       SortedMap<String, URL> jars) throws IOException {
     File tmp = createTempFile(safeName(ze), ".jar");
-    FileOutputStream out = new FileOutputStream(tmp);
+    try (FileOutputStream out = new FileOutputStream(tmp);
-    try {
+        InputStream in = zf.getInputStream(ze)) {
-      InputStream in = zf.getInputStream(ze);
+      byte[] buf = new byte[4096];
-      try {
+      int n;
-        byte[] buf = new byte[4096];
+      while ((n = in.read(buf, 0, buf.length)) > 0) {
-        int n;
+        out.write(buf, 0, n);
-        while ((n = in.read(buf, 0, buf.length)) > 0) {
-          out.write(buf, 0, n);
-        }
-      } finally {
-        in.close();
       }
-    } finally {
-      out.close();
     }
 
     String name = ze.getName();
@@ -363,24 +346,16 @@ public final class GerritLauncher {
     final CodeSource src =
         GerritLauncher.class.getProtectionDomain().getCodeSource();
     if (src != null) {
-      try {
+      try (InputStream in = src.getLocation().openStream()) {
-        final InputStream in = src.getLocation().openStream();
+        final File tmp = createTempFile("gerrit_", ".zip");
-        try {
+        try (FileOutputStream out = new FileOutputStream(tmp)) {
-          final File tmp = createTempFile("gerrit_", ".zip");
+          final byte[] buf = new byte[4096];
-          final FileOutputStream out = new FileOutputStream(tmp);
+          int n;
-          try {
+          while ((n = in.read(buf, 0, buf.length)) > 0) {
-            final byte[] buf = new byte[4096];
+            out.write(buf, 0, n);
-            int n;
-            while ((n = in.read(buf, 0, buf.length)) > 0) {
-              out.write(buf, 0, n);
-            }
-          } finally {
-            out.close();
           }
-          return tmp;
-        } finally {
-          in.close();
         }
+        return tmp;
       } catch (IOException e) {
         // Nope, that didn't work.
         //

gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/LoginForm.java

@@ -319,11 +319,8 @@ class LoginForm extends HttpServlet {
     res.setContentType("text/html");
     res.setCharacterEncoding("UTF-8");
     res.setContentLength(bin.length);
-    ServletOutputStream out = res.getOutputStream();
+    try (ServletOutputStream out = res.getOutputStream()) {
-    try {
       out.write(bin);
-    } finally {
-      out.close();
     }
   }
 

gerrit-openid/src/main/java/com/google/gerrit/httpd/auth/openid/XrdsServlet.java

@@ -63,11 +63,8 @@ class XrdsServlet extends HttpServlet {
     rsp.setContentType("application/xrds+xml");
     rsp.setCharacterEncoding(ENC);
 
-    final ServletOutputStream out = rsp.getOutputStream();
+    try (ServletOutputStream out = rsp.getOutputStream()) {
-    try {
       out.write(raw);
-    } finally {
-      out.close();
     }
   }
 }

gerrit-pgm/src/main/java/com/google/gerrit/pgm/Cat.java

@@ -40,13 +40,12 @@ public class Cat extends AbstractProgram {
       name = "WEB-INF/" + fileName;
     }
 
-    final InputStream in = open(name);
+    try (InputStream in = open(name)) {
-    if (in == null) {
+      if (in == null) {
-      System.err.println("error: no such file " + fileName);
+        System.err.println("error: no such file " + fileName);
-      return 1;
+        return 1;
-    }
+      }
 
-    try {
       try {
         final byte[] buf = new byte[4096];
         int n;
@@ -56,8 +55,6 @@ public class Cat extends AbstractProgram {
       } finally {
         System.out.flush();
       }
-    } finally {
-      in.close();
     }
     return 0;
   }

gerrit-pgm/src/main/java/com/google/gerrit/pgm/LocalUsernamesToLowerCase.java

@@ -60,14 +60,11 @@ public class LocalUsernamesToLowerCase extends SiteProgram {
     manager.start();
     dbInjector.injectMembers(this);
 
-    final ReviewDb db = database.open();
+    try (ReviewDb db = database.open()) {
-    try {
       todo = db.accountExternalIds().all().toList();
       synchronized (monitor) {
         monitor.beginTask("Converting local username", todo.size());
       }
-    } finally {
-      db.close();
     }
 
     final List<Worker> workers = new ArrayList<>(threads);

gerrit-pgm/src/main/java/com/google/gerrit/pgm/Ls.java

@@ -26,8 +26,7 @@ import java.util.zip.ZipFile;
 public class Ls extends AbstractProgram {
   @Override
   public int run() throws IOException {
-    final ZipFile zf = new ZipFile(GerritLauncher.getDistributionArchive());
+    try (ZipFile zf = new ZipFile(GerritLauncher.getDistributionArchive())) {
-    try {
       final Enumeration<? extends ZipEntry> e = zf.entries();
       while (e.hasMoreElements()) {
         final ZipEntry ze = e.nextElement();
@@ -48,8 +47,6 @@ public class Ls extends AbstractProgram {
           System.out.println(name);
         }
       }
-    } finally {
-      zf.close();
     }
     return 0;
   }

gerrit-pgm/src/main/java/com/google/gerrit/pgm/ProtoGen.java

@@ -47,14 +47,11 @@ public class ProtoGen extends AbstractProgram {
           PrintWriter out = new PrintWriter(
               new BufferedWriter(new OutputStreamWriter(o, "UTF-8")))) {
         String header;
-        InputStream in = getClass().getResourceAsStream("ProtoGenHeader.txt");
+        try (InputStream in = getClass().getResourceAsStream("ProtoGenHeader.txt")) {
-        try {
           ByteBuffer buf = IO.readWholeStream(in, 1024);
           int ptr = buf.arrayOffset() + buf.position();
           int len = buf.remaining();
           header = new String(buf.array(), ptr, len, "UTF-8");
-        } finally {
-          in.close();
         }
 
         String version = com.google.gerrit.common.Version.getVersion();

gerrit-pgm/src/main/java/com/google/gerrit/pgm/ProtobufImport.java

@@ -92,11 +92,9 @@ public class ProtobufImport extends SiteProgram {
     });
     dbInjector.injectMembers(this);
 
-    ReviewDb db = schemaFactory.open();
-
     ProgressMonitor progress = new TextProgressMonitor();
     progress.beginTask("Importing entities", ProgressMonitor.UNKNOWN);
-    try {
+    try (ReviewDb db = schemaFactory.open()) {
       for (RelationModel model
           : new JavaSchemaModel(ReviewDb.class).getRelations()) {
         relations.put(model.getRelationID(), Relation.create(model, db));
@@ -119,8 +117,6 @@ public class ProtobufImport extends SiteProgram {
         }
       }
       progress.endTask();
-    } finally {
-      db.close();
     }
 
     return 0;

gerrit-pgm/src/main/java/com/google/gerrit/pgm/RebuildNotedb.java

@@ -113,13 +113,11 @@ public class RebuildNotedb extends SiteProgram {
         sysInjector.getInstance(GitRepositoryManager.class);
     final Project.NameKey allUsersName =
         sysInjector.getInstance(AllUsersName.class);
-    final Repository allUsersRepo =
+    try (Repository allUsersRepo =
-        repoManager.openMetadataRepository(allUsersName);
+        repoManager.openMetadataRepository(allUsersName)) {
-    try {
       deleteDraftRefs(allUsersRepo);
       for (final Project.NameKey project : changesByProject.keySet()) {
-        final Repository repo = repoManager.openMetadataRepository(project);
+        try (Repository repo = repoManager.openMetadataRepository(project)) {
-        try {
           final BatchRefUpdate bru = repo.getRefDatabase().newBatchUpdate();
           final BatchRefUpdate bruForDrafts =
               allUsersRepo.getRefDatabase().newBatchUpdate();
@@ -158,12 +156,8 @@ public class RebuildNotedb extends SiteProgram {
           log.error("Error rebuilding notedb", e);
           ok.set(false);
           break;
-        } finally {
-          repo.close();
         }
       }
-    } finally {
-      allUsersRepo.close();
     }
 
     double t = sw.elapsed(TimeUnit.MILLISECONDS) / 1000d;
@@ -231,16 +225,13 @@ public class RebuildNotedb extends SiteProgram {
     // rebuilder threads to use the full connection pool.
     SchemaFactory<ReviewDb> schemaFactory = sysInjector.getInstance(Key.get(
         new TypeLiteral<SchemaFactory<ReviewDb>>() {}));
-    ReviewDb db = schemaFactory.open();
     Multimap<Project.NameKey, Change> changesByProject =
         ArrayListMultimap.create();
-    try {
+    try (ReviewDb db = schemaFactory.open()) {
       for (Change c : db.changes().all()) {
         changesByProject.put(c.getProject(), c);
       }
       return changesByProject;
-    } finally {
-      db.close();
     }
   }
 

gerrit-pgm/src/main/java/com/google/gerrit/pgm/Reindex.java

@@ -149,21 +149,18 @@ public class Reindex extends SiteProgram {
   }
 
   private int indexAll() throws Exception {
-    ReviewDb db = sysInjector.getInstance(ReviewDb.class);
     ProgressMonitor pm = new TextProgressMonitor();
     pm.start(1);
     pm.beginTask("Collecting projects", ProgressMonitor.UNKNOWN);
     Set<Project.NameKey> projects = Sets.newTreeSet();
     int changeCount = 0;
-    try {
+    try (ReviewDb db = sysInjector.getInstance(ReviewDb.class)) {
       for (Change change : db.changes().all()) {
         changeCount++;
         if (projects.add(change.getProject())) {
           pm.update(1);
         }
       }
-    } finally {
-      db.close();
     }
     pm.endTask();
 

gerrit-pgm/src/main/java/com/google/gerrit/pgm/Rulec.java

@@ -81,8 +81,7 @@ public class Rulec extends SiteProgram {
 
     boolean error = false;
     for (Project.NameKey project : names) {
-      Repository git = gitManager.openRepository(project);
+      try (Repository git = gitManager.openRepository(project)) {
-      try {
         switch (jarFactory.create(git).call()) {
           case NO_RULES:
             if (!all || projectNames.contains(project.get())) {
@@ -105,8 +104,6 @@ public class Rulec extends SiteProgram {
           System.err.println("fatal: " + err.getMessage());
         }
         error = true;
-      } finally {
-        git.close();
       }
     }
 

gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/HiddenErrorHandler.java

@@ -56,11 +56,8 @@ class HiddenErrorHandler extends ErrorHandler {
     try {
       CacheHeaders.setNotCacheable(res);
     } finally {
-      ServletOutputStream out = res.getOutputStream();
+      try (ServletOutputStream out = res.getOutputStream()) {
-      try {
         out.write(msg);
-      } finally {
-        out.close();
       }
     }
   }

gerrit-pgm/src/main/java/com/google/gerrit/pgm/http/jetty/JettyServer.java

@@ -520,8 +520,7 @@ public class JettyServer {
   }
 
   private static void unpack(File srcwar, File dstwar) throws IOException {
-    final ZipFile zf = new ZipFile(srcwar);
+    try (ZipFile zf = new ZipFile(srcwar)) {
-    try {
       final Enumeration<? extends ZipEntry> e = zf.entries();
       while (e.hasMoreElements()) {
         final ZipEntry ze = e.nextElement();
@@ -539,24 +538,15 @@ public class JettyServer {
         mkdir(rawtmp.getParentFile());
         rawtmp.deleteOnExit();
 
-        final FileOutputStream rawout = new FileOutputStream(rawtmp);
+        try (FileOutputStream rawout = new FileOutputStream(rawtmp);
-        try {
+            InputStream in = zf.getInputStream(ze)) {
-          final InputStream in = zf.getInputStream(ze);
+          final byte[] buf = new byte[4096];
-          try {
+          int n;
-            final byte[] buf = new byte[4096];
+          while ((n = in.read(buf, 0, buf.length)) > 0) {
-            int n;
+            rawout.write(buf, 0, n);
-            while ((n = in.read(buf, 0, buf.length)) > 0) {
-              rawout.write(buf, 0, n);
-            }
-          } finally {
-            in.close();
           }
-        } finally {
-          rawout.close();
         }
       }
-    } finally {
-      zf.close();
     }
   }
 
@@ -632,14 +622,14 @@ public class JettyServer {
         CacheHeaders.setNotCacheable(res);
 
         Escaper html = HtmlEscapers.htmlEscaper();
-        PrintWriter w = res.getWriter();
+        try (PrintWriter w = res.getWriter()) {
-        w.write("<html><title>BUILD FAILED</title><body>");
+          w.write("<html><title>BUILD FAILED</title><body>");
-        w.format("<h1>%s FAILED</h1>", html.escape(rule));
+          w.format("<h1>%s FAILED</h1>", html.escape(rule));
-        w.write("<pre>");
+          w.write("<pre>");
-        w.write(html.escape(RawParseUtils.decode(why)));
+          w.write(html.escape(RawParseUtils.decode(why)));
-        w.write("</pre>");
+          w.write("</pre>");
-        w.write("</body></html>");
+          w.write("</body></html>");
-        w.close();
+        }
       }
 
       @Override
@@ -667,12 +657,10 @@ public class JettyServer {
     long start = TimeUtil.nowMs();
     Process rebuild = proc.start();
     byte[] out;
-    InputStream in = rebuild.getInputStream();
+    try (InputStream in = rebuild.getInputStream()) {
-    try {
       out = ByteStreams.toByteArray(in);
     } finally {
       rebuild.getOutputStream().close();
-      in.close();
     }
 
     int status;
@@ -692,12 +680,9 @@ public class JettyServer {
   private static Properties loadBuckProperties(File gen)
       throws FileNotFoundException, IOException {
     Properties properties = new Properties();
-    InputStream in = new FileInputStream(
+    try (InputStream in = new FileInputStream(
-        new File(new File(gen, "tools"), "buck.properties"));
+        new File(new File(gen, "tools"), "buck.properties"))) {
-    try {
       properties.load(in);
-    } finally {
-      in.close();
     }
     return properties;
   }

gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/InitAdminUser.java

@@ -68,8 +68,7 @@ public class InitAdminUser implements InitStep {
       return;
     }
 
-    ReviewDb db = dbFactory.open();
+    try (ReviewDb db = dbFactory.open()) {
-    try {
       if (db.accounts().anyAccounts().toList().isEmpty()) {
         ui.header("Gerrit Administrator");
         if (ui.yesno(true, "Create administrator user")) {
@@ -111,8 +110,6 @@ public class InitAdminUser implements InitStep {
           }
         }
       }
-    } finally {
-      db.close();
     }
   }
 

gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/InitPlugins.java

@@ -171,13 +171,10 @@ public class InitPlugins implements InitStep {
   }
 
   private static String getVersion(Path plugin) throws IOException {
-    JarFile jarFile = new JarFile(plugin.toFile());
+    try (JarFile jarFile = new JarFile(plugin.toFile())) {
-    try {
       Manifest manifest = jarFile.getManifest();
       Attributes main = manifest.getMainAttributes();
       return main.getValue(Attributes.Name.IMPLEMENTATION_VERSION);
-    } finally {
-      jarFile.close();
     }
   }
 }

gerrit-pgm/src/main/java/com/google/gerrit/pgm/init/api/AllProjectsConfig.java

@@ -79,11 +79,8 @@ public class AllProjectsConfig extends VersionedMetaData {
   public AllProjectsConfig load() throws IOException, ConfigInvalidException {
     File path = getPath();
     if (path != null) {
-      Repository repo = new FileRepository(path);
+      try (Repository repo = new FileRepository(path)) {
-      try {
         load(repo);
-      } finally {
-        repo.close();
       }
     }
     return this;

gerrit-pgm/src/main/java/com/google/gerrit/pgm/rules/PrologCompiler.java

@@ -139,11 +139,8 @@ public class PrologCompiler implements Callable<PrologCompiler.Status> {
     // Any leak of tmp caused by this method failing will be cleaned
     // up by our caller when tempDir is recursively deleted.
     File tmp = File.createTempFile("rules", ".pl", tempDir);
-    FileOutputStream out = new FileOutputStream(tmp);
+    try (FileOutputStream out = new FileOutputStream(tmp)) {
-    try {
       git.open(blobId).copyTo(out);
-    } finally {
-      out.close();
     }
     return tmp;
   }
@@ -157,9 +154,8 @@ public class PrologCompiler implements Callable<PrologCompiler.Status> {
 
     DiagnosticCollector<JavaFileObject> diagnostics =
         new DiagnosticCollector<>();
-    StandardJavaFileManager fileManager =
+    try (StandardJavaFileManager fileManager =
-        compiler.getStandardFileManager(diagnostics, null, null);
+        compiler.getStandardFileManager(diagnostics, null, null)) {
-    try {
       Iterable<? extends JavaFileObject> compilationUnits = fileManager
         .getJavaFileObjectsFromFiles(getAllFiles(tempDir, ".java"));
       ArrayList<String> options = new ArrayList<>();
@@ -195,8 +191,6 @@ public class PrologCompiler implements Callable<PrologCompiler.Status> {
         }
         throw new CompileException(msg.toString());
       }
-    } finally {
-      fileManager.close();
     }
   }
 
@@ -247,8 +241,7 @@ public class PrologCompiler implements Callable<PrologCompiler.Status> {
         jarAdd.setTime(now);
         out.putNextEntry(jarAdd);
         if (f.isFile()) {
-          FileInputStream in = new FileInputStream(f);
+          try (FileInputStream in = new FileInputStream(f)) {
-          try {
             while (true) {
               int nRead = in.read(buffer, 0, buffer.length);
               if (nRead <= 0) {
@@ -256,8 +249,6 @@ public class PrologCompiler implements Callable<PrologCompiler.Status> {
               }
               out.write(buffer, 0, nRead);
             }
-          } finally {
-            in.close();
           }
         }
         out.closeEntry();

gerrit-server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java

@@ -943,15 +943,10 @@ public class ChangeHookRunner implements ChangeHooks, EventDispatcher,
 
         ps = pb.start();
         ps.getOutputStream().close();
-        InputStream is = ps.getInputStream();
         String output = null;
-        try {
+        try (InputStream is = ps.getInputStream()) {
           output = readOutput(is);
         } finally {
-          try {
-            is.close();
-          } catch (IOException closeErr) {
-          }
           ps.waitFor();
           result = new HookResult(ps.exitValue(), output);
         }

gerrit-server/src/main/java/com/google/gerrit/rules/RulesCache.java

@@ -265,27 +265,19 @@ public class RulesCache {
 
   private String read(Project.NameKey project, ObjectId rulesId)
       throws CompileException {
-    Repository git;
+    try (Repository git = gitMgr.openRepository(project)) {
-    try {
+      try {
-      git = gitMgr.openRepository(project);
+        ObjectLoader ldr = git.open(rulesId, Constants.OBJ_BLOB);
-    } catch (RepositoryNotFoundException e) {
+        byte[] raw = ldr.getCachedBytes(SRC_LIMIT);
-      throw new CompileException("Cannot open repository " + project, e);
+        return RawParseUtils.decode(raw);
+      } catch (LargeObjectException e) {
+        throw new CompileException("rules of " + project + " are too large", e);
+      } catch (RuntimeException | IOException e) {
+        throw new CompileException("Cannot load rules of " + project, e);
+      }
     } catch (IOException e) {
       throw new CompileException("Cannot open repository " + project, e);
     }
-    try {
-      ObjectLoader ldr = git.open(rulesId, Constants.OBJ_BLOB);
-      byte[] raw = ldr.getCachedBytes(SRC_LIMIT);
-      return RawParseUtils.decode(raw);
-    } catch (LargeObjectException e) {
-      throw new CompileException("rules of " + project + " are too large", e);
-    } catch (RuntimeException e) {
-      throw new CompileException("Cannot load rules of " + project, e);
-    } catch (IOException e) {
-      throw new CompileException("Cannot load rules of " + project, e);
-    } finally {
-      git.close();
-    }
   }
 
   private BufferingPrologControl newEmptyMachine(ClassLoader cl) {

gerrit-server/src/main/java/com/google/gerrit/server/ApprovalCopier.java

@@ -106,9 +106,8 @@ public class ApprovalCopier {
       TreeMap<Integer, PatchSet> patchSets = getPatchSets(cd);
       NavigableSet<Integer> allPsIds = patchSets.navigableKeySet();
 
-      Repository repo =
+      try (Repository repo =
-          repoManager.openRepository(project.getProject().getNameKey());
+          repoManager.openRepository(project.getProject().getNameKey())) {
-      try {
         // Walk patch sets strictly less than current in descending order.
         Collection<PatchSet> allPrior = patchSets.descendingMap()
             .tailMap(ps.getId().get(), false)
@@ -132,8 +131,6 @@ public class ApprovalCopier {
           }
         }
         return labelNormalizer.normalize(ctl, byUser.values()).getNormalized();
-      } finally {
-        repo.close();
       }
     } catch (IOException e) {
       throw new OrmException(e);

gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java

@@ -382,8 +382,7 @@ public class ChangeUtil {
       throw new NoSuchChangeException(patchSetId.getParentKey());
     }
 
-    Repository repo = gitManager.openRepository(change.getProject());
+    try (Repository repo = gitManager.openRepository(change.getProject())) {
-    try {
       RefUpdate update = repo.updateRef(patch.getRefName());
       update.setForceUpdate(true);
       update.disableRefLog();
@@ -399,8 +398,6 @@ public class ChangeUtil {
               " in " + repo.getDirectory() + ": " + update.getResult());
       }
       gitRefUpdated.fire(change.getProject(), update, ReceiveCommand.Type.DELETE);
-    } finally {
-      repo.close();
     }
 
     ReviewDb db = this.db.get();

gerrit-server/src/main/java/com/google/gerrit/server/PatchLineCommentsUtil.java

@@ -364,19 +364,11 @@ public class PatchLineCommentsUtil {
   }
 
   private Set<String> getRefNamesAllUsers(String prefix) throws OrmException {
-    Repository repo;
+    try (Repository repo = repoManager.openRepository(allUsers)) {
-    try {
-      repo = repoManager.openRepository(allUsers);
-    } catch (IOException e) {
-      throw new OrmException(e);
-    }
-    try {
       RefDatabase refDb = repo.getRefDatabase();
       return refDb.getRefs(prefix).keySet();
     } catch (IOException e) {
       throw new OrmException(e);
-    } finally {
-      repo.close();
     }
   }
 

gerrit-server/src/main/java/com/google/gerrit/server/ProjectUtil.java

@@ -39,15 +39,12 @@ public class ProjectUtil {
   public static boolean branchExists(final GitRepositoryManager repoManager,
       final Branch.NameKey branch) throws RepositoryNotFoundException,
       IOException {
-    final Repository repo = repoManager.openRepository(branch.getParentKey());
+    try (Repository repo = repoManager.openRepository(branch.getParentKey())) {
-    try {
       boolean exists = repo.getRefDatabase().exactRef(branch.get()) != null;
       if (!exists) {
         exists = repo.getFullBranch().equals(branch.get());
       }
       return exists;
-    } finally {
-      repo.close();
     }
   }
 }

gerrit-server/src/main/java/com/google/gerrit/server/account/AccountByEmailCacheImpl.java

@@ -92,8 +92,7 @@ public class AccountByEmailCacheImpl implements AccountByEmailCache {
 
     @Override
     public Set<Account.Id> load(String email) throws Exception {
-      final ReviewDb db = schema.open();
+      try (ReviewDb db = schema.open()) {
-      try {
         Set<Account.Id> r = Sets.newHashSet();
         for (Account a : db.accounts().byPreferredEmail(email)) {
           r.add(a.getId());
@@ -103,8 +102,6 @@ public class AccountByEmailCacheImpl implements AccountByEmailCache {
           r.add(a.getAccountId());
         }
         return ImmutableSet.copyOf(r);
-      } finally {
-        db.close();
       }
     }
   }

gerrit-server/src/main/java/com/google/gerrit/server/account/AccountCacheImpl.java

@@ -142,16 +142,13 @@ public class AccountCacheImpl implements AccountCache {
 
     @Override
     public AccountState load(Account.Id key) throws Exception {
-      final ReviewDb db = schema.open();
+      try (ReviewDb db = schema.open()) {
-      try {
         final AccountState state = load(db, key);
         String user = state.getUserName();
         if (user != null) {
           byName.put(user, Optional.of(state.getAccount().getId()));
         }
         return state;
-      } finally {
-        db.close();
       }
     }
 
@@ -192,8 +189,7 @@ public class AccountCacheImpl implements AccountCache {
 
     @Override
     public Optional<Account.Id> load(String username) throws Exception {
-      final ReviewDb db = schema.open();
+      try (ReviewDb db = schema.open()) {
-      try {
         final AccountExternalId.Key key = new AccountExternalId.Key( //
             AccountExternalId.SCHEME_USERNAME, //
             username);
@@ -202,8 +198,6 @@ public class AccountCacheImpl implements AccountCache {
           return Optional.of(id.getAccountId());
         }
         return Optional.absent();
-      } finally {
-        db.close();
       }
     }
   }

gerrit-server/src/main/java/com/google/gerrit/server/account/AccountManager.java

@@ -83,13 +83,10 @@ public class AccountManager {
    */
   public Account.Id lookup(String externalId) throws AccountException {
     try {
-      ReviewDb db = schema.open();
+      try (ReviewDb db = schema.open()) {
-      try {
         AccountExternalId ext =
             db.accountExternalIds().get(new AccountExternalId.Key(externalId));
         return ext != null ? ext.getAccountId() : null;
-      } finally {
-        db.close();
       }
     } catch (OrmException e) {
       throw new AccountException("Cannot lookup account " + externalId, e);
@@ -107,8 +104,7 @@ public class AccountManager {
   public AuthResult authenticate(AuthRequest who) throws AccountException {
     who = realm.authenticate(who);
     try {
-      ReviewDb db = schema.open();
+      try (ReviewDb db = schema.open()) {
-      try {
         AccountExternalId.Key key = id(who);
         AccountExternalId id = db.accountExternalIds().get(key);
         if (id == null) {
@@ -128,8 +124,6 @@ public class AccountManager {
           return new AuthResult(id.getAccountId(), key, false);
         }
 
-      } finally {
-        db.close();
       }
     } catch (OrmException e) {
       throw new AccountException("Authentication error", e);
@@ -324,8 +318,7 @@ public class AccountManager {
    */
   public AuthResult link(Account.Id to, AuthRequest who)
       throws AccountException, OrmException {
-    ReviewDb db = schema.open();
+    try (ReviewDb db = schema.open()) {
-    try {
       who = realm.link(db, to, who);
 
       AccountExternalId.Key key = id(who);
@@ -357,8 +350,6 @@ public class AccountManager {
 
       return new AuthResult(to, key, false);
 
-    } finally {
-      db.close();
     }
   }
 
@@ -377,8 +368,7 @@ public class AccountManager {
    */
   public AuthResult updateLink(Account.Id to, AuthRequest who) throws OrmException,
       AccountException {
-    ReviewDb db = schema.open();
+    try (ReviewDb db = schema.open()) {
-    try {
       AccountExternalId.Key key = id(who);
       List<AccountExternalId.Key> filteredKeysByScheme =
           filterKeysByScheme(key.getScheme(), db.accountExternalIds()
@@ -390,8 +380,6 @@ public class AccountManager {
       }
       byIdCache.evict(to);
       return link(to, who);
-    } finally {
-      db.close();
     }
   }
 
@@ -417,8 +405,7 @@ public class AccountManager {
    */
   public AuthResult unlink(Account.Id from, AuthRequest who)
       throws AccountException, OrmException {
-    ReviewDb db = schema.open();
+    try (ReviewDb db = schema.open()) {
-    try {
       who = realm.unlink(db, from, who);
 
       AccountExternalId.Key key = id(who);
@@ -446,8 +433,6 @@ public class AccountManager {
 
       return new AuthResult(from, key, false);
 
-    } finally {
-      db.close();
     }
   }
 

gerrit-server/src/main/java/com/google/gerrit/server/account/GetPreferences.java

@@ -86,14 +86,11 @@ public class GetPreferences implements RestReadView<AccountResource> {
       throw new ResourceNotFoundException();
     }
 
-    Repository git = gitMgr.openRepository(allUsersName);
+    try (Repository git = gitMgr.openRepository(allUsersName)) {
-    try {
       VersionedAccountPreferences p =
           VersionedAccountPreferences.forUser(rsrc.getUser().getAccountId());
       p.load(git);
       return new PreferenceInfo(a.getGeneralPreferences(), p, git);
-    } finally {
-      git.close();
     }
   }
 

gerrit-server/src/main/java/com/google/gerrit/server/account/GroupCacheImpl.java

@@ -152,13 +152,8 @@ public class GroupCacheImpl implements GroupCache {
 
   @Override
   public Iterable<AccountGroup> all() {
-    try {
+    try (ReviewDb db = schema.open()) {
-      ReviewDb db = schema.open();
+      return Collections.unmodifiableList(db.accountGroups().all().toList());
-      try {
-        return Collections.unmodifiableList(db.accountGroups().all().toList());
-      } finally {
-        db.close();
-      }
     } catch (OrmException e) {
       log.warn("Cannot list internal groups", e);
       return Collections.emptyList();
@@ -187,11 +182,8 @@ public class GroupCacheImpl implements GroupCache {
     @Override
     public Optional<AccountGroup> load(final AccountGroup.Id key)
         throws Exception {
-      final ReviewDb db = schema.open();
+      try (ReviewDb db = schema.open()) {
-      try {
         return Optional.fromNullable(db.accountGroups().get(key));
-      } finally {
-        db.close();
       }
     }
   }
@@ -207,16 +199,13 @@ public class GroupCacheImpl implements GroupCache {
     @Override
     public Optional<AccountGroup> load(String name)
         throws Exception {
-      final ReviewDb db = schema.open();
+      try (ReviewDb db = schema.open()) {
-      try {
         AccountGroup.NameKey key = new AccountGroup.NameKey(name);
         AccountGroupName r = db.accountGroupNames().get(key);
         if (r != null) {
           return Optional.fromNullable(db.accountGroups().get(r.getId()));
         }
         return Optional.absent();
-      } finally {
-        db.close();
       }
     }
   }
@@ -232,8 +221,7 @@ public class GroupCacheImpl implements GroupCache {
     @Override
     public Optional<AccountGroup> load(String uuid)
         throws Exception {
-      final ReviewDb db = schema.open();
+      try (ReviewDb db = schema.open()) {
-      try {
         List<AccountGroup> r;
 
         r = db.accountGroups().byUUID(new AccountGroup.UUID(uuid)).toList();
@@ -244,8 +232,6 @@ public class GroupCacheImpl implements GroupCache {
         } else {
           throw new OrmDuplicateKeyException("Duplicate group UUID " + uuid);
         }
-      } finally {
-        db.close();
       }
     }
   }

gerrit-server/src/main/java/com/google/gerrit/server/account/GroupIncludeCacheImpl.java

@@ -144,8 +144,7 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache {
 
     @Override
     public Set<AccountGroup.UUID> load(AccountGroup.UUID key) throws Exception {
-      final ReviewDb db = schema.open();
+      try (ReviewDb db = schema.open()) {
-      try {
         List<AccountGroup> group = db.accountGroups().byUUID(key).toList();
         if (group.size() != 1) {
           return Collections.emptySet();
@@ -157,8 +156,6 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache {
           ids.add(agi.getIncludeUUID());
         }
         return ImmutableSet.copyOf(ids);
-      } finally {
-        db.close();
       }
     }
   }
@@ -174,8 +171,7 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache {
 
     @Override
     public Set<AccountGroup.UUID> load(AccountGroup.UUID key) throws Exception {
-      final ReviewDb db = schema.open();
+      try (ReviewDb db = schema.open()) {
-      try {
         Set<AccountGroup.Id> ids = Sets.newHashSet();
         for (AccountGroupById agi : db.accountGroupById()
             .byIncludeUUID(key)) {
@@ -187,8 +183,6 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache {
           groupArray.add(g.getGroupUUID());
         }
         return ImmutableSet.copyOf(groupArray);
-      } finally {
-        db.close();
       }
     }
   }
@@ -204,8 +198,7 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache {
 
     @Override
     public Set<AccountGroup.UUID> load(String key) throws Exception {
-      final ReviewDb db = schema.open();
+      try (ReviewDb db = schema.open()) {
-      try {
         Set<AccountGroup.UUID> ids = Sets.newHashSet();
         for (AccountGroupById agi : db.accountGroupById().all()) {
           if (!AccountGroup.isInternalGroup(agi.getIncludeUUID())) {
@@ -213,8 +206,6 @@ public class GroupIncludeCacheImpl implements GroupIncludeCache {
           }
         }
         return ImmutableSet.copyOf(ids);
-      } finally {
-        db.close();
       }
     }
   }

gerrit-server/src/main/java/com/google/gerrit/server/auth/ldap/LdapRealm.java

@@ -307,8 +307,7 @@ public class LdapRealm extends AbstractRealm {
 
     @Override
     public Optional<Account.Id> load(String username) throws Exception {
-      final ReviewDb db = schema.open();
+      try (ReviewDb db = schema.open()) {
-      try {
         final AccountExternalId extId =
             db.accountExternalIds().get(
                 new AccountExternalId.Key(SCHEME_GERRIT, username));
@@ -316,8 +315,6 @@ public class LdapRealm extends AbstractRealm {
           return Optional.of(extId.getAccountId());
         }
         return Optional.absent();
-      } finally {
-        db.close();
       }
     }
   }

gerrit-server/src/main/java/com/google/gerrit/server/change/Mergeable.java

@@ -109,8 +109,7 @@ public class Mergeable implements RestReadView<RevisionResource> {
     }
     result.submitType = rec.type;
 
-    Repository git = gitManager.openRepository(change.getProject());
+    try (Repository git = gitManager.openRepository(change.getProject())) {
-    try {
       ObjectId commit = toId(ps);
       if (commit == null) {
         result.mergeable = false;
@@ -150,8 +149,6 @@ public class Mergeable implements RestReadView<RevisionResource> {
           }
         }
       }
-    } finally {
-      git.close();
     }
     return result;
   }

gerrit-server/src/main/java/com/google/gerrit/server/change/RebaseChange.java

@@ -356,25 +356,19 @@ public class RebaseChange {
 
   public boolean canRebase(Project.NameKey project, PatchSet.Id patchSetId,
       Branch.NameKey branch) {
-    Repository git;
+    try (Repository git = gitManager.openRepository(project)) {
-    try {
+      try (RevWalk rw = new RevWalk(git)) {
-      git = gitManager.openRepository(project);
+        findBaseRevision(patchSetId, db.get(), branch, git, rw);
-    } catch (RepositoryNotFoundException err) {
+        return true;
-      return false;
+      } catch (InvalidChangeOperationException e) {
+        return false;
+      } catch (OrmException | IOException e) {
+        log.warn("Error checking if patch set " + patchSetId + " on " + branch
+            + " can be rebased", e);
+        return false;
+      }
     } catch (IOException err) {
       return false;
     }
-    try (RevWalk rw = new RevWalk(git)) {
-      findBaseRevision(patchSetId, db.get(), branch, git, rw);
-      return true;
-    } catch (InvalidChangeOperationException e) {
-      return false;
-    } catch (OrmException | IOException e) {
-      log.warn("Error checking if patch set " + patchSetId + " on " + branch
-          + " can be rebased", e);
-      return false;
-    } finally {
-      git.close();
-    }
   }
 }

gerrit-server/src/main/java/com/google/gerrit/server/config/GetPreferences.java

@@ -41,14 +41,11 @@ public class GetPreferences implements RestReadView<ConfigResource> {
   @Override
   public PreferenceInfo apply(ConfigResource rsrc)
       throws IOException, ConfigInvalidException {
-    Repository git = gitMgr.openRepository(allUsersName);
+    try (Repository git = gitMgr.openRepository(allUsersName)) {
-    try {
       VersionedAccountPreferences p =
           VersionedAccountPreferences.forDefault();
       p.load(git);
       return new PreferenceInfo(null, p, git);
-    } finally {
-      git.close();
     }
   }
 }

gerrit-server/src/main/java/com/google/gerrit/server/contact/EncryptedContactStore.java

@@ -176,11 +176,10 @@ class EncryptedContactStore implements ContactStore {
     final byte[] zText = compress(name, date, rawText);
 
     final ByteArrayOutputStream buf = new ByteArrayOutputStream();
-    final ArmoredOutputStream aout = new ArmoredOutputStream(buf);
+    try (ArmoredOutputStream aout = new ArmoredOutputStream(buf);
-    final OutputStream cout = cpk().open(aout, zText.length);
+        OutputStream cout = cpk().open(aout, zText.length)) {
-    cout.write(zText);
+      cout.write(zText);
-    cout.close();
+    }
-    aout.close();
 
     return buf.toByteArray();
   }
@@ -195,12 +194,13 @@ class EncryptedContactStore implements ContactStore {
     }
 
     comdg = new PGPCompressedDataGenerator(PGPCompressedData.ZIP);
-    final OutputStream out =
+    try (OutputStream out =
         new PGPLiteralDataGenerator().open(comdg.open(buf),
-            PGPLiteralData.BINARY, fileName, len, fileDate);
+            PGPLiteralData.BINARY, fileName, len, fileDate)) {
-    out.write(plainText);
+      out.write(plainText);
-    out.close();
+    } finally {
-    comdg.close();
+      comdg.close(); // PGPCompressedDataGenerator doesn't implement Closable
+    }
     return buf.toByteArray();
   }
 
@@ -220,30 +220,25 @@ class EncryptedContactStore implements ContactStore {
     field(b, "Full-Name", account.getFullName());
     field(b, "Preferred-Email", account.getPreferredEmail());
 
-    try {
+    try (ReviewDb db = schema.open()) {
-      final ReviewDb db = schema.open();
+      for (final AccountExternalId e : db.accountExternalIds().byAccount(
-      try {
+          account.getId())) {
-        for (final AccountExternalId e : db.accountExternalIds().byAccount(
+        final StringBuilder oistr = new StringBuilder();
-            account.getId())) {
+        if (e.getEmailAddress() != null && e.getEmailAddress().length() > 0) {
-          final StringBuilder oistr = new StringBuilder();
+          if (oistr.length() > 0) {
-          if (e.getEmailAddress() != null && e.getEmailAddress().length() > 0) {
+            oistr.append(' ');
-            if (oistr.length() > 0) {
-              oistr.append(' ');
-            }
-            oistr.append(e.getEmailAddress());
           }
-          if (e.isScheme(AccountExternalId.SCHEME_MAILTO)) {
+          oistr.append(e.getEmailAddress());
-            if (oistr.length() > 0) {
-              oistr.append(' ');
-            }
-            oistr.append('<');
-            oistr.append(e.getExternalId());
-            oistr.append('>');
-          }
-          field(b, "Identity", oistr.toString());
         }
-      } finally {
+        if (e.isScheme(AccountExternalId.SCHEME_MAILTO)) {
-        db.close();
+          if (oistr.length() > 0) {
+            oistr.append(' ');
+          }
+          oistr.append('<');
+          oistr.append(e.getExternalId());
+          oistr.append('>');
+        }
+        field(b, "Identity", oistr.toString());
       }
     } catch (OrmException e) {
       throw new ContactInformationStoreException(e);

gerrit-server/src/main/java/com/google/gerrit/server/contact/HttpContactStoreConnection.java

@@ -55,11 +55,8 @@ public class HttpContactStoreConnection implements ContactStoreConnection {
       throw new IOException("Connection failed: " + conn.getResponseCode());
     }
     final byte[] dst = new byte[2];
-    final InputStream in = conn.getInputStream();
+    try (InputStream in = conn.getInputStream()) {
-    try {
       IO.readFully(in, dst, 0, 2);
-    } finally {
-      in.close();
     }
     if (dst[0] != 'O' || dst[1] != 'K') {
       throw new IOException("Store failed: " + dst[0] + dst[1]);

gerrit-server/src/main/java/com/google/gerrit/server/documentation/MarkdownFormatter.java

@@ -156,17 +156,10 @@ public class MarkdownFormatter {
       throw new FileNotFoundException("Resource " + name);
     }
     file.set("file".equals(url.getProtocol()));
-    InputStream in = url.openStream();
+    try (InputStream in = url.openStream();
-    try {
+        TemporaryBuffer.Heap tmp = new TemporaryBuffer.Heap(128 * 1024)) {
-      TemporaryBuffer.Heap tmp = new TemporaryBuffer.Heap(128 * 1024);
+      tmp.copy(in);
-      try {
+      return new String(tmp.toByteArray(), "UTF-8");
-        tmp.copy(in);
-        return new String(tmp.toByteArray(), "UTF-8");
-      } finally {
-        tmp.close();
-      }
-    } finally {
-      in.close();
     }
   }
 }

gerrit-server/src/main/java/com/google/gerrit/server/documentation/QueryDocumentationExecutor.java

@@ -110,19 +110,16 @@ public class QueryDocumentationExecutor {
       return null;
     }
 
-    ZipInputStream zip = new ZipInputStream(index);
+    try (ZipInputStream zip = new ZipInputStream(index)) {
-    try {
       ZipEntry entry;
       while ((entry = zip.getNextEntry()) != null) {
-        IndexOutput out = dir.createOutput(entry.getName(), null);
+        try (IndexOutput out = dir.createOutput(entry.getName(), null)) {
-        int count;
+          int count;
-        while ((count = zip.read(buffer)) != -1) {
+          while ((count = zip.read(buffer)) != -1) {
-          out.writeBytes(buffer, count);
+            out.writeBytes(buffer, count);
+          }
         }
-        out.close();
       }
-    } finally {
-      zip.close();
     }
     // We must NOT call dir.close() here, as DirectoryReader.open() expects an opened directory.
     return dir;

gerrit-server/src/main/java/com/google/gerrit/server/edit/ChangeEditUtil.java

@@ -180,11 +180,8 @@ public class ChangeEditUtil {
   public void delete(ChangeEdit edit)
       throws IOException {
     Change change = edit.getChange();
-    Repository repo = gitManager.openRepository(change.getProject());
+    try (Repository repo = gitManager.openRepository(change.getProject())) {
-    try {
       deleteRef(repo, edit);
-    } finally {
-      repo.close();
     }
     indexer.index(db.get(), change);
   }

gerrit-server/src/main/java/com/google/gerrit/server/events/EventFactory.java

@@ -229,39 +229,34 @@ public class EventFactory {
   public void addDependencies(ChangeAttribute ca, Change change) {
     ca.dependsOn = new ArrayList<>();
     ca.neededBy = new ArrayList<>();
-    try {
+    try (ReviewDb db = schema.open()) {
-      final ReviewDb db = schema.open();
+      final PatchSet.Id psId = change.currentPatchSetId();
-      try {
+      for (PatchSetAncestor a : db.patchSetAncestors().ancestorsOf(psId)) {
-        final PatchSet.Id psId = change.currentPatchSetId();
+        for (PatchSet p :
-        for (PatchSetAncestor a : db.patchSetAncestors().ancestorsOf(psId)) {
+            db.patchSets().byRevision(a.getAncestorRevision())) {
-          for (PatchSet p :
+          Change c = db.changes().get(p.getId().getParentKey());
-              db.patchSets().byRevision(a.getAncestorRevision())) {
+          ca.dependsOn.add(newDependsOn(c, p));
-            Change c = db.changes().get(p.getId().getParentKey());
-            ca.dependsOn.add(newDependsOn(c, p));
-          }
         }
+      }
 
-        final PatchSet ps = db.patchSets().get(psId);
+      final PatchSet ps = db.patchSets().get(psId);
-        if (ps == null) {
+      if (ps == null) {
-          log.error("Error while generating the list of descendants for"
+        log.error("Error while generating the list of descendants for"
-              + " PatchSet " + psId + ": Cannot find PatchSet entry in"
+            + " PatchSet " + psId + ": Cannot find PatchSet entry in"
-              + " database.");
+            + " database.");
-        } else {
+      } else {
-          final RevId revId = ps.getRevision();
+        final RevId revId = ps.getRevision();
-          for (PatchSetAncestor a : db.patchSetAncestors().descendantsOf(revId)) {
+        for (PatchSetAncestor a : db.patchSetAncestors().descendantsOf(revId)) {
-            final PatchSet p = db.patchSets().get(a.getPatchSet());
+          final PatchSet p = db.patchSets().get(a.getPatchSet());
-            if (p == null) {
+          if (p == null) {
-              log.error("Error while generating the list of descendants for"
+            log.error("Error while generating the list of descendants for"
-                  + " revision " + revId.get() + ": Cannot find PatchSet entry in"
+                + " revision " + revId.get() + ": Cannot find PatchSet entry in"
-                  + " database for " + a.getPatchSet());
+                + " database for " + a.getPatchSet());
-              continue;
+            continue;
-            }
-            final Change c = db.changes().get(p.getId().getParentKey());
-            ca.neededBy.add(newNeededBy(c, p));
           }
+          final Change c = db.changes().get(p.getId().getParentKey());
+          ca.neededBy.add(newNeededBy(c, p));
         }
-      } finally {
-        db.close();
       }
     } catch (OrmException e) {
       // Squash DB exceptions and leave dependency lists partially filled.
@@ -401,38 +396,33 @@ public class EventFactory {
     p.createdOn = patchSet.getCreatedOn().getTime() / 1000L;
     p.isDraft = patchSet.isDraft();
     final PatchSet.Id pId = patchSet.getId();
-    try {
+    try (ReviewDb db = schema.open()) {
-      final ReviewDb db = schema.open();
+      p.parents = new ArrayList<>();
-      try {
+      for (PatchSetAncestor a : db.patchSetAncestors().ancestorsOf(
-        p.parents = new ArrayList<>();
+          patchSet.getId())) {
-        for (PatchSetAncestor a : db.patchSetAncestors().ancestorsOf(
+        p.parents.add(a.getAncestorRevision().get());
-            patchSet.getId())) {
-          p.parents.add(a.getAncestorRevision().get());
-        }
-
-        UserIdentity author = psInfoFactory.get(db, pId).getAuthor();
-        if (author.getAccount() == null) {
-          p.author = new AccountAttribute();
-          p.author.email = author.getEmail();
-          p.author.name = author.getName();
-          p.author.username = "";
-        } else {
-          p.author = asAccountAttribute(author.getAccount());
-        }
-
-        Change change = db.changes().get(pId.getParentKey());
-        List<Patch> list =
-            patchListCache.get(change, patchSet).toPatchList(pId);
-        for (Patch pe : list) {
-          if (!Patch.COMMIT_MSG.equals(pe.getFileName())) {
-            p.sizeDeletions -= pe.getDeletions();
-            p.sizeInsertions += pe.getInsertions();
-          }
-        }
-        p.kind = changeKindCache.getChangeKind(db, change, patchSet);
-      } finally {
-        db.close();
       }
+
+      UserIdentity author = psInfoFactory.get(db, pId).getAuthor();
+      if (author.getAccount() == null) {
+        p.author = new AccountAttribute();
+        p.author.email = author.getEmail();
+        p.author.name = author.getName();
+        p.author.username = "";
+      } else {
+        p.author = asAccountAttribute(author.getAccount());
+      }
+
+      Change change = db.changes().get(pId.getParentKey());
+      List<Patch> list =
+          patchListCache.get(change, patchSet).toPatchList(pId);
+      for (Patch pe : list) {
+        if (!Patch.COMMIT_MSG.equals(pe.getFileName())) {
+          p.sizeDeletions -= pe.getDeletions();
+          p.sizeInsertions += pe.getInsertions();
+        }
+      }
+      p.kind = changeKindCache.getChangeKind(db, change, patchSet);
     } catch (OrmException e) {
       log.error("Cannot load patch set data for " + patchSet.getId(), e);
     } catch (PatchSetInfoNotAvailableException e) {

gerrit-server/src/main/java/com/google/gerrit/server/git/GarbageCollection.java

@@ -86,9 +86,7 @@ public class GarbageCollection {
           GarbageCollectionResult.Error.Type.GC_ALREADY_SCHEDULED, projectName));
     }
     for (Project.NameKey p : projectsToGc) {
-      Repository repo = null;
+      try (Repository repo = repoManager.openRepository(p)) {
-      try {
-        repo = repoManager.openRepository(p);
         logGcConfiguration(p, repo, aggressive);
         print(writer, "collecting garbage for \"" + p + "\":\n");
         GarbageCollectCommand gc = Git.wrap(repo).gc();
@@ -110,9 +108,6 @@ public class GarbageCollection {
         result.addError(new GarbageCollectionResult.Error(
             GarbageCollectionResult.Error.Type.GC_FAILED, p));
       } finally {
-        if (repo != null) {
-          repo.close();
-        }
         gcQueue.gcFinished(p);
       }
     }

gerrit-server/src/main/java/com/google/gerrit/server/git/LocalDiskRepositoryManager.java

@@ -302,11 +302,8 @@ public class LocalDiskRepositoryManager implements GitRepositoryManager {
   @Override
   public String getProjectDescription(final Project.NameKey name)
       throws RepositoryNotFoundException, IOException {
-    final Repository e = openRepository(name);
+    try (Repository e = openRepository(name)) {
-    try {
       return getProjectDescription(e);
-    } finally {
-      e.close();
     }
   }
 
@@ -337,31 +334,26 @@ public class LocalDiskRepositoryManager implements GitRepositoryManager {
       final String description) {
     // Update git's description file, in case gitweb is being used
     //
-    try {
+    try (Repository e = openRepository(name)) {
-      final Repository e = openRepository(name);
+      final String old = getProjectDescription(e);
-      try {
+      if ((old == null && description == null)
-        final String old = getProjectDescription(e);
+          || (old != null && old.equals(description))) {
-        if ((old == null && description == null)
+        return;
-            || (old != null && old.equals(description))) {
+      }
-          return;
-        }
 
-        final LockFile f = new LockFile(new File(e.getDirectory(), "description"), FS.DETECTED);
+      final LockFile f = new LockFile(new File(e.getDirectory(), "description"), FS.DETECTED);
-        if (f.lock()) {
+      if (f.lock()) {
-          String d = description;
+        String d = description;
-          if (d != null) {
+        if (d != null) {
-            d = d.trim();
+          d = d.trim();
-            if (d.length() > 0) {
+          if (d.length() > 0) {
-              d += "\n";
+            d += "\n";
-            }
-          } else {
-            d = "";
           }
-          f.write(Constants.encode(d));
+        } else {
-          f.commit();
+          d = "";
         }
-      } finally {
+        f.write(Constants.encode(d));
-        e.close();
+        f.commit();
       }
     } catch (RepositoryNotFoundException e) {
       log.error("Cannot update description for " + name, e);

gerrit-server/src/main/java/com/google/gerrit/server/git/MergeOp.java

@@ -1031,13 +1031,8 @@ public class MergeOp {
       @Override
       public void run() {
         PatchSet patchSet;
-        try {
+        try (ReviewDb reviewDb = schemaFactory.open()) {
-          ReviewDb reviewDb = schemaFactory.open();
+          patchSet = reviewDb.patchSets().get(c.currentPatchSetId());
-          try {
-            patchSet = reviewDb.patchSets().get(c.currentPatchSetId());
-          } finally {
-            reviewDb.close();
-          }
         } catch (Exception e) {
           logError("Cannot send email for submitted patch set " + c.getId(), e);
           return;
@@ -1193,13 +1188,8 @@ public class MergeOp {
       @Override
       public void run() {
         PatchSet patchSet;
-        try {
+        try (ReviewDb reviewDb = schemaFactory.open()) {
-          ReviewDb reviewDb = schemaFactory.open();
+          patchSet = reviewDb.patchSets().get(c.currentPatchSetId());
-          try {
-            patchSet = reviewDb.patchSets().get(c.currentPatchSetId());
-          } finally {
-            reviewDb.close();
-          }
         } catch (Exception e) {
           logError("Cannot send email notifications about merge failure", e);
           return;

gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java

@@ -1719,11 +1719,8 @@ public class ReceiveCommits {
           if (caller == Thread.currentThread()) {
             insertChange(db);
           } else {
-            ReviewDb db = schemaFactory.open();
+            try (ReviewDb db = schemaFactory.open()) {
-            try {
               insertChange(db);
-            } finally {
-              db.close();
             }
           }
           synchronized (newProgress) {
@@ -2093,11 +2090,8 @@ public class ReceiveCommits {
             } else if (caller == Thread.currentThread()) {
               return insertPatchSet(db);
             } else {
-              ReviewDb db = schemaFactory.open();
+              try (ReviewDb db = schemaFactory.open()) {
-              try {
                 return insertPatchSet(db);
-              } finally {
-                db.close();
               }
             }
           } finally {
@@ -2347,11 +2341,8 @@ public class ReceiveCommits {
           if (caller == Thread.currentThread()) {
             updateGroups(db);
           } else {
-            ReviewDb db = schemaFactory.open();
+            try (ReviewDb db = schemaFactory.open()) {
-            try {
               updateGroups(db);
-            } finally {
-              db.close();
             }
           }
           return null;

gerrit-server/src/main/java/com/google/gerrit/server/git/ScanningChangeCacheImpl.java

@@ -95,8 +95,8 @@ public class ScanningChangeCacheImpl implements ChangeCache {
 
     @Override
     public List<Change> load(Project.NameKey key) throws Exception {
-      Repository repo = repoManager.openRepository(key);
+      try (Repository repo = repoManager.openRepository(key);
-      try (ManualRequestContext ctx = requestContext.open()) {
+          ManualRequestContext ctx = requestContext.open()) {
         ReviewDb db = ctx.getReviewDbProvider().get();
         Map<String, Ref> refs =
             repo.getRefDatabase().getRefs(RefNames.REFS_CHANGES);
@@ -114,8 +114,6 @@ public class ScanningChangeCacheImpl implements ChangeCache {
           Iterables.addAll(changes, db.changes().get(batch));
         }
         return changes;
-      } finally {
-        repo.close();
       }
     }
 

gerrit-server/src/main/java/com/google/gerrit/server/group/DbGroupMemberAuditListener.java

@@ -67,13 +67,8 @@ class DbGroupMemberAuditListener implements GroupMemberAuditListener {
           new AccountGroupMemberAudit(m, me, TimeUtil.nowTs());
       auditInserts.add(audit);
     }
-    try {
+    try (ReviewDb db = schema.open()) {
-      ReviewDb db = schema.open();
+      db.accountGroupMembersAudit().insert(auditInserts);
-      try {
-        db.accountGroupMembersAudit().insert(auditInserts);
-      } finally {
-        db.close();
-      }
     } catch (OrmException e) {
       logOrmExceptionForAccounts(
           "Cannot log add accounts to group event performed by user", me,
@@ -86,33 +81,28 @@ class DbGroupMemberAuditListener implements GroupMemberAuditListener {
       Collection<AccountGroupMember> removed) {
     List<AccountGroupMemberAudit> auditInserts = Lists.newLinkedList();
     List<AccountGroupMemberAudit> auditUpdates = Lists.newLinkedList();
-    try {
+    try (ReviewDb db = schema.open()) {
-      ReviewDb db = schema.open();
+      for (AccountGroupMember m : removed) {
-      try {
+        AccountGroupMemberAudit audit = null;
-        for (AccountGroupMember m : removed) {
+        for (AccountGroupMemberAudit a : db.accountGroupMembersAudit()
-          AccountGroupMemberAudit audit = null;
+            .byGroupAccount(m.getAccountGroupId(), m.getAccountId())) {
-          for (AccountGroupMemberAudit a : db.accountGroupMembersAudit()
+          if (a.isActive()) {
-              .byGroupAccount(m.getAccountGroupId(), m.getAccountId())) {
+            audit = a;
-            if (a.isActive()) {
+            break;
-              audit = a;
-              break;
-            }
-          }
-
-          if (audit != null) {
-            audit.removed(me, TimeUtil.nowTs());
-            auditUpdates.add(audit);
-          } else {
-            audit = new AccountGroupMemberAudit(m, me, TimeUtil.nowTs());
-            audit.removedLegacy();
-            auditInserts.add(audit);
           }
         }
-        db.accountGroupMembersAudit().update(auditUpdates);
+
-        db.accountGroupMembersAudit().insert(auditInserts);
+        if (audit != null) {
-      } finally {
+          audit.removed(me, TimeUtil.nowTs());
-        db.close();
+          auditUpdates.add(audit);
+        } else {
+          audit = new AccountGroupMemberAudit(m, me, TimeUtil.nowTs());
+          audit.removedLegacy();
+          auditInserts.add(audit);
+        }
       }
+      db.accountGroupMembersAudit().update(auditUpdates);
+      db.accountGroupMembersAudit().insert(auditInserts);
     } catch (OrmException e) {
       logOrmExceptionForAccounts(
           "Cannot log delete accounts from group event performed by user", me,
@@ -129,13 +119,8 @@ class DbGroupMemberAuditListener implements GroupMemberAuditListener {
           new AccountGroupByIdAud(groupInclude, me, TimeUtil.nowTs());
       includesAudit.add(audit);
     }
-    try {
+    try (ReviewDb db = schema.open()) {
-      ReviewDb db = schema.open();
+      db.accountGroupByIdAud().insert(includesAudit);
-      try {
-        db.accountGroupByIdAud().insert(includesAudit);
-      } finally {
-        db.close();
-      }
     } catch (OrmException e) {
       logOrmExceptionForGroups(
           "Cannot log add groups to group event performed by user", me, added,
@@ -147,28 +132,23 @@ class DbGroupMemberAuditListener implements GroupMemberAuditListener {
   public void onDeleteGroupsFromGroup(Account.Id me,
       Collection<AccountGroupById> removed) {
     final List<AccountGroupByIdAud> auditUpdates = Lists.newLinkedList();
-    try {
+    try (ReviewDb db = schema.open()) {
-      ReviewDb db = schema.open();
+      for (final AccountGroupById g : removed) {
-      try {
+        AccountGroupByIdAud audit = null;
-        for (final AccountGroupById g : removed) {
+        for (AccountGroupByIdAud a : db.accountGroupByIdAud()
-          AccountGroupByIdAud audit = null;
+            .byGroupInclude(g.getGroupId(), g.getIncludeUUID())) {
-          for (AccountGroupByIdAud a : db.accountGroupByIdAud()
+          if (a.isActive()) {
-              .byGroupInclude(g.getGroupId(), g.getIncludeUUID())) {
+            audit = a;
-            if (a.isActive()) {
+            break;
-              audit = a;
-              break;
-            }
-          }
-
-          if (audit != null) {
-            audit.removed(me, TimeUtil.nowTs());
-            auditUpdates.add(audit);
           }
         }
-        db.accountGroupByIdAud().update(auditUpdates);
+
-      } finally {
+        if (audit != null) {
-        db.close();
+          audit.removed(me, TimeUtil.nowTs());
+          auditUpdates.add(audit);
+        }
       }
+      db.accountGroupByIdAud().update(auditUpdates);
     } catch (OrmException e) {
       logOrmExceptionForGroups(
           "Cannot log delete groups from group event performed by user", me,

gerrit-server/src/main/java/com/google/gerrit/server/index/SiteIndexer.java

@@ -235,12 +235,12 @@ public class SiteIndexer {
       @Override
       public Void call() throws Exception {
         Multimap<ObjectId, ChangeData> byId = ArrayListMultimap.create();
-        Repository repo = null;
+        // TODO(dborowitz): Opening all repositories in a live server may be
-        ReviewDb db = null;
+        // wasteful; see if we can determine which ones it is safe to close
-        try {
+        // with RepositoryCache.close(repo).
-          repo = repoManager.openRepository(project);
+        try (Repository repo = repoManager.openRepository(project);
+            ReviewDb db = schemaFactory.open()) {
           Map<String, Ref> refs = repo.getRefDatabase().getRefs(ALL);
-          db = schemaFactory.open();
           for (Change c : changeCache.get(project)) {
             Ref r = refs.get(c.currentPatchSetId().toRefName());
             if (r != null) {
@@ -256,16 +256,6 @@ public class SiteIndexer {
               verboseWriter).call();
         } catch (RepositoryNotFoundException rnfe) {
           log.error(rnfe.getMessage());
-        } finally {
-          if (db != null) {
-            db.close();
-          }
-          if (repo != null) {
-            repo.close();
-          }
-          // TODO(dborowitz): Opening all repositories in a live server may be
-          // wasteful; see if we can determine which ones it is safe to close
-          // with RepositoryCache.close(repo).
         }
         return null;
       }

gerrit-server/src/main/java/com/google/gerrit/server/mail/ChangeEmail.java

@@ -406,27 +406,23 @@ public abstract class ChangeEmail extends NotificationEmail {
     TemporaryBuffer.Heap buf =
         new TemporaryBuffer.Heap(Math.min(HEAP_EST_SIZE, maxSize), maxSize);
     try (DiffFormatter fmt = new DiffFormatter(buf)) {
-      Repository git;
+      try (Repository git = args.server.openRepository(change.getProject())) {
-      try {
+        try {
-        git = args.server.openRepository(change.getProject());
+          fmt.setRepository(git);
+          fmt.setDetectRenames(true);
+          fmt.format(patchList.getOldId(), patchList.getNewId());
+          return RawParseUtils.decode(buf.toByteArray());
+        } catch (IOException e) {
+          if (JGitText.get().inMemoryBufferLimitExceeded.equals(e.getMessage())) {
+            return "";
+          }
+          log.error("Cannot format patch", e);
+          return "";
+        }
       } catch (IOException e) {
         log.error("Cannot open repository to format patch", e);
         return "";
       }
-      try {
-        fmt.setRepository(git);
-        fmt.setDetectRenames(true);
-        fmt.format(patchList.getOldId(), patchList.getNewId());
-        return RawParseUtils.decode(buf.toByteArray());
-      } catch (IOException e) {
-        if (JGitText.get().inMemoryBufferLimitExceeded.equals(e.getMessage())) {
-          return "";
-        }
-        log.error("Cannot format patch", e);
-        return "";
-      } finally {
-        git.close();
-      }
     }
   }
 }

gerrit-server/src/main/java/com/google/gerrit/server/mail/CommentSender.java

@@ -116,8 +116,7 @@ public class CommentSender extends ReplyToChangeSender {
 
   public String getInlineComments(int lines) {
     StringBuilder cmts = new StringBuilder();
-    final Repository repo = getRepository();
+    try (Repository repo = getRepository()) {
-    try {
       PatchList patchList = null;
       if (repo != null) {
         try {
@@ -164,10 +163,6 @@ public class CommentSender extends ReplyToChangeSender {
         }
         cmts.append("\n\n");
       }
-    } finally {
-      if (repo != null) {
-        repo.close();
-      }
     }
     return cmts.toString();
   }

gerrit-server/src/main/java/com/google/gerrit/server/mail/SmtpEmailSender.java

@@ -192,8 +192,8 @@ public class SmtpEmailSender implements EmailSender {
           }
         }
 
-        Writer w = client.sendMessageData();
+        Writer messageDataWriter = client.sendMessageData();
-        if (w == null) {
+        if (messageDataWriter == null) {
           /* Include rejected recipient error messages here to not lose that
            * information. That piece of the puzzle is vital if zero recipients
            * are accepted and the server consequently rejects the DATA command.
@@ -201,21 +201,20 @@ public class SmtpEmailSender implements EmailSender {
           throw new EmailException(rejected + "Server " + smtpHost
               + " rejected DATA command: " + client.getReplyString());
         }
-        w = new BufferedWriter(w);
+        try (Writer w = new BufferedWriter(messageDataWriter)) {
-
+          for (Map.Entry<String, EmailHeader> h : hdrs.entrySet()) {
-        for (Map.Entry<String, EmailHeader> h : hdrs.entrySet()) {
+            if (!h.getValue().isEmpty()) {
-          if (!h.getValue().isEmpty()) {
+              w.write(h.getKey());
-            w.write(h.getKey());
+              w.write(": ");
-            w.write(": ");
+              h.getValue().write(w);
-            h.getValue().write(w);
+              w.write("\r\n");
-            w.write("\r\n");
+            }
           }
-        }
 
-        w.write("\r\n");
+          w.write("\r\n");
-        w.write(body);
+          w.write(body);
-        w.flush();
+          w.flush();
-        w.close();
+        }
 
         if (!client.completePendingCommand()) {
           throw new EmailException("Server " + smtpHost

gerrit-server/src/main/java/com/google/gerrit/server/notedb/AbstractChangeNotes.java

@@ -54,19 +54,11 @@ public abstract class AbstractChangeNotes<T> extends VersionedMetaData {
       loadDefaults();
       return self();
     }
-    Repository repo;
+    try (Repository repo = repoManager.openMetadataRepository(getProjectName())) {
-    try {
-      repo = repoManager.openMetadataRepository(getProjectName());
-    } catch (IOException e) {
-      throw new OrmException(e);
-    }
-    try {
       load(repo);
       loaded = true;
     } catch (ConfigInvalidException | IOException e) {
       throw new OrmException(e);
-    } finally {
-      repo.close();
     }
     return self();
   }
@@ -77,15 +69,9 @@ public abstract class AbstractChangeNotes<T> extends VersionedMetaData {
     } else if (!migration.enabled()) {
       return null;
     }
-    Repository repo;
+    try (Repository repo = repoManager.openMetadataRepository(getProjectName())) {
-    try {
+      Ref ref = repo.getRefDatabase().exactRef(getRefName());
-      repo = repoManager.openMetadataRepository(getProjectName());
+      return ref != null ? ref.getObjectId() : null;
-      try {
-        Ref ref = repo.getRefDatabase().exactRef(getRefName());
-        return ref != null ? ref.getObjectId() : null;
-      } finally {
-        repo.close();
-      }
     } catch (IOException e) {
       throw new OrmException(e);
     }

gerrit-server/src/main/java/com/google/gerrit/server/notedb/AbstractChangeUpdate.java

@@ -93,13 +93,10 @@ public abstract class AbstractChangeUpdate extends VersionedMetaData {
 
   private void load() throws IOException {
     if (migration.writeChanges() && getRevision() == null) {
-      Repository repo = repoManager.openMetadataRepository(getProjectName());
+      try (Repository repo = repoManager.openMetadataRepository(getProjectName())) {
-      try {
         load(repo);
       } catch (ConfigInvalidException e) {
         throw new IOException(e);
-      } finally {
-        repo.close();
       }
     }
   }

gerrit-server/src/main/java/com/google/gerrit/server/notedb/CommentsInNotesUtil.java

@@ -439,82 +439,82 @@ public class CommentsInNotesUtil {
   public byte[] buildNote(List<PatchLineComment> comments) {
     ByteArrayOutputStream buf = new ByteArrayOutputStream();
     OutputStreamWriter streamWriter = new OutputStreamWriter(buf, UTF_8);
-    PrintWriter writer = new PrintWriter(streamWriter);
+    try (PrintWriter writer = new PrintWriter(streamWriter)) {
-    PatchLineComment first = comments.get(0);
+      PatchLineComment first = comments.get(0);
 
-    short side = first.getSide();
+      short side = first.getSide();
-    PatchSet.Id psId = PatchLineCommentsUtil.getCommentPsId(first);
+      PatchSet.Id psId = PatchLineCommentsUtil.getCommentPsId(first);
-    appendHeaderField(writer, side == 0
+      appendHeaderField(writer, side == 0
-        ? BASE_PATCH_SET
+          ? BASE_PATCH_SET
-        : PATCH_SET,
+          : PATCH_SET,
-        Integer.toString(psId.get()));
+          Integer.toString(psId.get()));
-    appendHeaderField(writer, REVISION, first.getRevId().get());
+      appendHeaderField(writer, REVISION, first.getRevId().get());
 
-    String currentFilename = null;
+      String currentFilename = null;
 
-    for (PatchLineComment c : comments) {
+      for (PatchLineComment c : comments) {
-      PatchSet.Id currentPsId = PatchLineCommentsUtil.getCommentPsId(c);
+        PatchSet.Id currentPsId = PatchLineCommentsUtil.getCommentPsId(c);
-      checkArgument(psId.equals(currentPsId),
+        checkArgument(psId.equals(currentPsId),
-          "All comments being added must all have the same PatchSet.Id. The"
+            "All comments being added must all have the same PatchSet.Id. The"
-          + "comment below does not have the same PatchSet.Id as the others "
+            + "comment below does not have the same PatchSet.Id as the others "
-          + "(%s).\n%s", psId.toString(), c.toString());
+            + "(%s).\n%s", psId.toString(), c.toString());
-      checkArgument(side == c.getSide(),
+        checkArgument(side == c.getSide(),
-          "All comments being added must all have the same side. The"
+            "All comments being added must all have the same side. The"
-          + "comment below does not have the same side as the others "
+            + "comment below does not have the same side as the others "
-          + "(%s).\n%s", side, c.toString());
+            + "(%s).\n%s", side, c.toString());
-      String commentFilename =
+        String commentFilename =
-          QuotedString.GIT_PATH.quote(c.getKey().getParentKey().getFileName());
+            QuotedString.GIT_PATH.quote(c.getKey().getParentKey().getFileName());
 
-      if (!commentFilename.equals(currentFilename)) {
+        if (!commentFilename.equals(currentFilename)) {
-        currentFilename = commentFilename;
+          currentFilename = commentFilename;
-        writer.print("File: ");
+          writer.print("File: ");
-        writer.print(commentFilename);
+          writer.print(commentFilename);
+          writer.print("\n\n");
+        }
+
+        // The CommentRange field for a comment is allowed to be null.
+        // If it is indeed null, then in the first line, we simply use the line
+        // number field for a comment instead. If it isn't null, we write the
+        // comment range itself.
+        CommentRange range = c.getRange();
+        if (range != null) {
+          writer.print(range.getStartLine());
+          writer.print(':');
+          writer.print(range.getStartCharacter());
+          writer.print('-');
+          writer.print(range.getEndLine());
+          writer.print(':');
+          writer.print(range.getEndCharacter());
+        } else {
+          writer.print(c.getLine());
+        }
+        writer.print("\n");
+
+        writer.print(formatTime(serverIdent, c.getWrittenOn()));
+        writer.print("\n");
+
+        PersonIdent ident =
+            newIdent(accountCache.get(c.getAuthor()).getAccount(),
+                c.getWrittenOn());
+        String nameString = ident.getName() + " <" + ident.getEmailAddress()
+            + ">";
+        appendHeaderField(writer, AUTHOR, nameString);
+
+        String parent = c.getParentUuid();
+        if (parent != null) {
+          appendHeaderField(writer, PARENT, parent);
+        }
+
+        appendHeaderField(writer, UUID, c.getKey().get());
+
+        byte[] messageBytes = c.getMessage().getBytes(UTF_8);
+        appendHeaderField(writer, LENGTH,
+            Integer.toString(messageBytes.length));
+
+        writer.print(c.getMessage());
         writer.print("\n\n");
       }
-
-      // The CommentRange field for a comment is allowed to be null.
-      // If it is indeed null, then in the first line, we simply use the line
-      // number field for a comment instead. If it isn't null, we write the
-      // comment range itself.
-      CommentRange range = c.getRange();
-      if (range != null) {
-        writer.print(range.getStartLine());
-        writer.print(':');
-        writer.print(range.getStartCharacter());
-        writer.print('-');
-        writer.print(range.getEndLine());
-        writer.print(':');
-        writer.print(range.getEndCharacter());
-      } else {
-        writer.print(c.getLine());
-      }
-      writer.print("\n");
-
-      writer.print(formatTime(serverIdent, c.getWrittenOn()));
-      writer.print("\n");
-
-      PersonIdent ident =
-          newIdent(accountCache.get(c.getAuthor()).getAccount(),
-              c.getWrittenOn());
-      String nameString = ident.getName() + " <" + ident.getEmailAddress()
-          + ">";
-      appendHeaderField(writer, AUTHOR, nameString);
-
-      String parent = c.getParentUuid();
-      if (parent != null) {
-        appendHeaderField(writer, PARENT, parent);
-      }
-
-      appendHeaderField(writer, UUID, c.getKey().get());
-
-      byte[] messageBytes = c.getMessage().getBytes(UTF_8);
-      appendHeaderField(writer, LENGTH,
-          Integer.toString(messageBytes.length));
-
-      writer.print(c.getMessage());
-      writer.print("\n\n");
     }
-    writer.close();
     return buf.toByteArray();
   }
 

gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchList.java

@@ -163,8 +163,7 @@ public class PatchList implements Serializable {
 
   private void writeObject(final ObjectOutputStream output) throws IOException {
     final ByteArrayOutputStream buf = new ByteArrayOutputStream();
-    final DeflaterOutputStream out = new DeflaterOutputStream(buf);
+    try (DeflaterOutputStream out = new DeflaterOutputStream(buf)) {
-    try {
       writeCanBeNull(out, oldId);
       writeNotNull(out, newId);
       writeVarInt32(out, againstParent ? 1 : 0);
@@ -174,16 +173,13 @@ public class PatchList implements Serializable {
       for (PatchListEntry p : patches) {
         p.writeTo(out);
       }
-    } finally {
-      out.close();
     }
     writeBytes(output, buf.toByteArray());
   }
 
   private void readObject(final ObjectInputStream input) throws IOException {
     final ByteArrayInputStream buf = new ByteArrayInputStream(readBytes(input));
-    final InflaterInputStream in = new InflaterInputStream(buf);
+    try (InflaterInputStream in = new InflaterInputStream(buf)) {
-    try {
       oldId = readCanBeNull(in);
       newId = readNotNull(in);
       againstParent = readVarInt32(in) != 0;
@@ -195,8 +191,6 @@ public class PatchList implements Serializable {
         all[i] = PatchListEntry.readFrom(in);
       }
       patches = all;
-    } finally {
-      in.close();
     }
   }
 }

gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchListLoader.java

@@ -106,11 +106,8 @@ public class PatchListLoader extends CacheLoader<PatchListKey, PatchList> {
   @Override
   public PatchList load(final PatchListKey key) throws IOException,
       PatchListNotAvailableException {
-    final Repository repo = repoManager.openRepository(key.projectKey);
+    try (Repository repo = repoManager.openRepository(key.projectKey)) {
-    try {
       return readPatchList(key, repo);
-    } finally {
-      repo.close();
     }
   }
 
@@ -384,11 +381,8 @@ public class PatchListLoader extends CacheLoader<PatchListKey, PatchList> {
             fmt.formatMerge(buf, p, "BASE", oursName, theirsName, "UTF-8");
             buf.close();
 
-            InputStream in = buf.openInputStream();
+            try (InputStream in = buf.openInputStream()) {
-            try {
               resolved.put(entry.getKey(), ins.insert(Constants.OBJ_BLOB, buf.length(), in));
-            } finally {
-              in.close();
             }
           } finally {
             buf.destroy();

gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchScriptFactory.java

@@ -155,9 +155,25 @@ public class PatchScriptFactory implements Callable<PatchScript> {
       throw new NoSuchChangeException(changeId);
     }
 
-    final Repository git;
+    try (Repository git = repoManager.openRepository(projectKey)) {
-    try {
+      try {
-      git = repoManager.openRepository(projectKey);
+        final PatchList list = listFor(keyFor(diffPrefs.getIgnoreWhitespace()));
+        final PatchScriptBuilder b = newBuilder(list, git);
+        final PatchListEntry content = list.get(fileName);
+
+        loadCommentsAndHistory(content.getChangeType(), //
+            content.getOldName(), //
+            content.getNewName());
+
+        return b.toPatchScript(content, comments, history);
+      } catch (PatchListNotAvailableException e) {
+        throw new NoSuchChangeException(changeId, e);
+      } catch (IOException e) {
+        log.error("File content unavailable", e);
+        throw new NoSuchChangeException(changeId, e);
+      } catch (org.eclipse.jgit.errors.LargeObjectException err) {
+        throw new LargeObjectException("File content is too large", err);
+      }
     } catch (RepositoryNotFoundException e) {
       log.error("Repository " + projectKey + " not found", e);
       throw new NoSuchChangeException(changeId, e);
@@ -165,26 +181,6 @@ public class PatchScriptFactory implements Callable<PatchScript> {
       log.error("Cannot open repository " + projectKey, e);
       throw new NoSuchChangeException(changeId, e);
     }
-    try {
-      final PatchList list = listFor(keyFor(diffPrefs.getIgnoreWhitespace()));
-      final PatchScriptBuilder b = newBuilder(list, git);
-      final PatchListEntry content = list.get(fileName);
-
-      loadCommentsAndHistory(content.getChangeType(), //
-          content.getOldName(), //
-          content.getNewName());
-
-      return b.toPatchScript(content, comments, history);
-    } catch (PatchListNotAvailableException e) {
-      throw new NoSuchChangeException(changeId, e);
-    } catch (IOException e) {
-      log.error("File content unavailable", e);
-      throw new NoSuchChangeException(changeId, e);
-    } catch (org.eclipse.jgit.errors.LargeObjectException err) {
-      throw new LargeObjectException("File content is too large", err);
-    } finally {
-      git.close();
-    }
   }
 
   private PatchListKey keyFor(final Whitespace whitespace) {

gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchSetInfoFactory.java

@@ -79,13 +79,8 @@ public class PatchSetInfoFactory {
 
   public PatchSetInfo get(Change change, PatchSet patchSet)
       throws PatchSetInfoNotAvailableException {
-    Repository repo;
+    try (Repository repo = repoManager.openRepository(change.getProject());
-    try {
+        RevWalk rw = new RevWalk(repo)) {
-      repo = repoManager.openRepository(change.getProject());
-    } catch (IOException e) {
-      throw new PatchSetInfoNotAvailableException(e);
-    }
-    try (RevWalk rw = new RevWalk(repo)) {
       final RevCommit src =
           rw.parseCommit(ObjectId.fromString(patchSet.getRevision().get()));
       PatchSetInfo info = get(src, patchSet.getId());
@@ -93,8 +88,6 @@ public class PatchSetInfoFactory {
       return info;
     } catch (IOException e) {
       throw new PatchSetInfoNotAvailableException(e);
-    } finally {
-      repo.close();
     }
   }
 

gerrit-server/src/main/java/com/google/gerrit/server/plugins/JarScanner.java

@@ -185,11 +185,8 @@ public class JarScanner implements PluginContentScanner {
   private static byte[] read(JarFile jarFile, JarEntry entry)
       throws IOException {
     byte[] data = new byte[(int) entry.getSize()];
-    InputStream in = jarFile.getInputStream(entry);
+    try (InputStream in = jarFile.getInputStream(entry)) {
-    try {
       IO.readFully(in, data, 0, data.length);
-    } finally {
-      in.close();
     }
     return data;
   }

gerrit-server/src/main/java/com/google/gerrit/server/project/CreateBranch.java

@@ -117,8 +117,7 @@ public class CreateBranch implements RestModifyView<ProjectResource, Input> {
 
     final Branch.NameKey name = new Branch.NameKey(rsrc.getNameKey(), ref);
     final RefControl refControl = rsrc.getControl().controlForRef(name);
-    final Repository repo = repoManager.openRepository(rsrc.getNameKey());
+    try (Repository repo = repoManager.openRepository(rsrc.getNameKey())) {
-    try {
       final ObjectId revid = parseBaseRevision(repo, rsrc.getNameKey(), input.revision);
       final RevWalk rw = verifyConnected(repo, revid);
       RevObject object = rw.parseAny(revid);
@@ -184,8 +183,6 @@ public class CreateBranch implements RestModifyView<ProjectResource, Input> {
       }
     } catch (InvalidRevisionException e) {
       throw new BadRequestException("invalid revision \"" + input.revision + "\"");
-    } finally {
-      repo.close();
     }
   }
 

gerrit-server/src/main/java/com/google/gerrit/server/project/CreateProject.java

@@ -229,8 +229,7 @@ public class CreateProject implements RestModifyView<TopLevelResource, ProjectIn
       final String head =
           args.permissionsOnly ? RefNames.REFS_CONFIG
               : args.branch.get(0);
-      Repository repo = repoManager.createRepository(nameKey);
+      try (Repository repo = repoManager.createRepository(nameKey)) {
-      try {
         NewProjectCreatedListener.Event event = new NewProjectCreatedListener.Event() {
           @Override
           public String getProjectName() {
@@ -262,8 +261,6 @@ public class CreateProject implements RestModifyView<TopLevelResource, ProjectIn
         }
 
         return projectCache.get(nameKey).getProject();
-      } finally {
-        repo.close();
       }
     } catch (RepositoryCaseMismatchException e) {
       throw new ResourceConflictException("Cannot create " + nameKey.get()
@@ -273,16 +270,11 @@ public class CreateProject implements RestModifyView<TopLevelResource, ProjectIn
     } catch (RepositoryNotFoundException badName) {
       throw new BadRequestException("invalid project name: " + nameKey);
     } catch (IllegalStateException err) {
-      try {
+      try (Repository repo = repoManager.openRepository(nameKey)) {
-        Repository repo = repoManager.openRepository(nameKey);
+        if (repo.getObjectDatabase().exists()) {
-        try {
+          throw new ResourceConflictException("project \"" + nameKey + "\" exists");
-          if (repo.getObjectDatabase().exists()) {
-            throw new ResourceConflictException("project \"" + nameKey + "\" exists");
-          }
-          throw err;
-        } finally {
-          repo.close();
         }
+        throw err;
       } catch (IOException ioErr) {
         String msg = "Cannot create " + nameKey;
         log.error(msg, err);

gerrit-server/src/main/java/com/google/gerrit/server/project/DashboardsCollection.java

@@ -132,21 +132,15 @@ class DashboardsCollection implements
       throw new ResourceNotFoundException(id);
     }
 
-    Repository git;
+    try (Repository git = gitManager.openRepository(ctl.getProject().getNameKey())) {
-    try {
-      git = gitManager.openRepository(ctl.getProject().getNameKey());
-    } catch (RepositoryNotFoundException e) {
-      throw new ResourceNotFoundException(id);
-    }
-    try {
       ObjectId objId = git.resolve(ref + ":" + path);
       if (objId == null) {
         throw new ResourceNotFoundException(id);
       }
       BlobBasedConfig cfg = new BlobBasedConfig(null, git, objId);
       return new DashboardResource(myCtl, ref, path, cfg, false);
-    } finally {
+    } catch (RepositoryNotFoundException e) {
-      git.close();
+      throw new ResourceNotFoundException(id);
     }
   }
 

gerrit-server/src/main/java/com/google/gerrit/server/project/DeleteBranch.java

@@ -82,8 +82,7 @@ public class DeleteBranch implements RestModifyView<BranchResource, Input>{
           + " has open changes");
     }
 
-    Repository r = repoManager.openRepository(rsrc.getNameKey());
+    try (Repository r = repoManager.openRepository(rsrc.getNameKey())) {
-    try {
       RefUpdate.Result result;
       RefUpdate u = r.updateRef(rsrc.getRef());
       u.setForceUpdate(true);
@@ -129,8 +128,6 @@ public class DeleteBranch implements RestModifyView<BranchResource, Input>{
           log.error("Cannot delete " + rsrc.getBranchKey() + ": " + result.name());
           throw new ResourceConflictException("cannot delete branch: " + result.name());
       }
-    } finally {
-      r.close();
     }
     return Response.none();
   }

gerrit-server/src/main/java/com/google/gerrit/server/project/DeleteBranches.java

@@ -93,8 +93,7 @@ class DeleteBranches implements RestModifyView<ProjectResource, Input> {
   public Response<?> apply(ProjectResource project, Input input)
       throws OrmException, IOException, ResourceConflictException {
     input = Input.init(input);
-    Repository r = repoManager.openRepository(project.getNameKey());
+    try (Repository r = repoManager.openRepository(project.getNameKey())) {
-    try {
       BatchRefUpdate batchUpdate = r.getRefDatabase().newBatchUpdate();
       for (String branch : input.branches) {
         batchUpdate.addCommand(createDeleteCommand(project, r, branch));
@@ -113,8 +112,6 @@ class DeleteBranches implements RestModifyView<ProjectResource, Input> {
       if (errorMessages.length() > 0) {
         throw new ResourceConflictException(errorMessages.toString());
       }
-    } finally {
-      r.close();
     }
     return Response.none();
   }

gerrit-server/src/main/java/com/google/gerrit/server/project/GetReflog.java

@@ -78,8 +78,7 @@ public class GetReflog implements RestReadView<BranchResource> {
       throw new AuthException("not project owner");
     }
 
-    Repository repo = repoManager.openRepository(rsrc.getNameKey());
+    try (Repository repo = repoManager.openRepository(rsrc.getNameKey())) {
-    try {
       ReflogReader r = repo.getReflogReader(rsrc.getRef());
       if (r == null) {
         throw new ResourceNotFoundException(rsrc.getRef());
@@ -108,8 +107,6 @@ public class GetReflog implements RestReadView<BranchResource> {
         public ReflogEntryInfo apply(ReflogEntry e) {
           return new ReflogEntryInfo(e);
         }});
-    } finally {
-      repo.close();
     }
   }
 

gerrit-server/src/main/java/com/google/gerrit/server/project/GetStatistics.java

@@ -45,18 +45,13 @@ public class GetStatistics implements RestReadView<ProjectResource> {
   @Override
   public RepositoryStatistics apply(ProjectResource rsrc)
       throws ResourceNotFoundException, ResourceConflictException {
-    try {
+    try (Repository repo = repoManager.openRepository(rsrc.getNameKey())) {
-      Repository repo = repoManager.openRepository(rsrc.getNameKey());
+      GarbageCollectCommand gc = Git.wrap(repo).gc();
-      try {
+      return new RepositoryStatistics(gc.getStatistics());
-        GarbageCollectCommand gc = Git.wrap(repo).gc();
+    } catch (GitAPIException e) {
-        return new RepositoryStatistics(gc.getStatistics());
+      throw new ResourceConflictException(e.getMessage());
-      } catch (GitAPIException e) {
+    } catch (JGitInternalException e) {
-        throw new ResourceConflictException(e.getMessage());
+      throw new ResourceConflictException(e.getMessage());
-      } catch (JGitInternalException e) {
-        throw new ResourceConflictException(e.getMessage());
-      } finally {
-        repo.close();
-      }
     } catch (IOException e) {
       throw new ResourceNotFoundException(rsrc.getName());
     }

gerrit-server/src/main/java/com/google/gerrit/server/project/ListProjects.java

@@ -343,8 +343,7 @@ public class ListProjects implements RestReadView<TopLevelResource> {
 
           try {
             if (!showBranch.isEmpty()) {
-              Repository git = repoManager.openRepository(projectName);
+              try (Repository git = repoManager.openRepository(projectName)) {
-              try {
                 if (!type.matches(git)) {
                   continue;
                 }
@@ -363,17 +362,12 @@ public class ListProjects implements RestReadView<TopLevelResource> {
                     info.branches.put(showBranch.get(i), ref.getObjectId().name());
                   }
                 }
-              } finally {
-                git.close();
               }
             } else if (!showTree && type != FilterType.ALL) {
-              Repository git = repoManager.openRepository(projectName);
+              try (Repository git = repoManager.openRepository(projectName)) {
-              try {
                 if (!type.matches(git)) {
                   continue;
                 }
-              } finally {
-                git.close();
               }
             }
 
@@ -511,20 +505,15 @@ public class ListProjects implements RestReadView<TopLevelResource> {
   private List<Ref> getBranchRefs(Project.NameKey projectName,
       ProjectControl projectControl) {
     Ref[] result = new Ref[showBranch.size()];
-    try {
+    try (Repository git = repoManager.openRepository(projectName)) {
-      Repository git = repoManager.openRepository(projectName);
+      for (int i = 0; i < showBranch.size(); i++) {
-      try {
+        Ref ref = git.getRef(showBranch.get(i));
-        for (int i = 0; i < showBranch.size(); i++) {
+        if (ref != null
-          Ref ref = git.getRef(showBranch.get(i));
+          && ref.getObjectId() != null
-          if (ref != null
+          && (projectControl.controlForRef(ref.getLeaf().getName()).isVisible())
-            && ref.getObjectId() != null
+              || (all && projectControl.isOwner())) {
-            && (projectControl.controlForRef(ref.getLeaf().getName()).isVisible())
+          result[i] = ref;
-                || (all && projectControl.isOwner())) {
-            result[i] = ref;
-          }
         }
-      } finally {
-        git.close();
       }
     } catch (IOException ioe) {
       // Fall through and return what is available.

gerrit-server/src/main/java/com/google/gerrit/server/project/ListTags.java

@@ -69,9 +69,7 @@ public class ListTags implements RestReadView<ProjectResource> {
       ResourceNotFoundException {
     List<TagInfo> tags = Lists.newArrayList();
 
-    Repository repo = getRepository(resource.getNameKey());
+    try (Repository repo = getRepository(resource.getNameKey())) {
-
-    try {
       RevWalk rw = new RevWalk(repo);
       try {
         Map<String, Ref> all = visibleTags(resource.getControl(), repo,
@@ -82,8 +80,6 @@ public class ListTags implements RestReadView<ProjectResource> {
       } finally {
         rw.dispose();
       }
-    } finally {
-      repo.close();
     }
 
     Collections.sort(tags, new Comparator<TagInfo>() {

gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectCacheImpl.java

@@ -288,13 +288,10 @@ public class ProjectCacheImpl implements ProjectCache {
     @Override
     public ProjectState load(String projectName) throws Exception {
       Project.NameKey key = new Project.NameKey(projectName);
-      Repository git = mgr.openRepository(key);
+      try (Repository git = mgr.openRepository(key)) {
-      try {
         ProjectConfig cfg = new ProjectConfig(key);
         cfg.load(git);
         return projectStateFactory.create(cfg);
-      } finally {
-        git.close();
       }
     }
   }

gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java

@@ -535,14 +535,9 @@ public class ProjectControl {
   }
 
   public boolean canReadCommit(ReviewDb db, RevWalk rw, RevCommit commit) {
-    try {
+    try (Repository repo = openRepository()) {
-      Repository repo = openRepository();
+      return isMergedIntoVisibleRef(repo, db, rw, commit,
-      try {
+          repo.getAllRefs().values());
-        return isMergedIntoVisibleRef(repo, db, rw, commit,
-            repo.getAllRefs().values());
-      } finally {
-        repo.close();
-      }
     } catch (IOException e) {
       String msg = String.format(
           "Cannot verify permissions to commit object %s in repository %s",

gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectState.java

@@ -163,17 +163,12 @@ public class ProjectState {
   }
 
   private boolean isRevisionOutOfDate() {
-    try {
+    try (Repository git = gitMgr.openRepository(getProject().getNameKey())) {
-      Repository git = gitMgr.openRepository(getProject().getNameKey());
+      Ref ref = git.getRefDatabase().exactRef(RefNames.REFS_CONFIG);
-      try {
+      if (ref == null || ref.getObjectId() == null) {
-        Ref ref = git.getRefDatabase().exactRef(RefNames.REFS_CONFIG);
+        return true;
-        if (ref == null || ref.getObjectId() == null) {
-          return true;
-        }
-        return !ref.getObjectId().equals(config.getRevision());
-      } finally {
-        git.close();
       }
+      return !ref.getObjectId().equals(config.getRevision());
     } catch (IOException gone) {
       return true;
     }
@@ -228,13 +223,8 @@ public class ProjectState {
     }
 
     ProjectLevelConfig cfg = new ProjectLevelConfig(fileName, this);
-    try {
+    try (Repository git = gitMgr.openRepository(getProject().getNameKey())) {
-      Repository git = gitMgr.openRepository(getProject().getNameKey());
+      cfg.load(git);
-      try {
-        cfg.load(git);
-      } finally {
-        git.close();
-      }
     } catch (IOException e) {
       log.warn("Failed to load " + fileName + " for " + getProject().getName(), e);
     } catch (ConfigInvalidException e) {

gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java

@@ -328,17 +328,12 @@ public class RefControl {
 
   private boolean isMergedIntoBranchOrTag(ReviewDb db, RevWalk rw,
       RevCommit commit) {
-    try {
+    try (Repository repo = projectControl.openRepository()) {
-      Repository repo = projectControl.openRepository();
+      List<Ref> refs = new ArrayList<>(
-      try {
+          repo.getRefDatabase().getRefs(Constants.R_HEADS).values());
-        List<Ref> refs = new ArrayList<>(
+      refs.addAll(repo.getRefDatabase().getRefs(Constants.R_TAGS).values());
-            repo.getRefDatabase().getRefs(Constants.R_HEADS).values());
+      return projectControl.isMergedIntoVisibleRef(
-        refs.addAll(repo.getRefDatabase().getRefs(Constants.R_TAGS).values());
+          repo, db, rw, commit, refs);
-        return projectControl.isMergedIntoVisibleRef(
-            repo, db, rw, commit, refs);
-      } finally {
-        repo.close();
-      }
     } catch (IOException e) {
       String msg = String.format(
           "Cannot verify permissions to commit object %s in repository %s",

gerrit-server/src/main/java/com/google/gerrit/server/project/SetHead.java

@@ -76,9 +76,7 @@ public class SetHead implements RestModifyView<ProjectResource, Input> {
     }
     String ref = RefNames.fullName(input.ref);
 
-    Repository repo = null;
+    try (Repository repo = repoManager.openRepository(rsrc.getNameKey())) {
-    try {
-      repo = repoManager.openRepository(rsrc.getNameKey());
       Map<String, Ref> cur =
           repo.getRefDatabase().exactRef(Constants.HEAD, ref);
       if (!cur.containsKey(ref)) {
@@ -129,10 +127,6 @@ public class SetHead implements RestModifyView<ProjectResource, Input> {
       return ref;
     } catch (RepositoryNotFoundException e) {
       throw new ResourceNotFoundException(rsrc.getName());
-    } finally {
-      if (repo != null) {
-        repo.close();
-      }
     }
   }
 }

gerrit-server/src/main/java/com/google/gerrit/server/schema/SchemaUpdater.java

@@ -90,8 +90,7 @@ public class SchemaUpdater {
   }
 
   public void update(final UpdateUI ui) throws OrmException {
-    final ReviewDb db = schema.open();
+    try (ReviewDb db = schema.open()) {
-    try {
       final SchemaVersion u = updater.get();
       final CurrentSchemaVersion version = getSchemaVersion(db);
       if (version == null) {
@@ -112,8 +111,6 @@ public class SchemaUpdater {
 
         updateSystemConfig(db);
       }
-    } finally {
-      db.close();
     }
   }
 

gerrit-server/src/main/java/com/google/gerrit/server/schema/SchemaVersionCheck.java

@@ -48,31 +48,26 @@ public class SchemaVersionCheck implements LifecycleListener {
 
   @Override
   public void start() {
-    try {
+    try (ReviewDb db = schema.open()) {
-      final ReviewDb db = schema.open();
+      final CurrentSchemaVersion currentVer = getSchemaVersion(db);
-      try {
+      final int expectedVer = SchemaVersion.getBinaryVersion();
-        final CurrentSchemaVersion currentVer = getSchemaVersion(db);
-        final int expectedVer = SchemaVersion.getBinaryVersion();
 
-        if (currentVer == null) {
+      if (currentVer == null) {
-          throw new ProvisionException("Schema not yet initialized."
+        throw new ProvisionException("Schema not yet initialized."
-              + "  Run init to initialize the schema:\n"
+            + "  Run init to initialize the schema:\n"
-              + "$ java -jar gerrit.war init -d "
+            + "$ java -jar gerrit.war init -d "
-              + site.site_path.toAbsolutePath());
+            + site.site_path.toAbsolutePath());
-        }
+      }
-        if (currentVer.versionNbr < expectedVer) {
+      if (currentVer.versionNbr < expectedVer) {
-          throw new ProvisionException("Unsupported schema version "
+        throw new ProvisionException("Unsupported schema version "
-              + currentVer.versionNbr + "; expected schema version " + expectedVer
+            + currentVer.versionNbr + "; expected schema version " + expectedVer
-              + ".  Run init to upgrade:\n"
+            + ".  Run init to upgrade:\n"
-              + "$ java -jar " + site.gerrit_war.toAbsolutePath() + " init -d "
+            + "$ java -jar " + site.gerrit_war.toAbsolutePath() + " init -d "
-              + site.site_path.toAbsolutePath());
+            + site.site_path.toAbsolutePath());
-        } else if (currentVer.versionNbr > expectedVer) {
+      } else if (currentVer.versionNbr > expectedVer) {
-          throw new ProvisionException("Unsupported schema version "
+        throw new ProvisionException("Unsupported schema version "
-              + currentVer.versionNbr + "; expected schema version " + expectedVer
+            + currentVer.versionNbr + "; expected schema version " + expectedVer
-              + ". Downgrade is not supported.");
+            + ". Downgrade is not supported.");
-        }
-      } finally {
-        db.close();
       }
     } catch (OrmException e) {
       throw new ProvisionException("Cannot read schema_version", e);

gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_106.java

@@ -61,38 +61,33 @@ public class Schema_106 extends SchemaVersion {
     ui.message(String.format("creating reflog files for %s branches ...",
         RefNames.REFS_CONFIG));
     for (Project.NameKey project : repoList) {
-      try {
+      try (Repository repo = repoManager.openRepository(project)) {
-        Repository repo = repoManager.openRepository(project);
+        File metaConfigLog =
-        try {
+            new File(repo.getDirectory(), "logs/" + RefNames.REFS_CONFIG);
-          File metaConfigLog =
+        if (metaConfigLog.exists()) {
-              new File(repo.getDirectory(), "logs/" + RefNames.REFS_CONFIG);
+          continue;
-          if (metaConfigLog.exists()) {
+        }
-            continue;
-          }
 
-          if (!metaConfigLog.getParentFile().mkdirs()
+        if (!metaConfigLog.getParentFile().mkdirs()
-              || !metaConfigLog.createNewFile()) {
+            || !metaConfigLog.createNewFile()) {
-            throw new IOException(String.format(
+          throw new IOException(String.format(
-                "Failed to create reflog for %s in repository %s",
+              "Failed to create reflog for %s in repository %s",
-                RefNames.REFS_CONFIG, project));
+              RefNames.REFS_CONFIG, project));
-          }
+        }
 
-          ObjectId metaConfigId = repo.resolve(RefNames.REFS_CONFIG);
+        ObjectId metaConfigId = repo.resolve(RefNames.REFS_CONFIG);
-          if (metaConfigId != null) {
+        if (metaConfigId != null) {
-            try (PrintWriter writer =
+          try (PrintWriter writer =
-                new PrintWriter(metaConfigLog, UTF_8.name())) {
+              new PrintWriter(metaConfigLog, UTF_8.name())) {
-              writer.print(ObjectId.zeroId().name());
+            writer.print(ObjectId.zeroId().name());
-              writer.print(" ");
+            writer.print(" ");
-              writer.print(metaConfigId.name());
+            writer.print(metaConfigId.name());
-              writer.print(" ");
+            writer.print(" ");
-              writer.print(serverUser.toExternalString());
+            writer.print(serverUser.toExternalString());
-              writer.print("\t");
+            writer.print("\t");
-              writer.print("create reflog");
+            writer.print("create reflog");
-              writer.println();
+            writer.println();
-            }
           }
-        } finally {
-          repo.close();
         }
       } catch (IOException e) {
         ui.message(String.format("ERROR: Failed to create reflog file for the"

gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_107.java

@@ -31,11 +31,8 @@ public class Schema_107 extends SchemaVersion {
 
   @Override
   protected void migrateData(ReviewDb db, UpdateUI ui) throws SQLException {
-    Statement stmt = ((JdbcSchema) db).getConnection().createStatement();
+    try (Statement stmt = ((JdbcSchema) db).getConnection().createStatement()) {
-    try {
       stmt.executeUpdate("UPDATE accounts set mute_common_path_prefixes = 'Y'");
-    } finally {
-      stmt.close();
     }
   }
 }

gerrit-server/src/main/java/com/google/gerrit/server/schema/ScriptRunner.java

@@ -73,8 +73,7 @@ class ScriptRunner {
   }
 
   private List<String> parse(final InputStream in) throws IOException {
-    BufferedReader br = new BufferedReader(new InputStreamReader(in, "UTF-8"));
+    try (BufferedReader br = new BufferedReader(new InputStreamReader(in, "UTF-8"))) {
-    try {
       String delimiter = ";";
       List<String> commands = new ArrayList<>();
       StringBuilder buffer = new StringBuilder();
@@ -107,8 +106,6 @@ class ScriptRunner {
         commands.add(buffer.toString());
       }
       return commands;
-    } finally {
-      br.close();
     }
   }
 

gerrit-server/src/main/java/com/google/gerrit/server/tools/ToolsCatalog.java

@@ -109,21 +109,15 @@ public class ToolsCatalog {
 
   private static byte[] read(String path) {
     String name = "root/" + path;
-    InputStream in = ToolsCatalog.class.getResourceAsStream(name);
+    try (InputStream in = ToolsCatalog.class.getResourceAsStream(name)) {
-    if (in == null) {
+      if (in == null) {
-      return null;
+        return null;
-    }
+      }
-
-    try {
       final ByteArrayOutputStream out = new ByteArrayOutputStream();
-      try {
+      final byte[] buf = new byte[8192];
-        final byte[] buf = new byte[8192];
+      int n;
-        int n;
+      while ((n = in.read(buf, 0, buf.length)) > 0) {
-        while ((n = in.read(buf, 0, buf.length)) > 0) {
+        out.write(buf, 0, n);
-          out.write(buf, 0, n);
-        }
-      } finally {
-        in.close();
       }
       return out.toByteArray();
     } catch (Exception e) {