opendev/gerrit
Code Issues Proposed changes

Fix usage of assertThat in assertReviewers

Browse Source 
Instead of:

 assertThat(iterable.isEmpty()).isTrue()

use:

 assertThat(iterable).isEmpty()

Also add a cast to prevent deprecation warning that was introduced
in version 0.25 of the Truth library.

Change-Id: I551229051af3c87fe7031f4f0f6433ef8e673fe6
This commit is contained in:
David Pursehouse 2015-01-28 11:14:56 +09:00
parent 8c285cde0b
commit 5e996fd3d4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/PushOneCommit.java
View File

@ -258,9 +258,9 @@ public class PushOneCommit {
.named("unexpected reviewer " + accountId)
.isTrue();
}
assertThat(expectedReviewerIds.isEmpty())
assertThat((Iterable<?>)expectedReviewerIds)
.named("missing reviewers: " + expectedReviewerIds)
.isTrue();
.isEmpty();
}
public void assertOkStatus() {