opendev/gerrit
Code Issues Proposed changes

Merge "Remove required access permission to get account username"

Browse Source
This commit is contained in:
David Pursehouse
2016-01-13 00:24:18 +00:00
committed by Gerrit Code Review
parent 318007a832 971caef87a
commit 5eaa1e37ef
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-server/src/main/java/com/google/gerrit/server/account/GetUsername.java
View File

@@ -35,10 +35,6 @@ public class GetUsername implements RestReadView<AccountResource> {
@Override @Override
public String apply(AccountResource rsrc) throws AuthException, public String apply(AccountResource rsrc) throws AuthException,
ResourceNotFoundException { ResourceNotFoundException {
if (self.get() != rsrc.getUser()
&& !self.get().getCapabilities().canAdministrateServer()) {
throw new AuthException("not allowed to get username");
}
String username = rsrc.getUser().getAccount().getUserName(); String username = rsrc.getUser().getAccount().getUserName();
if (username == null) { if (username == null) {
throw new ResourceNotFoundException(); throw new ResourceNotFoundException();