opendev/gerrit
Code Issues Proposed changes

Cleanup Gerrit global variable from tests and types

Browse Source 
Change-Id: I70d8fcd68a8c7982f0ebbb9242f9cf4455fac86f
This commit is contained in:
Dmitrii Filippov
2020-04-07 18:49:00 +02:00
parent 297812141d
commit 5f25dc0f3a
28 changed files with 117 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
polygerrit-ui/app/elements/plugins/gr-settings-api/gr-settings-api_test.html
View File

@@ -37,9 +37,9 @@ limitations under the License.
import '../../../test/common-test-setup.js';
import '../gr-endpoint-decorator/gr-endpoint-decorator.js';
import {pluginLoader} from '../../shared/gr-js-api-interface/gr-plugin-loader.js';
import {initGerritPluginApi} from '../../shared/gr-js-api-interface/gr-gerrit.js';
import {_testOnly_initGerritPluginApi} from '../../shared/gr-js-api-interface/gr-gerrit.js';
initGerritPluginApi();
const pluginApi = _testOnly_initGerritPluginApi();
suite('gr-settings-api tests', () => {
let sandbox;
@@ -48,7 +48,7 @@ suite('gr-settings-api tests', () => {
setup(() => {
sandbox = sinon.sandbox.create();
let plugin;
Gerrit.install(p => { plugin = p; }, '0.1',
pluginApi.install(p => { plugin = p; }, '0.1',
'http://test.com/plugins/testplugin/static/test.js');
pluginLoader.loadPlugins([]);
settingsApi = plugin.settings();