opendev/gerrit
Code Issues Proposed changes

Make LabelTypeIT tests assume copy-score defaults now initialized herein

Browse Source 
Remove overriding settings from LabelTypeIT setUp so that those tests
assume defaults defined in LabelType (and exercised in ProjectConfig).

Add initialization of such defaults to LabelType constructor; otherwise,
defaults set to true were not initialized as such, served false instead.

Add mentions of false defaults to Documentation, for copyMinScore and
copyMaxScore (used to be missing). Only allProjects had its copyMinScore
default set to true, in AllProjectsCreator (initCodeReviewLabel).

Change-Id: I7957ff8d628d7e1744a910e66dcae6b41343a7e7
This commit is contained in:
Marco Miller
2015-03-13 17:20:44 -04:00
committed by David Pursehouse
parent 5a65d032f3
commit 5f834717cc
3 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-common/src/main/java/com/google/gerrit/common/data/LabelType.java
View File

@@ -134,6 +134,12 @@ public class LabelType {
maxPositive = values.get(values.size() - 1).getValue();
}
}
setCanOverride(DEF_CAN_OVERRIDE);
setCopyAllScoresIfNoChange(DEF_COPY_ALL_SCORES_IF_NO_CHANGE);
setCopyAllScoresIfNoCodeChange(DEF_COPY_ALL_SCORES_IF_NO_CODE_CHANGE);
setCopyAllScoresOnTrivialRebase(DEF_COPY_ALL_SCORES_ON_TRIVIAL_REBASE);
setCopyMaxScore(DEF_COPY_MAX_SCORE);
setCopyMinScore(DEF_COPY_MIN_SCORE);
}
public String getName() {