opendev/gerrit
Code Issues Proposed changes

Increase change screen refresh to 5 mins

Browse Source 
Increase default setting of change.updateDelay to facilitate new
Gerrit setups of novice users to scale up even with limited
resources availability.

The old value (30 seconds) was too small and caused problems
of server overloaded by REST API calls.

Change-Id: I68f8adfbb887e7f300e6c53b791570e4b22a5458
This commit is contained in:
Luca Milanesio
2017-04-25 10:51:30 +02:00
parent c1832d93dd
commit 6002d2f48c
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Documentation/config-gerrit.txt
View File

@@ -998,7 +998,7 @@ requests per second and requires ~10% CPU.
+
If 0 the update polling is disabled.
+
Default is 30 seconds.
Default is 5 minutes.
[[change.allowBlame]]change.allowBlame::
+

2
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/config/ServerInfoIT.java
View File

@@ -168,7 +168,7 @@ public class ServerInfoIT extends AbstractDaemonTest {
assertThat(i.change.largeChange).isEqualTo(500);
assertThat(i.change.replyTooltip).startsWith("Reply and score");
assertThat(i.change.replyLabel).isEqualTo("Reply\u2026");
assertThat(i.change.updateDelay).isEqualTo(30);
assertThat(i.change.updateDelay).isEqualTo(300);
// download
assertThat(i.download.archives).containsExactly("tar", "tbz2", "tgz", "txz");

2
gerrit-server/src/main/java/com/google/gerrit/server/config/GetServerInfo.java
View File

@@ -216,7 +216,7 @@ public class GetServerInfo implements RestReadView<ConfigResource> {
info.replyLabel =
Optional.ofNullable(cfg.getString("change", null, "replyLabel")).orElse("Reply") + "\u2026";
info.updateDelay =
(int) ConfigUtil.getTimeUnit(cfg, "change", null, "updateDelay", 30, TimeUnit.SECONDS);
(int) ConfigUtil.getTimeUnit(cfg, "change", null, "updateDelay", 300, TimeUnit.SECONDS);
info.submitWholeTopic = Submit.wholeTopicEnabled(cfg);
return info;
}