diff --git a/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java b/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java index 2a0699ff7b..f998ad3fc6 100644 --- a/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java +++ b/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java @@ -46,7 +46,6 @@ import com.google.gerrit.reviewdb.client.AccountGroup; import com.google.gerrit.reviewdb.client.Branch; import com.google.gerrit.reviewdb.client.Change; import com.google.gerrit.reviewdb.client.RefNames; -import com.google.gerrit.server.AnonymousUser; import com.google.gerrit.server.CommentsUtil; import com.google.gerrit.server.CurrentUser; import com.google.gerrit.server.IdentifiedUser; @@ -71,7 +70,6 @@ import com.google.gerrit.server.index.change.ChangeField; import com.google.gerrit.server.index.change.ChangeIndex; import com.google.gerrit.server.index.change.ChangeIndexCollection; import com.google.gerrit.server.index.change.ChangeIndexRewriter; -import com.google.gerrit.server.notedb.ChangeNotes; import com.google.gerrit.server.notedb.ReviewerStateInternal; import com.google.gerrit.server.patch.PatchListCache; import com.google.gerrit.server.permissions.PermissionBackend; @@ -206,7 +204,6 @@ public class ChangeQueryBuilder extends QueryBuilder hasOperands; @@ -222,7 +219,7 @@ public class ChangeQueryBuilder extends QueryBuilder anonymousUserProvider; + final ChangeIsVisibleToPredicate.Factory changeIsVisbleToPredicateFactory; private final Provider self; @@ -236,7 +233,6 @@ public class ChangeQueryBuilder extends QueryBuilder self, PermissionBackend permissionBackend, - ChangeNotes.Factory notesFactory, ChangeData.Factory changeDataFactory, CommentsUtil commentsUtil, AccountResolver accountResolver, @@ -254,7 +250,7 @@ public class ChangeQueryBuilder extends QueryBuilder anonymousUserProvider) { + ChangeIsVisibleToPredicate.Factory changeIsVisbleToPredicateFactory) { this( queryProvider, rewriter, @@ -263,7 +259,6 @@ public class ChangeQueryBuilder extends QueryBuilder self, PermissionBackend permissionBackend, - ChangeNotes.Factory notesFactory, ChangeData.Factory changeDataFactory, CommentsUtil commentsUtil, AccountResolver accountResolver, @@ -310,14 +304,13 @@ public class ChangeQueryBuilder extends QueryBuilder anonymousUserProvider) { + ChangeIsVisibleToPredicate.Factory changeIsVisbleToPredicateFactory) { this.queryProvider = queryProvider; this.rewriter = rewriter; this.opFactories = opFactories; this.userFactory = userFactory; this.self = self; this.permissionBackend = permissionBackend; - this.notesFactory = notesFactory; this.changeDataFactory = changeDataFactory; this.commentsUtil = commentsUtil; this.accountResolver = accountResolver; @@ -336,7 +329,7 @@ public class ChangeQueryBuilder extends QueryBuilder visibleto(CurrentUser user) { - return new ChangeIsVisibleToPredicate( - args.notesFactory, - args.permissionBackend, - args.projectCache, - args.anonymousUserProvider, - user); + return args.changeIsVisbleToPredicateFactory.forUser(user); } public Predicate isVisible() throws QueryParseException { diff --git a/javatests/com/google/gerrit/server/index/change/FakeQueryBuilder.java b/javatests/com/google/gerrit/server/index/change/FakeQueryBuilder.java index 0753127b52..a713221a45 100644 --- a/javatests/com/google/gerrit/server/index/change/FakeQueryBuilder.java +++ b/javatests/com/google/gerrit/server/index/change/FakeQueryBuilder.java @@ -27,7 +27,7 @@ public class FakeQueryBuilder extends ChangeQueryBuilder { new ChangeQueryBuilder.Definition<>(FakeQueryBuilder.class), new ChangeQueryBuilder.Arguments( null, null, null, null, null, null, null, null, null, null, null, null, null, null, - null, null, null, null, indexes, null, null, null, null, null, null, null)); + null, null, null, indexes, null, null, null, null, null, null, null)); } @Operator