opendev/gerrit
Code Issues Proposed changes

Add CCed on section to dashboard

Browse Source 
Also, the test suite fails with network and JS exceptions. CI has been
passing because this suite was never added to test/index.html.

Bug: Issue 7793
Change-Id: I8dce2773242b56906122b3083b7f4016b54bd18f
This commit is contained in:
Kasper Nilsson
2018-02-12 16:37:29 -08:00
parent ad49bcd420
commit 6096e24cb0
3 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js
View File

@@ -42,6 +42,12 @@
query: 'is:open -owner:${user} -is:wip -is:ignored ' + query: 'is:open -owner:${user} -is:wip -is:ignored ' +
'(reviewer:${user} OR assignee:${user})', '(reviewer:${user} OR assignee:${user})',
}, },
{
// Open changes the viewed user is CCed on. Changes ignored by the viewing
// user are filtered out.
name: 'CCed on',
query: 'is:open -is:ignored cc:${user}',
},
{ {
name: 'Recently closed', name: 'Recently closed',
// Closed changes where viewed user is owner, reviewer, or assignee. // Closed changes where viewed user is owner, reviewer, or assignee.

9
polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view_test.html
View File

@@ -38,6 +38,11 @@ limitations under the License.
let paramsChangedPromise; let paramsChangedPromise;
setup(() => { setup(() => {
stub('gr-rest-api-interface', {
getLoggedIn() { return Promise.resolve(false); },
getAccountDetails() { return Promise.resolve({}); },
getAccountStatus() { return Promise.resolve(false); },
});
element = fixture('basic'); element = fixture('basic');
sandbox = sinon.sandbox.create(); sandbox = sinon.sandbox.create();
getChangesStub = sandbox.stub(element.$.restAPI, 'getChanges', getChangesStub = sandbox.stub(element.$.restAPI, 'getChanges',
@@ -234,8 +239,8 @@ limitations under the License.
}); });
test('_computeUserHeaderClass', () => { test('_computeUserHeaderClass', () => {
assert.equal(element._computeUserHeaderClass(undefined), 'hide'); assert.equal(element._computeUserHeaderClass(undefined), '');
assert.equal(element._computeUserHeaderClass(''), 'hide'); assert.equal(element._computeUserHeaderClass(''), '');
assert.equal(element._computeUserHeaderClass('self'), 'hide'); assert.equal(element._computeUserHeaderClass('self'), 'hide');
assert.equal(element._computeUserHeaderClass('user'), ''); assert.equal(element._computeUserHeaderClass('user'), '');
}); });

1
polygerrit-ui/app/test/index.html
View File

@@ -55,6 +55,7 @@ limitations under the License.
'change-list/gr-change-list-item/gr-change-list-item_test.html', 'change-list/gr-change-list-item/gr-change-list-item_test.html',
'change-list/gr-change-list-view/gr-change-list-view_test.html', 'change-list/gr-change-list-view/gr-change-list-view_test.html',
'change-list/gr-change-list/gr-change-list_test.html', 'change-list/gr-change-list/gr-change-list_test.html',
'change-list/gr-dashboard-view/gr-dashboard-view_test.html',
'change-list/gr-user-header/gr-user-header_test.html', 'change-list/gr-user-header/gr-user-header_test.html',
'change/gr-account-entry/gr-account-entry_test.html', 'change/gr-account-entry/gr-account-entry_test.html',
'change/gr-account-list/gr-account-list_test.html', 'change/gr-account-list/gr-account-list_test.html',