opendev/gerrit
Code Issues Proposed changes

Don't constrain max diff line length to 80ch via CSS

Browse Source 
Because CJK (Chinese-Japanese-Korean) glyphs may have variable width.

Bug: Issue 7984
Change-Id: Ifef672f03329db3770279f28f50033bd50f23934
This commit is contained in:
Viktar Donich
2018-04-11 13:34:40 -07:00
parent 4418114968
commit 60cbd2f4c6
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
polygerrit-ui/app/elements/diff/gr-diff/gr-diff.html
View File

@@ -119,9 +119,9 @@ limitations under the License.
} }
.content { .content {
overflow: hidden; overflow: hidden;
/* Set max and min width since setting width on table cells still /* Set min width since setting width on table cells still
allows them to shrink. */ allows them to shrink. Do not set max width because
max-width: var(--content-width, 80ch); CJK (Chinese-Japanese-Korean) glyphs have variable width */
min-width: var(--content-width, 80ch); min-width: var(--content-width, 80ch);
width: var(--content-width, 80ch); width: var(--content-width, 80ch);
} }