diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/BinaryResult.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/BinaryResult.java index a21c2d4bef..068d9a0295 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/BinaryResult.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/restapi/BinaryResult.java @@ -62,7 +62,7 @@ public abstract class BinaryResult implements Closeable { private Charset characterEncoding; private long contentLength = -1; private boolean gzip = true; - private boolean base64 = false; + private boolean base64; private String attachmentName; /** @return the MIME type of the result, for HTTP clients. */ diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/documentation/DocTable.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/documentation/DocTable.java index 8238b14421..0c5be8ee68 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/documentation/DocTable.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/documentation/DocTable.java @@ -28,8 +28,8 @@ import com.google.gwt.user.client.ui.HTMLTable.CellFormatter; class DocTable extends NavigationTable { private static final int C_TITLE = 1; - private int rows = 0; - private int dataBeginRow = 0; + private int rows; + private int dataBeginRow; DocTable() { super(Util.C.docItemHelp()); diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommentedActionDialog.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommentedActionDialog.java index 60b5f930d2..c21d5dcff0 100644 --- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommentedActionDialog.java +++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/CommentedActionDialog.java @@ -35,7 +35,7 @@ public abstract class CommentedActionDialog extends AutoCenterDialogBox protected final FlowPanel contentPanel; protected FocusWidget focusOn; - protected boolean sent = false; + protected boolean sent; public CommentedActionDialog(final String title, final String heading) { super(/* auto hide */false, /* modal */true); diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Init.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Init.java index f57f95f17e..107bad830a 100644 --- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Init.java +++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/Init.java @@ -52,7 +52,7 @@ public class Init extends BaseInit { private boolean noAutoStart; @Option(name = "--skip-plugins", usage = "Don't install plugins") - private boolean skipPlugins = false; + private boolean skipPlugins; @Option(name = "--list-plugins", usage = "List available plugins") private boolean listPlugins; diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java index 8922df5e52..dd57ed40e1 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java @@ -473,8 +473,8 @@ public class RefControl { } private static class AllowedRange { - private int allowMin = 0; - private int allowMax = 0; + private int allowMin; + private int allowMax; private int blockMin = Integer.MIN_VALUE; private int blockMax = Integer.MAX_VALUE; diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/AdminSetParent.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/AdminSetParent.java index 2fb91f6642..1b21912801 100644 --- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/AdminSetParent.java +++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/AdminSetParent.java @@ -81,7 +81,7 @@ final class AdminSetParent extends SshCommand { @Inject private Provider listChildProjects; - private Project.NameKey newParentKey = null; + private Project.NameKey newParentKey; @Override protected void run() throws Failure { diff --git a/plugins/cookbook-plugin b/plugins/cookbook-plugin index 32b238a2ff..9286b87ba7 160000 --- a/plugins/cookbook-plugin +++ b/plugins/cookbook-plugin @@ -1 +1 @@ -Subproject commit 32b238a2ff9625b17d9dc44e145de269ec833736 +Subproject commit 9286b87ba7936af7f66b6562adb54e8d276cb5cb diff --git a/tools/checkstyle.xml b/tools/checkstyle.xml index 0e7fd47968..6a8cfa993b 100644 --- a/tools/checkstyle.xml +++ b/tools/checkstyle.xml @@ -95,6 +95,7 @@ edited to remove noisy warnings. +