opendev/gerrit
Code Issues Proposed changes

ChangeScreen2: Simplify creation of weblink anchors

Browse Source 
A widget is overkill here as the object gets discarded and no
listeners are installed.  Instead use a simple anchor element.

Change-Id: Ia341965a60d90ceca0b05724ad7db30c187844ff
This commit is contained in:
Shawn Pearce
2014-03-27 18:01:19 -07:00
parent bc31c47ced
commit 6115dc1c2c
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/CommitBox.java
View File

@@ -29,6 +29,7 @@ import com.google.gerrit.common.PageLinks;
import com.google.gerrit.reviewdb.client.Change.Status;
import com.google.gwt.core.client.GWT;
import com.google.gwt.core.client.JsArray;
import com.google.gwt.dom.client.AnchorElement;
import com.google.gwt.dom.client.Element;
import com.google.gwt.dom.client.TableCellElement;
import com.google.gwt.event.dom.client.ClickEvent;
@@ -36,7 +37,7 @@ import com.google.gwt.resources.client.CssResource;
import com.google.gwt.uibinder.client.UiBinder;
import com.google.gwt.uibinder.client.UiField;
import com.google.gwt.uibinder.client.UiHandler;
import com.google.gwt.user.client.ui.Anchor;
import com.google.gwt.user.client.DOM;
import com.google.gwt.user.client.ui.Button;
import com.google.gwt.user.client.ui.Composite;
import com.google.gwt.user.client.ui.HTML;
@@ -122,11 +123,10 @@ class CommitBox extends Composite {
}
private void addWebLink(String href, String name) {
Anchor a = new Anchor();
AnchorElement a = DOM.createAnchor().cast();
a.setHref(href);
a.setText(name);
Element el = a.getElement();
webLinkCell.appendChild(el);
a.setInnerText(name);
webLinkCell.appendChild(a);
}
private static void formatLink(GitPerson person, InlineHyperlink name,