opendev/gerrit
Code Issues Proposed changes

Removed DESC keyword from several ORM Queries

Browse Source 
In order to better support non-relational DBs that do not support
sorting in a descending order, I have removed the DESC keyword from
several of the ORM queries in which is was present.

Change-Id: Iac9cbc43a62e7e652f721cacf223e8161eb4a280
This commit is contained in:
Jeff Schumacher
2010-05-28 16:11:38 -07:00
parent 2366d781b3
commit 611e4c1520
4 changed files with 24 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/AccountAgreementAccess.java
View File

@@ -25,6 +25,6 @@ public interface AccountAgreementAccess extends
@PrimaryKey("key")
AccountAgreement get(AccountAgreement.Key key) throws OrmException;
@Query("WHERE key.accountId = ? ORDER BY acceptedOn DESC")
@Query("WHERE key.accountId = ? ORDER BY acceptedOn")
ResultSet<AccountAgreement> byAccount(Account.Id id) throws OrmException;
}

2
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/AccountGroupAgreementAccess.java
View File

@@ -25,7 +25,7 @@ public interface AccountGroupAgreementAccess extends
@PrimaryKey("key")
AccountGroupAgreement get(AccountGroupAgreement.Key key) throws OrmException;
@Query("WHERE key.groupId = ? ORDER BY acceptedOn DESC")
@Query("WHERE key.groupId = ? ORDER BY acceptedOn")
ResultSet<AccountGroupAgreement> byGroup(AccountGroup.Id id)
throws OrmException;
}