opendev/gerrit
Code Issues Proposed changes

BaseCommand: Fix formatting of task description with arguments

Browse Source 
The task name is being generated as the command name followed by the
trimmed arguments, but without any space, for example:

  SSH gerrit plugin rmreadonly (admin)

Fix it so that there is a space:

  SSH gerrit plugin rm readonly (admin)

Change-Id: Ib5e0409a68527d810df25cd621e0e62f4442c02e
This commit is contained in:
David Pursehouse 2018-03-02 10:10:49 +09:00
parent c58fb2b3ef
commit 612814ee48
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-sshd/src/main/java/com/google/gerrit/sshd/BaseCommand.java
View File

@ -394,12 +394,11 @@ public abstract class BaseCommand implements Command {
}
protected String getTaskDescription() {
StringBuilder m = new StringBuilder(commandName);
String[] ta = getTrimmedArguments();
if (ta != null) {
m.append(Joiner.on(" ").join(ta));
return commandName + " " + Joiner.on(" ").join(ta);
}
return m.toString();
return commandName;
}
private String getTaskName() {