Update Buck

$DEPS is now funny, it is an unexpanded string using the shell
variable $GEN_DIR. Upstream buck suggests using $(eval echo $DEPS)
to access the string value as $DEPS will not expand to the complete
file paths.

Instead of using eval modify our only use of $DEPS inside of the
GWT compiler helper to replace $GEN_DIR at the start of a string
with the value from the environment.

The JUnit support in Buck was updated recently and PrologTestCase
is being identified as a test to run. Rename its execution method
to prevent it from being identified as a test and push real call
down into the concrete base class.

Change-Id: Ic7e119cd26e72ee95e155e8507785c77b7692acf

.buckversion

@@ -1 +1 @@
-902da64779068acd3acb5bc193045ee15a34dc85
+5fc60079d9dbaaf8a1e7d542dcb21fd901f68245

gerrit-server/BUCK

@@ -58,13 +58,44 @@ java_sources(
   visibility = ['PUBLIC'],
 )
 
-java_test(
+PROLOG_TEST_CASE = [
-  name = 'server_tests',
+  'src/test/java/com/google/gerrit/rules/PrologTestCase.java',
-  srcs = glob(['src/test/java/**/*.java']),
+]
-  resources = glob(['src/test/resources/**/*']),
+PROLOG_TESTS = glob(
+  ['src/test/java/com/google/gerrit/rules/**/*.java'],
+  excludes = PROLOG_TEST_CASE,
+)
+
+java_library(
+  name = 'prolog_test_case',
+  srcs = PROLOG_TEST_CASE,
   deps = [
     ':server',
+    '//lib:junit',
+    '//lib/guice:guice',
+    '//lib/prolog:prolog-cafe',
+  ],
+  export_deps = True,
+)
+
+java_test(
+  name = 'prolog_tests',
+  srcs = PROLOG_TESTS,
+  resources = glob(['src/test/resources/com/google/gerrit/rules/**/*']),
+  deps = [
+    ':prolog_test_case',
     '//gerrit-server/src/main/prolog:common',
+  ],
+)
+
+java_test(
+  name = 'server_tests',
+  srcs = glob(
+    ['src/test/java/**/*.java'],
+    excludes = PROLOG_TESTS + PROLOG_TEST_CASE
+  ),
+  deps = [
+    ':server',
     '//gerrit-antlr:query_exception',
     '//gerrit-antlr:query_parser',
     '//gerrit-common:server',

gerrit-server/src/test/java/com/google/gerrit/rules/GerritCommonTest.java

@@ -69,6 +69,10 @@ public class GerritCommonTest extends PrologTestCase {
         new Branch.NameKey(projects.allProjectsName, "master")));
   }
 
+  public void testGerritCommon() {
+    runPrologBasedTests();
+  }
+
   private static LabelValue value(int value, String text) {
     return new LabelValue((short) value, text);
   }

gerrit-server/src/test/java/com/google/gerrit/rules/PrologTestCase.java

@@ -114,7 +114,7 @@ public abstract class PrologTestCase extends TestCase {
     return env.execute(Prolog.BUILTIN, "clause", head, new VariableTerm());
   }
 
-  public void testRunPrologTestCases() {
+  public void runPrologBasedTests() {
     int errors = 0;
     long start = System.currentTimeMillis();
 

lib/gwt/compiler.py

@@ -26,7 +26,7 @@ module, outzip = argv[1], argv[2]
 for a in argv[3:]:
   if end:
     if a.endswith('.jar'):
-      cp.append(a)
+      cp.append(path.expandvars(a))
   elif a == '--':
     end = True
   else:
@@ -36,7 +36,6 @@ if not outzip.endswith('.zip'):
   print("%s must end with .zip" % outzip, file=stderr)
   exit(1)
 
-rebuild = outzip[:-4] + '.rebuild'
 for d in ['deploy', 'unit_cache', 'work']:
   mkdir(path.join(TMP, d))
 if not path.exists(path.dirname(outzip)):