opendev/gerrit
Code Issues Proposed changes

Allow for shiftKey modifier in search hotkey

Browse Source 
Search keyboard shortcut '/' requires the key combo (shift+7) on a
German keyboard layout. This change whitelists the shiftKey modifier in
the forward slash keypress handler.

Bug: Issue 7672
Change-Id: Iacc0adda03158f61fa7f653d7d29db3e40c3da79
This commit is contained in:
Kasper Nilsson
2017-11-14 15:29:34 -08:00
parent fc8032393c
commit 6288f90ca5
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
polygerrit-ui/app/elements/core/gr-search-bar/gr-search-bar.js
View File

@@ -335,8 +335,9 @@
}, },
_handleForwardSlashKey(e) { _handleForwardSlashKey(e) {
const keyboardEvent = this.getKeyboardEvent(e);
if (this.shouldSuppressKeyboardShortcut(e) || if (this.shouldSuppressKeyboardShortcut(e) ||
this.modifierPressed(e)) { return; } (this.modifierPressed(e) && !keyboardEvent.shiftKey)) { return; }
e.preventDefault(); e.preventDefault();
this.$.searchInput.focus(); this.$.searchInput.focus();