opendev/gerrit
Code Issues Proposed changes

Rename OrmException to StorageException and move to exceptions package

Browse Source 
Subclasses are also renamed:
 * OrmDuplicateKeyException -> DuplicateKeyException
 * OrmRuntimeException -> StorageRuntimeException

Change-Id: I0e934f177e98667ec7cb9912f246ac649a4efd99
This commit is contained in:
Dave Borowitz
2019-01-15 18:45:22 -08:00
parent 9dd73c8a71
commit 62f32fcfd6
500 changed files with 1973 additions and 1941 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/com/google/gerrit/server/change/SetAssigneeOp.java
View File

@@ -17,6 +17,7 @@ package com.google.gerrit.server.change;
import static java.util.Objects.requireNonNull;
import com.google.common.flogger.FluentLogger;
import com.google.gerrit.exceptions.StorageException;
import com.google.gerrit.extensions.restapi.ResourceConflictException;
import com.google.gerrit.extensions.restapi.RestApiException;
import com.google.gerrit.reviewdb.client.Change;
@@ -32,7 +33,6 @@ import com.google.gerrit.server.update.ChangeContext;
import com.google.gerrit.server.update.Context;
import com.google.gerrit.server.validators.AssigneeValidationListener;
import com.google.gerrit.server.validators.ValidationException;
import com.google.gwtorm.server.OrmException;
import com.google.inject.Inject;
import com.google.inject.Provider;
import com.google.inject.assistedinject.Assisted;
@@ -74,7 +74,7 @@ public class SetAssigneeOp implements BatchUpdateOp {
}
@Override
public boolean updateChange(ChangeContext ctx) throws OrmException, RestApiException {
public boolean updateChange(ChangeContext ctx) throws StorageException, RestApiException {
change = ctx.getChange();
if (newAssignee.getAccountId().equals(change.getAssignee())) {
return false;
@@ -117,7 +117,7 @@ public class SetAssigneeOp implements BatchUpdateOp {
}
@Override
public void postUpdate(Context ctx) throws OrmException {
public void postUpdate(Context ctx) throws StorageException {
try {
SetAssigneeSender cm =
setAssigneeSenderFactory.create(